From 20f2df28a41845220ec9e379426c39ce595d18c8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christian=20L=C3=BCck?= <christian@clue.engineering>
Date: Tue, 28 May 2024 09:12:56 +0200
Subject: [PATCH] Avoid creation of dynamic property (PHP 8.2+)

---
 phpunit.xml.dist   | 6 +++++-
 phpunit.xml.legacy | 3 +++
 src/Server.php     | 3 ---
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
index 2548dc0..96144ba 100644
--- a/phpunit.xml.dist
+++ b/phpunit.xml.dist
@@ -5,7 +5,8 @@
          xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.6/phpunit.xsd"
          bootstrap="vendor/autoload.php"
          cacheResult="false"
-         colors="true">
+         colors="true"
+         convertDeprecationsToExceptions="true">
     <testsuites>
         <testsuite name="Socks Test Suite">
             <directory>./tests/</directory>
@@ -16,4 +17,7 @@
             <directory>./src/</directory>
         </include>
     </coverage>
+    <php>
+        <ini name="error_reporting" value="-1" />
+    </php>
 </phpunit>
diff --git a/phpunit.xml.legacy b/phpunit.xml.legacy
index e922482..109458b 100644
--- a/phpunit.xml.legacy
+++ b/phpunit.xml.legacy
@@ -15,4 +15,7 @@
             <directory>./src/</directory>
         </whitelist>
     </filter>
+    <php>
+        <ini name="error_reporting" value="-1" />
+    </php>
 </phpunit>
diff --git a/src/Server.php b/src/Server.php
index ca45015..2d89139 100644
--- a/src/Server.php
+++ b/src/Server.php
@@ -387,9 +387,6 @@ public function connectTarget(ConnectionInterface $stream, array $target)
                 $that->endConnection($remote);
             });
 
-            // set bigger buffer size of 100k to improve performance
-            $stream->bufferSize = $remote->bufferSize = 100 * 1024 * 1024;
-
             return $remote;
         }, function(Exception $error) {
             // default to general/unknown error