Prefer Stdio as input stream instead of advanced Readline

Author: clue

README.md

@@ -154,10 +154,11 @@ $readline = $stdio->getReadline();
 ```
 
 See above for waiting for user input.
+
 Alternatively, the `Readline` is also a well-behaving readable stream
 (implementing ReactPHP's `ReadableStreamInterface`) that emits each complete
-line as a `data` event (without the trailing newline). This is considered
-advanced usage.
+line as a `data` event (without the trailing newline).
+This is considered advanced usage.
 
 #### Prompt
 
@@ -312,11 +313,12 @@ If you want to automatically add everything from the user input to the history,
 you may want to use something like this:
 
 ```php
-$readline->on('data', function ($line) use ($readline) {
+$stdio->on('data', function ($line) use ($readline) {
+    $line = rtrim($line);
     $all = $readline->listHistory();
 
     // skip empty line and duplicate of previous line
-    if (trim($line) !== '' && $line !== end($all)) {
+    if ($line !== '' && $line !== end($all)) {
         $readline->addHistory($line);
     }
 });

examples/02-interactive.php

@@ -21,16 +21,6 @@
     $readline->limitHistory($limit);
 }
 
-// add all lines from input to history
-$readline->on('data', function ($line) use ($readline) {
-    $all = $readline->listHistory();
-
-    // skip empty line and duplicate of previous line
-    if (trim($line) !== '' && $line !== end($all)) {
-        $readline->addHistory($line);
-    }
-});
-
 // autocomplete the following commands (at offset=0/1 only)
 $readline->setAutocomplete(function ($_, $offset) {
     return $offset > 1 ? array() : array('exit', 'quit', 'help', 'echo', 'print', 'printf');
@@ -39,8 +29,17 @@
 $stdio->write('Welcome to this interactive demo' . PHP_EOL);
 
 // react to commands the user entered
-$stdio->on('data', function ($line) use ($stdio) {
-    $stdio->write('you just said: ' . addcslashes($line, "\0..\037") . ' (' . strlen($line) . ')' . PHP_EOL);
+$stdio->on('data', function ($line) use ($stdio, $readline) {
+    $line = rtrim($line, "\r\n");
+
+    // add all lines from input to history
+    // skip empty line and duplicate of previous line
+    $all = $readline->listHistory();
+    if ($line !== '' && $line !== end($all)) {
+        $readline->addHistory($line);
+    }
+
+    $stdio->write('you just said: ' . $line . ' (' . strlen($line) . ')' . PHP_EOL);
 
     if (in_array(trim($line), array('quit', 'exit'))) {
         $stdio->end();