Consistently return boolean success from write()

Author: clue

src/Readline.php

@@ -426,6 +426,14 @@ public function setAutocomplete($autocomplete)
      * @internal
      */
     public function redraw()
+    {
+        $this->output->write($this->__toString());
+
+        return $this;
+    }
+
+    /** @internal */
+    public function __toString()
     {
         // Erase characters from cursor to end of line
         $output = "\r\033[K" . $this->prompt;
@@ -439,9 +447,8 @@ public function redraw()
             // write output, then move back $reverse chars (by sending backspace)
             $output .= $buffer . str_repeat("\x08", $this->strwidth($buffer) - $this->getCursorCell());
         }
-        $this->output->write($output);
 
-        return $this;
+        return $output;
     }
 
     /**

src/Stdio.php

@@ -91,8 +91,9 @@ public function pipe(WritableStreamInterface $dest, array $options = array())
 
     public function write($data)
     {
-        if ($this->ending || (string)$data === '') {
-            return;
+        // return false if already ended, return true if writing empty string
+        if ($this->ending || $data === '') {
+            return !$this->ending;
         }
 
         $out = $data;
@@ -147,8 +148,7 @@ public function write($data)
 
         if ($restoreReadline) {
             // write output and restore original readline prompt and line buffer
-            $this->output->write($out);
-            $this->readline->redraw();
+            return $this->output->write($out . $this->readline->__toString());
         } else {
             // restore original cursor position in readline prompt
             $pos = $this->width($this->readline->getPrompt()) + $this->readline->getCursorCell();
@@ -158,7 +158,7 @@ public function write($data)
             }
 
             // write to actual output stream
-            $this->output->write($out);
+            return $this->output->write($out);
         }
     }
 

tests/StdioTest.php

@@ -50,7 +50,7 @@ public function testWriteEmptyStringWillNotWriteToOutput()
 
         $output->expects($this->never())->method('write');
 
-        $stdio->write('');
+        $this->assertTrue($stdio->write(''));
     }
 
     public function testWriteWillClearReadlineWriteOutputAndRestoreReadline()
@@ -423,7 +423,7 @@ public function testWriteAfterEndWillNotWriteToOutput()
 
         $output->expects($this->never())->method('write');
 
-        $stdio->write('test');
+        $this->assertFalse($stdio->write('test'));
     }
 
     public function testEndTwiceWillCloseInputAndEndOutputOnce()