Merge pull request #23 from clue-labs/move

Direction keys only move cursor if moving is enabled

Author: clue

src/Readline.php

@@ -424,13 +424,17 @@ public function onKeyInsert()
     /** @internal */
     public function onKeyHome()
     {
-        $this->moveCursorTo(0);
+        if ($this->move) {
+            $this->moveCursorTo(0);
+        }
     }
 
     /** @internal */
     public function onKeyEnd()
     {
-        $this->moveCursorTo($this->strlen($this->linebuffer));
+        if ($this->move) {
+            $this->moveCursorTo($this->strlen($this->linebuffer));
+        }
     }
 
     /** @internal */

tests/ReadlineTest.php

@@ -42,6 +42,25 @@ public function testSettingInputMovesCursorToEnd()
         $this->assertEquals(7, $this->readline->getCursorCell());
     }
 
+    public function testSettingMoveOffDoesNotAllowDirectionKeysToChangePosition()
+    {
+        $this->readline->setInput('test');
+        $this->readline->setMove(false);
+        $this->readline->moveCursorTo(2);
+
+        $this->readline->onKeyLeft();
+        $this->assertEquals(2, $this->readline->getCursorPosition());
+
+        $this->readline->onKeyRight();
+        $this->assertEquals(2, $this->readline->getCursorPosition());
+
+        $this->readline->onKeyHome();
+        $this->assertEquals(2, $this->readline->getCursorPosition());
+
+        $this->readline->onKeyEnd();
+        $this->assertEquals(2, $this->readline->getCursorPosition());
+    }
+
     public function testMultiByteInput()
     {
         $this->readline->setInput('täst');
@@ -192,6 +211,32 @@ public function testKeysEndMovesToEnd(Readline $readline)
         $readline->onKeyEnd();
 
         $this->assertEquals(4, $readline->getCursorPosition());
+
+        return $readline;
+    }
+
+    /**
+     * @depends testKeysEndMovesToEnd
+     * @param Readline $readline
+     */
+    public function testKeysLeftMovesToLeft(Readline $readline)
+    {
+        $readline->onKeyLeft();
+
+        $this->assertEquals(3, $readline->getCursorPosition());
+
+        return $readline;
+    }
+
+    /**
+     * @depends testKeysLeftMovesToLeft
+     * @param Readline $readline
+     */
+    public function testKeysRightMovesToRight(Readline $readline)
+    {
+        $readline->onKeyRight();
+
+        $this->assertEquals(4, $readline->getCursorPosition());
     }
 
     public function testKeysSimpleChars()