Replace internal Stdout class with proper Stream handling

Author: clue

composer.json

@@ -13,7 +13,7 @@
     "require": {
         "php": ">=5.3",
         "react/event-loop": "0.3.*|0.4.*",
-        "react/stream": "^0.4.2",
+        "react/stream": "^0.5 || ^0.4.2",
         "clue/utf8-react": "^1.0 || ^0.1",
         "clue/term-react": "^1.0 || ^0.1.1"
     },

examples/11-login.php

@@ -23,17 +23,16 @@
         $first = false;
     } else {
         $password = $line;
-        $stdio->end();
-    }
-});
-
-$loop->run();
-
-echo <<<EOT
+        $stdio->end(<<<EOT
 ---------------------
 Confirmation:
 ---------------------
 Username: $username
 Password: $password
 
-EOT;
+EOT
+        );
+    }
+});
+
+$loop->run();

src/Io/Stdout.php

@@ -10,6 +10,7 @@
 use React\Stream\ReadableStreamInterface;
 use React\Stream\Util;
 use React\Stream\WritableStreamInterface;
+use React\Stream\Stream;
 
 class Stdio extends EventEmitter implements DuplexStreamInterface
 {
@@ -28,7 +29,14 @@ public function __construct(LoopInterface $loop, ReadableStreamInterface $input
         }
 
         if ($output === null) {
-            $output = new Stdout();
+            // STDOUT not defined ("php -a") or already closed (`fclose(STDOUT)`)
+            if (!defined('STDOUT') || !is_resource(STDOUT)) {
+                $output = new Stream(fopen('php://memory', 'r+'), $loop);
+                $output->close();
+            } else {
+                $output = new Stream(STDOUT, $loop);
+                $output->pause();
+            }
         }
 
         if ($readline === null) {

src/Stdio.php

@@ -526,6 +526,9 @@ public function testAutocompleteThrowsIfNotCallable()
         $this->assertSame($this->readline, $this->readline->setAutocomplete(123));
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testAutocompleteKeyDoesNothingIfUnused()
     {
         $this->readline->onKeyTab();

tests/ReadlineTest.php

@@ -15,10 +15,15 @@ public function setUp()
         $this->loop = Factory::create();
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCtorDefaultArgs()
     {
-        $stdio = new Stdio($this->loop);
-        $stdio->close();
+        new Stdio($this->loop);
+
+        // Closing STDIN/STDOUT is not a good idea for reproducible tests
+        // $stdio->close();
     }
 
     public function testCtorReadlineArgWillBeReturnedBygetReadline()