Also accept CR in place of LF to support more platforms

Author: clue

src/Readline.php

@@ -44,10 +44,16 @@ public function __construct(ReadableStreamInterface $input, WritableStreamInterf
 
         $that = $this;
         $codes = array(
-            "\n" => 'onKeyEnter',
-            "\x7f" => 'onKeyBackspace',
-            "\t" => 'onKeyTab',
+            // The user confirms input with enter key which should usually
+            // generate a NL (`\n`) character. Common terminals also seem to
+            // accept a CR (`\r`) character in place and handle this just like a
+            // NL. Similarly `ext-readline` uses different `icrnl` and `igncr`
+            // TTY settings on some platforms, so we also accept both here.
+            "\n" => 'onKeyEnter', // ^J
+            "\r" => 'onKeyEnter', // ^M
 
+            "\x7f" => 'onKeyBackspace',
+            "\t"   => 'onKeyTab',
             "\x04" => 'handleEnd', // CTRL+D
 
             "\033[A" => 'onKeyUp',

tests/ReadlineTest.php

@@ -228,13 +228,20 @@ public function testMovingCursorWithoutEchoDoesNotNeedToRedraw()
         $this->assertSame($this->readline, $this->readline->moveCursorBy(2));
     }
 
-    public function testDataEventWillBeEmittedForCompleteLine()
+    public function testDataEventWillBeEmittedForCompleteLineWithNl()
     {
         $this->readline->on('data', $this->expectCallableOnceWith("hello\n"));
 
         $this->input->emit('data', array("hello\n"));
     }
 
+    public function testDataEventWillBeEmittedWithNlAlsoForCompleteLineWithCr()
+    {
+        $this->readline->on('data', $this->expectCallableOnceWith("hello\n"));
+
+        $this->input->emit('data', array("hello\r"));
+    }
+
     public function testDataEventWillNotBeEmittedForIncompleteLineButWillStayInInputBuffer()
     {
         $this->readline->on('data', $this->expectCallableNever());