Merge pull request #15 from clue-labs/write-on-data

Fix processing events when input writes during data event

Author: clue

src/ControlCodeParser.php

@@ -121,6 +121,7 @@ public function handleData($data)
                 $this->buffer = substr($this->buffer, $c0);
 
                 $this->emit('data', array($data));
+                continue;
             }
 
             // C0 is now at start of buffer

tests/ControlCodeParserTest.php

@@ -87,6 +87,41 @@ public function testEmitsDataAndC0()
         $this->input->emit('data', array("hello world\n"));
     }
 
+    public function testEmitsDataInTwoChunksWithC0InBetween()
+    {
+        // first data event is everything before control code
+        $first = $this->expectCallableOnceWith('hello');
+        $this->parser->once('data', $first);
+
+        // second data event will fire with remaining buffer
+        $second = $this->expectCallableOnceWith('world');
+        $parser = $this->parser;
+        $this->parser->once('data', function () use ($parser, $second) {
+            $parser->once('data', $second);
+        });
+
+        $this->input->emit('data', array("hello\nworld"));
+    }
+
+    public function testEmitsDataInTwoChunkWithC0InBetweenWhileAddingDuringDataEvent()
+    {
+        // first data event is everything before control code
+        $first = $this->expectCallableOnceWith('hello');
+        $this->parser->once('data', $first);
+
+        // second data event will fire with remaining buffer
+        // we write to buffer while processing the first event and expect the full buffer
+        $second = $this->expectCallableOnceWith('worldagain');
+        $input = $this->input;
+        $parser = $this->parser;
+        $this->parser->once('data', function () use ($input, $parser, $second) {
+            $parser->once('data', $second);
+            $input->emit('data', array('again'));
+        });
+
+        $this->input->emit('data', array("hello\nworld"));
+    }
+
     public function testEmitsC0AndData()
     {
         $this->parser->on('data', $this->expectCallableOnceWith("hello world"));