Skip to content

Commit 973df52

Browse files
authored
Merge pull request #21 from SimonFrings/tests
Clean up test suite, add .gitattributes to exclude dev files from exports and run tests on PHP 7.4 and simplify test matrix
2 parents 34c33d8 + f9d089e commit 973df52

File tree

6 files changed

+32
-31
lines changed

6 files changed

+32
-31
lines changed

.gitattributes

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
/.gitattributes export-ignore
2+
/.gitignore export-ignore
3+
/.travis.yml export-ignore
4+
/examples/ export-ignore
5+
/phpunit.xml.dist export-ignore
6+
/tests/ export-ignore

.travis.yml

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,23 @@
11
language: php
22

3-
php:
4-
# - 5.3 # requires old distro, see below
5-
- 5.4
6-
- 5.5
7-
- 5.6
8-
- 7
9-
- 7.1
10-
- 7.2
11-
- hhvm # ignore errors, see below
12-
13-
# lock distro so future defaults will not break the build
3+
# lock distro so new future defaults will not break the build
144
dist: trusty
155

166
matrix:
177
include:
188
- php: 5.3
199
dist: precise
10+
- php: 5.4
11+
- php: 5.5
12+
- php: 5.6
13+
- php: 7.0
14+
- php: 7.1
15+
- php: 7.2
16+
- php: 7.3
17+
- php: 7.4
18+
- php: hhvm-3.18
2019
allow_failures:
21-
- php: hhvm
20+
- php: hhvm-3.18
2221

2322
sudo: false
2423

composer.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,15 @@
1313
"autoload": {
1414
"psr-4": { "Clue\\React\\Utf8\\": "src/" }
1515
},
16+
"autoload-dev": {
17+
"psr-4": { "Clue\\Tests\\React\\Utf8\\": "tests/" }
18+
},
1619
"require": {
1720
"php": ">=5.3",
1821
"react/stream": "^1.0 || ^0.7 || ^0.6 || ^0.5 || ^0.4 || ^0.3"
1922
},
2023
"require-dev": {
21-
"phpunit/phpunit": "^5.0 || ^4.8",
24+
"phpunit/phpunit": "^9.0 ||^5.0 || ^4.8",
2225
"react/stream": "^1.0 || ^0.7"
2326
}
2427
}

phpunit.xml.dist

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22

3-
<phpunit bootstrap="tests/bootstrap.php"
4-
colors="true"
5-
>
3+
<phpunit bootstrap="vendor/autoload.php" colors="true">
64
<testsuites>
7-
<testsuite>
5+
<testsuite name="Utf8 Test Suite">
86
<directory>./tests/</directory>
97
</testsuite>
108
</testsuites>

tests/SequencerTest.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php
22

3+
namespace Clue\Tests\React\Utf8;
4+
35
use Clue\React\Utf8\Sequencer;
46
use React\Stream\ThroughStream;
57

@@ -8,7 +10,10 @@ class SequencerTest extends TestCase
810
private $input;
911
private $sequencer;
1012

11-
public function setUp()
13+
/**
14+
* @before
15+
*/
16+
public function setUpSequencer()
1217
{
1318
$this->input = new ThroughStream();
1419
$this->sequencer = new Sequencer($this->input);

tests/bootstrap.php renamed to tests/TestCase.php

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
<?php
22

3-
require_once __DIR__ . '/../vendor/autoload.php';
3+
namespace Clue\Tests\React\Utf8;
44

5-
error_reporting(-1);
6-
7-
class TestCase extends PHPUnit_Framework_TestCase
5+
class TestCase extends \PHPUnit\Framework\TestCase
86
{
97
protected function expectCallableNever()
108
{
@@ -53,14 +51,6 @@ protected function expectCallableOnceParameter($type)
5351
*/
5452
protected function createCallableMock()
5553
{
56-
return $this->getMockBuilder('CallableStub')->getMock();
54+
return $this->getMockBuilder('stdClass')->setMethods(array('__invoke'))->getMock();
5755
}
5856
}
59-
60-
class CallableStub
61-
{
62-
public function __invoke()
63-
{
64-
}
65-
}
66-

0 commit comments

Comments
 (0)