Skip to content

Commit f950d22

Browse files
authored
Merge pull request #15 from clue-labs/legacy
Revert "Updating Stream dependency fixes legacy PHP < 5.4 issues"
2 parents b96af83 + ed9996b commit f950d22

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ These inconsistencies exist in the underlying PHP engines and there's little we
141141
* PHP 7 only: Compressing an empty string does not emit any data (not a valid compression stream)
142142
* HHVM only: does not currently support the GZIP and ZLIB format at all (and does not raise an error)
143143
* HHVM only: The [`zlib.deflate` filter function](https://github.com/facebook/hhvm/blob/fee8ae39ce395c7b9b8910dfde6f22a7745aea83/hphp/system/php/stream/default-filters.php#L77) buffers the whole string. This means that compressing a stream of 100 MB actually stores the whole string in memory before invoking the underlying compression algorithm.
144+
* PHP 5.3 only: Tends to SEGFAULT occasionally on shutdown?
144145

145146
Our test suite contains several test cases that exhibit these issues.
146147
If you feel some test case is missing or outdated, we're happy to accept PRs! :)

0 commit comments

Comments
 (0)