Final Project Feedback - BLOCKED

[fodisi]

Hi @cmayorga , I'm a mentor of the consensy bootcamp responsible for grading your project.

Your project has been flagged at the moment becuase I'm unable to test the deployed front-end.
The reason is that there's no CONS token available to stake, and no instructions about how to get it from a faucet (if any).
I'm connected to Ropsten, but the UI says the system is not initialized.

If you don't want to add a faucet, it'd be good if you could send me some CONS at this address: 0x8EDD5c2258CB90fb3Ab9bD789565f0B101d575F0

In addition to the above, running the tests locally aren't working as well. Running yarn test logs the following error:

yarn run v1.22.17
$ npm run ./scripts/test.sh
npm ERR! missing script: ./scripts/test.sh

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/fodisi/.npm/_logs/2021-12-12T23_18_04_190Z-debug.log
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

commands used are:

cd smartcontracts/
yarn test

[cmayorga]

Hi, please test again, Las tests were only tested for windows platforms. Now also tested them in Ubuntu. Please keep in mind i am running at surge, so i have not access to server cron so i need to add reward drops weekly. I guess you were to test in the first week i sent you the project, so i activated again so you can test in this current week. I sent you 1000 CONS tokens to the given address. Thank you

[fodisi]

Hi @cmayorga,
Thanks for following up and sending the CONS to the address.
Congratulations, your Final Project passed! We'll be approving it on the course itself in a week or two, but here's your feedback in the meanwhile:

Frontend:
meets the requiremements. Consider checking the network the user is connected to, and giving an alert if the wrong one.

Unit testing:
Nice unit test coverage. Well done.
Note: not a big deal, but your file ./smartcontracts/package.json is missing the dependency package truffle-assertions, needed to run the unit tests. I had to manually install it here, in addition to running yarn install.

Smart Contracts:
nice to see leveraging on OpenZeppelin and all the thought in the design pattern decisions + avoiding common attacks

Congrats!