Skip to content

Commit dd9633d

Browse files
fix: fix bug that no hypertables are created caused by wrong schema checks
1 parent b717e5a commit dd9633d

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

CmdScale.EntityFrameworkCore.TimescaleDB/TimescaleMigrationsModelDiffer.cs

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,13 @@ public override IReadOnlyList<MigrationOperation> GetDifferences(IRelationalMode
3737
List<CreateHypertableOperation> sourceHypertables = [.. GetHypertables(source)];
3838

3939
// Identify new hypertables
40-
List<CreateHypertableOperation> newHypertables = [.. targetHypertables.Where(t => !sourceHypertables.Any(s => s.TableName == t.TableName && s.Schema == t.Schema))];
40+
List<CreateHypertableOperation> newHypertables = [.. targetHypertables.Where(t => !sourceHypertables.Any(s => s.TableName == t.TableName))];
4141

4242
foreach (CreateHypertableOperation? hypertable in newHypertables)
4343
{
4444
int createTableOpIndex = operations.FindIndex(op =>
4545
op is CreateTableOperation createTable &&
46-
createTable.Name == hypertable.TableName &&
47-
createTable.Schema == hypertable.Schema);
46+
createTable.Name == hypertable.TableName);
4847

4948
if (createTableOpIndex != -1)
5049
{
@@ -90,7 +89,7 @@ op is CreateTableOperation createTable &&
9089
List<AddReorderPolicyOperation> targetPolicies = [.. GetReorderPolicies(target)];
9190

9291
// Identiy new reorder policies
93-
IEnumerable<AddReorderPolicyOperation> newReorderPolicies = targetPolicies.Where(t => !sourcePolicies.Any(s => s.TableName == t.TableName && s.Schema == t.Schema));
92+
IEnumerable<AddReorderPolicyOperation> newReorderPolicies = targetPolicies.Where(t => !sourcePolicies.Any(s => s.TableName == t.TableName));
9493
operations.AddRange(newReorderPolicies);
9594

9695
// Identify updated reorder policies
@@ -133,8 +132,8 @@ op is CreateTableOperation createTable &&
133132
}
134133

135134
IEnumerable<DropReorderPolicyOperation> removedReorderPolicies = sourcePolicies
136-
.Where(s => !targetPolicies.Any(t => t.TableName == s.TableName && t.Schema == s.Schema))
137-
.Select(p => new DropReorderPolicyOperation { TableName = p.TableName, Schema = p.Schema });
135+
.Where(s => !targetPolicies.Any(t => t.TableName == s.TableName))
136+
.Select(p => new DropReorderPolicyOperation { TableName = p.TableName });
138137
operations.AddRange(removedReorderPolicies);
139138

140139
return operations;
@@ -172,7 +171,7 @@ private static IEnumerable<CreateHypertableOperation> GetHypertables(IRelational
172171
continue;
173172
}
174173

175-
174+
176175
string? chunkSkipColumnsString = entityType.FindAnnotation(HypertableAnnotations.ChunkSkipColumns)?.Value as string;
177176
List<string>? chunkSkipColumns = null;
178177
if (!string.IsNullOrWhiteSpace(chunkSkipColumnsString))
@@ -217,7 +216,7 @@ private static IEnumerable<CreateHypertableOperation> GetHypertables(IRelational
217216
EnableCompression = enableCompression,
218217
ChunkSkipColumns = chunkSkipColumns,
219218
AdditionalDimensions = additionalDimensions
220-
};
219+
};
221220
}
222221
}
223222

@@ -253,7 +252,7 @@ private static IEnumerable<AddReorderPolicyOperation> GetReorderPolicies(IRelati
253252
}
254253

255254
DateTime? initialStart = entityType.FindAnnotation(ReorderPolicyAnnotations.InitialStart)?.Value as DateTime?;
256-
255+
257256
yield return new AddReorderPolicyOperation
258257
{
259258
TableName = entityType.GetTableName()!,

0 commit comments

Comments
 (0)