Adds closed webview event

Author: eamodio

docs/telemetry-events.md

@@ -750,6 +750,18 @@ or
 }
 ```
 
+### commitDetails/closed
+
+```typescript
+{
+  [`context.${string}`]: string | number | boolean,
+  'context.webview.host': 'editor' | 'view',
+  'context.webview.id': string,
+  'context.webview.instanceId': string,
+  'context.webview.type': string
+}
+```
+
 ### commitDetails/mode/changed
 
 > Sent when the user changes the selected tab (mode) on the Graph Details view
@@ -943,6 +955,18 @@ or
 }
 ```
 
+### graph/closed
+
+```typescript
+{
+  [`context.${string}`]: string | number | boolean,
+  'context.webview.host': 'editor' | 'view',
+  'context.webview.id': string,
+  'context.webview.instanceId': string,
+  'context.webview.type': string
+}
+```
+
 ### graph/columns/changed
 
 > Sent when the user changes the columns on the Commit Graph
@@ -1185,6 +1209,18 @@ or
 }
 ```
 
+### graphDetails/closed
+
+```typescript
+{
+  [`context.${string}`]: string | number | boolean,
+  'context.webview.host': 'editor' | 'view',
+  'context.webview.id': string,
+  'context.webview.instanceId': string,
+  'context.webview.type': string
+}
+```
+
 ### graphDetails/mode/changed
 
 > Sent when the user changes the selected tab (mode) on the Graph Details view
@@ -1310,6 +1346,18 @@ or
 void
 ```
 
+### home/closed
+
+```typescript
+{
+  [`context.${string}`]: string | number | boolean,
+  'context.webview.host': 'editor' | 'view',
+  'context.webview.id': string,
+  'context.webview.instanceId': string,
+  'context.webview.type': string
+}
+```
+
 ### home/command
 
 > Sent when a Home command is executed
@@ -1735,6 +1783,18 @@ void
 }
 ```
 
+### patchDetails/closed
+
+```typescript
+{
+  [`context.${string}`]: string | number | boolean,
+  'context.webview.host': 'editor' | 'view',
+  'context.webview.id': string,
+  'context.webview.instanceId': string,
+  'context.webview.type': string
+}
+```
+
 ### patchDetails/showAborted
 
 ```typescript
@@ -1880,6 +1940,18 @@ void
 }
 ```
 
+### settings/closed
+
+```typescript
+{
+  [`context.${string}`]: string | number | boolean,
+  'context.webview.host': 'editor' | 'view',
+  'context.webview.id': string,
+  'context.webview.instanceId': string,
+  'context.webview.type': string
+}
+```
+
 ### settings/showAborted
 
 ```typescript
@@ -2169,6 +2241,18 @@ or
 }
 ```
 
+### timeline/closed
+
+```typescript
+{
+  [`context.${string}`]: string | number | boolean,
+  'context.webview.host': 'editor' | 'view',
+  'context.webview.id': string,
+  'context.webview.instanceId': string,
+  'context.webview.type': string
+}
+```
+
 ### timeline/commit/selected
 
 > Sent when the user selects (clicks on) a commit on the Visual History

src/constants.telemetry.ts

@@ -51,7 +51,7 @@ export interface TelemetryGlobalContext extends SubscriptionEventData {
 	'workspace.isTrusted': boolean;
 }
 
-export interface TelemetryEvents extends WebviewShowAbortedEvents, WebviewShownEvents {
+export interface TelemetryEvents extends WebviewShowAbortedEvents, WebviewShownEvents, WebviewClosedEvents {
 	/** Sent when account validation fails */
 	'account/validation/failed': AccountValidationFailedEvent;
 
@@ -307,6 +307,11 @@ type WebviewShownEvents = {
 	>}/shown`]: WebviewShownEventData & Record<`context.${string}`, string | number | boolean | undefined>;
 };
 
+type WebviewClosedEvents = {
+	[K in `${WebviewTypes | WebviewViewTypes}/closed`]: WebviewContextEventData &
+		Record<`context.${string}`, string | number | boolean | undefined>;
+};
+
 type ConfigEventData = {
 	[K in `config.${string}`]: string | number | boolean | null;
 };

src/webviews/webviewController.ts

@@ -227,6 +227,9 @@ export class WebviewController<
 		this.provider?.onFocusChanged?.(false);
 		this.provider?.onVisibilityChanged?.(false);
 
+		const context = this.provider.getTelemetryContext?.() ?? this.getTelemetryContext();
+		this.container.telemetry.sendEvent(`${this.descriptor.type}/closed`, context);
+
 		this._ready = false;
 
 		this._onDidDispose.fire();