refactor(ruff): TRY, PT, BLE

Author: cmp0xff

pyproject.toml

@@ -178,7 +178,6 @@ fix = true
 [tool.ruff.lint]
 extend-select = ["ALL"]
 ignore = [
-  # The following rules are ignored permanently for good reasons
   "COM",     # https://docs.astral.sh/ruff/rules/#flake8-commas-com
   "D",       # https://docs.astral.sh/ruff/rules/#pydocstyle-d
   "E501",    # handled by black https://docs.astral.sh/ruff/rules/line-too-long/
@@ -203,11 +202,8 @@ ignore = [
   "ERA001", "ANN001", "ANN201", "ANN202", "ANN204", "ANN206", "ANN401", "PLR0402", "PLC0105"
   ]
 "scripts/*" = [
-  # The following rules are ignored permanently for good reasons
   "EM",      # https://docs.astral.sh/ruff/rules/#flake8-errmsg-em
   "S603",    # https://docs.astral.sh/ruff/rules/subprocess-without-shell-equals-true/
-  # The following rules are ignored temporarily. Either fix them or move to the permanent list above.
-  "TRY", "PT", "BLE"
 ]
 "tests/*" = [
   # The following rules are ignored permanently for good reasons

scripts/_job.py

@@ -25,7 +25,7 @@ def __rollback_job(steps: deque[Step]) -> None:
             logger.warning(f"Undoing: {step.name}")
             try:
                 step.rollback()
-            except Exception:
+            except Exception:  # noqa: BLE001
                 logger.error(
                     f"Rollback of Step: '{step.name}' failed! The project could be in a unstable mode."
                 )
@@ -47,7 +47,7 @@ def run_job(steps: list[Step]) -> None:
             rollback_steps.append(step)
             step.run()
 
-        except Exception:
+        except Exception:  # noqa: BLE001
             logger.error(f"Step: '{step.name}' failed!")
             __rollback_job(rollback_steps)
             failed = True

scripts/test/__init__.py

@@ -22,9 +22,9 @@
 
 
 def test(
-    src: bool = False,
-    dist: bool = False,
-    type_checker: Literal["", "mypy", "pyright"] = "",
+    src: bool = False,  # noqa: PT028
+    dist: bool = False,  # noqa: PT028
+    type_checker: Literal["", "mypy", "pyright"] = "",  # noqa: PT028
 ) -> None:
     steps = []
     if src:

scripts/test/run.py

@@ -62,7 +62,9 @@ def rename_src() -> None:
     if Path(r"pandas-stubs").exists():
         Path(r"pandas-stubs").rename("_pandas-stubs")
     else:
-        raise FileNotFoundError("'pandas-stubs' folder does not exists.")
+        raise FileNotFoundError(  # noqa: TRY003
+            "'pandas-stubs' folder does not exists."
+        )
 
 
 def mypy_dist() -> None:
@@ -84,7 +86,9 @@ def restore_src() -> None:
     if Path(r"_pandas-stubs").exists():
         Path(r"_pandas-stubs").rename("pandas-stubs")
     else:
-        raise FileNotFoundError("'_pandas-stubs' folder does not exists.")
+        raise FileNotFoundError(  # noqa: TRY003
+            "'_pandas-stubs' folder does not exists."
+        )
 
 
 def nightly_pandas() -> None: