-
Notifications
You must be signed in to change notification settings - Fork 203
Add bokeh 3.8.1 (python). #10228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: IB/CMSSW_16_0_X/py312
Are you sure you want to change the base?
Add bokeh 3.8.1 (python). #10228
Conversation
|
A new Pull Request was created by @bfonta for branch IB/CMSSW_16_0_X/master. @akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
Hi @bfonta we have bokeh version 3.8.0, but ig it's not being built due to it needing Python version 3.10. If I correctly remember. |
|
We also need PyYAML which needs Python to be >3.10 |
|
Pull request #10228 was updated. |
|
@makortel kinded pointed me to the current transition to |
pip/bokeh.file
Outdated
| Requires: py3-PyYAML py3-python-dateutil py3-Jinja2 py3-numpy py3-packaging | ||
| Requires: py3-PyYAML py3-Jinja2 py3-numpy py3-packaging | ||
| Requires: py3-tornado py3-numpy py3-pillow | ||
| Requires: py3-contourpy, py3-pandas, py3-xyzservices, py3-narwhals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bfonta , Requires: should have space separate list of package so please remove the , from the above line.
py3-xyzservices and py3-narwhals are new packages which are not part of our distribution so you need to add these to requirements.txt file along with their xyzservices.file and narwhals.file for proper dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Commas removed.
-
pip showtells me neither has dependencies. Should I nevertheless add "empty" files:
Requires:
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if these new packages do not have any dependency then just adding these in the requirement.txt file is enough e..g
narwhals==2.13.0
xyzservices==2025.11.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Pull request #10228 was updated. |
1 similar comment
|
Pull request #10228 was updated. |
|
please test lets test it for PY3.12 IBs |
|
Pull request #10228 was updated. |
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27b203/49758/summary.html Failed External BuildI found compilation error when building: return self._call_hook(
^^^^^^^^^^^^^^^^
File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/py3-pip/25.1.1-1893b719417e066972579ee5294429fa/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_impl.py", line 402, in _call_hook
raise BackendUnavailable(
pip._vendor.pyproject_hooks._impl.BackendUnavailable: Cannot import 'hatchling.build'
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.wZG0RQ (%build)
RPM build warnings:
Macro expanded in comment on line 413: %{pkginstroot}/bin/*
Macro expanded in comment on line 420: %{pkginstroot}/${PYTHON3_LIB_SITE_PACKAGES}
|
|
@bfonta , though |
|
Pull request #10228 was updated. |
|
please test |
|
Pull request #10228 was updated. |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27b203/49766/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
Adding the data visualization
pythonpackage bokeh. It's particularly useful to build interactive dashboards or event displays.I've updated the dependencies based on what the latest
3.8.1version requires:P.S.: It's not clear why the
bokeh.filealready existed; seems to have been first introduced here aspy2-bokeh.spec.