Skip to content

Conversation

@bfonta
Copy link

@bfonta bfonta commented Dec 1, 2025

Adding the data visualization python package bokeh. It's particularly useful to build interactive dashboards or event displays.
I've updated the dependencies based on what the latest 3.8.1 version requires:

(Bokeh) bfonta@tp16:~  $ pip3 show bokeh
Name: bokeh
Version: 3.8.1
Summary: Interactive plots and applications in the browser from Python
Home-page: https://bokeh.org
...
Requires: contourpy, Jinja2, narwhals, numpy, packaging, pandas, pillow, PyYAML, tornado, xyzservices
Required-by: 

P.S.: It's not clear why the bokeh.file already existed; seems to have been first introduced here as py2-bokeh.spec.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2025

A new Pull Request was created by @bfonta for branch IB/CMSSW_16_0_X/master.

@akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2025

cms-bot internal usage

@akritkbehera
Copy link
Contributor

Hi @bfonta we have bokeh version 3.8.0, but ig it's not being built due to it needing Python version 3.10. If I correctly remember.

@akritkbehera
Copy link
Contributor

We also need PyYAML which needs Python to be >3.10

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2025

Pull request #10228 was updated.

@bfonta
Copy link
Author

bfonta commented Dec 1, 2025

@makortel kinded pointed me to the current transition to python 3.12. Should this PR be merged once the python version is updated?

pip/bokeh.file Outdated
Requires: py3-PyYAML py3-python-dateutil py3-Jinja2 py3-numpy py3-packaging
Requires: py3-PyYAML py3-Jinja2 py3-numpy py3-packaging
Requires: py3-tornado py3-numpy py3-pillow
Requires: py3-contourpy, py3-pandas, py3-xyzservices, py3-narwhals
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bfonta , Requires: should have space separate list of package so please remove the , from the above line.
py3-xyzservices and py3-narwhals are new packages which are not part of our distribution so you need to add these to requirements.txt file along with their xyzservices.file and narwhals.file for proper dependencies.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Commas removed.

  2. pip show tells me neither has dependencies. Should I nevertheless add "empty" files:

Requires:

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if these new packages do not have any dependency then just adding these in the requirement.txt file is enough e..g

narwhals==2.13.0
xyzservices==2025.11.0

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

P.S.:
From the xyz-services docs:

The package does not depend on any other apart from those built-in in Python.

And the narwhals docs also mention no required dependencies are needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2025

Pull request #10228 was updated.

1 similar comment
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2025

Pull request #10228 was updated.

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_16_0_X/master to IB/CMSSW_16_0_X/py312 December 2, 2025 11:46
@smuzaffar
Copy link
Contributor

please test

lets test it for PY3.12 IBs

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2025

Pull request #10228 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2025

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27b203/49758/summary.html
COMMIT: 58d85a7
CMSSW: CMSSW_16_0_PY312_X_2025-12-01-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10228/49758/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed External Build

I found compilation error when building:

return self._call_hook(
^^^^^^^^^^^^^^^^
File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/py3-pip/25.1.1-1893b719417e066972579ee5294429fa/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_impl.py", line 402, in _call_hook
raise BackendUnavailable(
pip._vendor.pyproject_hooks._impl.BackendUnavailable: Cannot import 'hatchling.build'
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.wZG0RQ (%build)

RPM build warnings:
Macro expanded in comment on line 413: %{pkginstroot}/bin/*

Macro expanded in comment on line 420: %{pkginstroot}/${PYTHON3_LIB_SITE_PACKAGES}


@smuzaffar
Copy link
Contributor

@bfonta , though narwhals has no runtime deps but it requires hatchling for building. Can you please add a new file cmsdist/pip/narwhals.file with the following contents

BuildRequires: py3-hatchling

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2025

Pull request #10228 was updated.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2025

Pull request #10228 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27b203/49766/summary.html
COMMIT: 87a9c58
CMSSW: CMSSW_16_0_PY312_X_2025-12-01-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10228/49766/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27b203/49766/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27b203/49766/git-merge-result

Comparison Summary

Summary:

  • You potentially added 210 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1156 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4269233
  • DQMHistoTests: Total failures: 2935
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4266278
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants