Skip to content

Commit 099d99c

Browse files
author
Sunanda
committed
Code check
1 parent 3688ce9 commit 099d99c

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

Geometry/HGCalCommonData/src/HGCalDDDConstants.cc

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1790,7 +1790,8 @@ void HGCalDDDConstants::waferFromPosition(const double x,
17901790
if ((dx - rmax) <= tolc && (dy - hexside) <= tolc) {
17911791
if (((dy - 0.5 * hexside) <= tolc) || ((dx * tan30deg_ - (hexside - dy)) <= tolc)) {
17921792
if (waferHexagon8File()) {
1793-
int index = (zside > 0) ? HGCalWaferIndex::waferIndex(layer, -waferU, waferV) : HGCalWaferIndex::waferIndex(layer, waferU, waferV);
1793+
int index = (zside > 0) ? HGCalWaferIndex::waferIndex(layer, -waferU, waferV)
1794+
: HGCalWaferIndex::waferIndex(layer, waferU, waferV);
17941795
celltype = HGCalWaferType::getType(index, hgpar_->waferInfoMap_);
17951796
if (debug)
17961797
edm::LogVerbatim("HGCalGeom")
@@ -1837,7 +1838,8 @@ void HGCalDDDConstants::waferFromPosition(const double x,
18371838
}
18381839
}
18391840
if (waferHexagon8File()) {
1840-
int index = (zside > 0) ? HGCalWaferIndex::waferIndex(layer, -waferU, waferV) : HGCalWaferIndex::waferIndex(layer, waferU, waferV);
1841+
int index = (zside > 0) ? HGCalWaferIndex::waferIndex(layer, -waferU, waferV)
1842+
: HGCalWaferIndex::waferIndex(layer, waferU, waferV);
18411843
celltype = HGCalWaferType::getType(index, hgpar_->waferInfoMap_);
18421844
if (debug)
18431845
edm::LogVerbatim("HGCalGeom") << "Position (" << x << ", " << y << ") Wafer type:partial:orient:cassette "
@@ -1856,7 +1858,8 @@ void HGCalDDDConstants::waferFromPosition(const double x,
18561858
}
18571859
}
18581860
if (debug)
1859-
edm::LogVerbatim("HGCalGeomX") << "waferFromPosition: waferu " << waferU << ":" << hgpar_->waferUVMax_ << ":" << (std::abs(waferU) <= hgpar_->waferUVMax_) << " celltype " << celltype;
1861+
edm::LogVerbatim("HGCalGeomX") << "waferFromPosition: waferu " << waferU << ":" << hgpar_->waferUVMax_ << ":"
1862+
<< (std::abs(waferU) <= hgpar_->waferUVMax_) << " celltype " << celltype;
18601863
if ((std::abs(waferU) <= hgpar_->waferUVMax_) && (celltype >= 0)) {
18611864
int place(HGCalCell::cellPlacementOld), part(HGCalTypes::WaferFull);
18621865
if (cassetteMode()) {
@@ -1883,8 +1886,10 @@ void HGCalDDDConstants::waferFromPosition(const double x,
18831886
std::ostringstream st1;
18841887
st1 << hgpar_->cellThickness_.size() << " CellThickneses";
18851888
for (unsigned j = 0; j < hgpar_->cellThickness_.size(); ++j)
1886-
st1 << ": " << hgpar_->cellThickness_[j];
1887-
edm::LogVerbatim("HGCalGeomX") << "waferfFromPosition: celltype " << celltype << " Layer " << layer << " Wafer " << waferU << ":" << waferV << " having " << st1.str() << " SimWt " << hgpar_->useSimWt_ << " waferThick "<< hgpar_->waferThick_ << " wt " << wt;
1889+
st1 << ": " << hgpar_->cellThickness_[j];
1890+
edm::LogVerbatim("HGCalGeomX") << "waferfFromPosition: celltype " << celltype << " Layer " << layer << " Wafer "
1891+
<< waferU << ":" << waferV << " having " << st1.str() << " SimWt "
1892+
<< hgpar_->useSimWt_ << " waferThick " << hgpar_->waferThick_ << " wt " << wt;
18881893
}
18891894
} else {
18901895
cellU = cellV = 2 * hgpar_->nCellsFine_;

Geometry/HGCalGeometry/test/HGCalWaferSimWt.cc

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@ class HGCalWaferSimWt : public edm::one::EDAnalyzer<> {
2929
};
3030

3131
HGCalWaferSimWt::HGCalWaferSimWt(const edm::ParameterSet& iC)
32-
: names_(iC.getParameter<std::vector<std::string>>("detectorNames")),
33-
debug_(iC.getParameter<bool>("debug")) {
32+
: names_(iC.getParameter<std::vector<std::string>>("detectorNames")), debug_(iC.getParameter<bool>("debug")) {
3433
for (unsigned int k = 0; k < names_.size(); ++k) {
3534
edm::LogVerbatim("HGCalGeomX") << "Study detector [" << k << "] " << names_[k] << std::endl;
3635
geomTokens_.emplace_back(esConsumes<HGCalGeometry, IdealGeometryRecord>(edm::ESInputTag{"", names_[k]}));
@@ -73,8 +72,8 @@ void HGCalWaferSimWt::analyze(const edm::Event& /*iEvent*/, const edm::EventSetu
7372
double ypos = 10.0 * (cell.y());
7473
int waferU, waferV, cellU, cellV, cellType;
7574
double wt;
76-
if (debug_)
77-
edm::LogVerbatim("HGCalGeomX") << hid << " at (" << xpos << ", " << ypos << ")";
75+
if (debug_)
76+
edm::LogVerbatim("HGCalGeomX") << hid << " at (" << xpos << ", " << ypos << ")";
7877
geom->topology().dddConstants().waferFromPosition(
7978
xpos, ypos, hid.zside(), hid.layer(), waferU, waferV, cellU, cellV, cellType, wt, false, true);
8079
std::string stype = (type >= 0 && type <= 3) ? detType[type] : ("JK" + std::to_string(type));

0 commit comments

Comments
 (0)