Skip to content

Commit 0fd66fe

Browse files
authored
Merge pull request #47974 from JHiltbrand/hbTPalgoPhase2hardcode_151X
Adjust "hard-coded" HcalTPChannelParameters for HB TP Algorithm in Phase 2
2 parents 5b035c6 + 5279a7f commit 0fd66fe

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

CalibCalorimetry/HcalAlgos/src/HcalDbHardcode.cc

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -756,10 +756,18 @@ HcalTPChannelParameter HcalDbHardcode::makeHardcodeTPChannelParameter(HcalGeneri
756756
// mask for channel validity and self trigger information, fine grain
757757
// bit information and auxiliary words
758758
uint32_t bitInfo = ((44 << 16) | 30);
759+
int auxi1 = 0;
759760
int auxi2 = 0;
760761
if (fId.genericSubdet() == HcalGenericDetId::HcalGenZDC)
761762
auxi2 = 50; // ZDC bunch spacing parameter
762-
return HcalTPChannelParameter(fId.rawId(), 0, bitInfo, 0, auxi2);
763+
764+
// Hard code Run 3 TP algorithm for HB (OOT PU subtraction, prefire veto)
765+
else if (fId.subdetId() == HcalTriggerTower) {
766+
auxi1 = 120; // OOT PU subtraction presample weighting factor (fixed-point 8-bit) (w ~ 0.47)
767+
auxi2 = 0; // For now, leave prefire veto off
768+
}
769+
770+
return HcalTPChannelParameter(fId.rawId(), 0, bitInfo, auxi1, auxi2);
763771
}
764772

765773
void HcalDbHardcode::makeHardcodeTPParameters(HcalTPParameters& tppar) const {

CalibCalorimetry/HcalPlugins/src/HcalHardcodeCalibrations.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1022,10 +1022,6 @@ std::unique_ptr<HcalTPChannelParameters> HcalHardcodeCalibrations::produceTPChan
10221022
auto result = std::make_unique<HcalTPChannelParameters>(&topo);
10231023
const std::vector<HcalGenericDetId>& cells = allCells(topo, zdcTopo, dbHardcode.killHE());
10241024
for (auto cell : cells) {
1025-
// Thinking about Phase2 and the new FIR filter,
1026-
// for now, don't put TT in TPChannelParams
1027-
if (cell.subdetId() == HcalTriggerTower)
1028-
continue;
10291025
HcalTPChannelParameter item = dbHardcode.makeHardcodeTPChannelParameter(cell);
10301026
result->addValues(item);
10311027
}

0 commit comments

Comments
 (0)