Merge pull request #47189 from mmusich/mm_dev_protectBetaFunctAgainstGausParams

throw in presence of mismatched `SimBeamSpot` types in `BetafuncEvtVtxGenerator` and `GaussEvtVtxGenerator`

Author: cmsbuild

CondFormats/BeamSpotObjects/interface/SimBeamSpotObjects.h

@@ -87,16 +87,23 @@ class SimBeamSpotObjects {
   double alpha() const { return fAlpha; }
   double timeOffset() const { return fTimeOffset; }
 
+  /// Method to check if the object corresponds to GaussEvtVtxGenerator parameters
+  bool isGaussian() const {
+    // Check for the presence of GaussEvtVtxGenerator-specific parameters
+    return ((fMeanX != 0.0 || fMeanY != 0.0 || fMeanZ != 0.0) ||  // either centroid is not 0,0,0
+            (fSigmaX != -1.0 && fSigmaY != -1.0));                // or the withs are not defaults
+  }
+
   /// print sim beam spot parameters
   void print(std::stringstream& ss) const;
 
 private:
-  double fX0, fY0, fZ0;
-  double fMeanX, fMeanY, fMeanZ;
-  double fSigmaX, fSigmaY, fSigmaZ;
-  double fbetastar, femittance;
-  double fPhi, fAlpha;
-  double fTimeOffset;
+  double fX0, fY0, fZ0;              // for beta-function
+  double fMeanX, fMeanY, fMeanZ;     // for gaussian
+  double fSigmaX, fSigmaY, fSigmaZ;  // for gaussian
+  double fbetastar, femittance;      // for beta-function
+  double fPhi, fAlpha;               // for beta-function
+  double fTimeOffset;                // for both
 
   COND_SERIALIZABLE;
 };

IOMC/EventVertexGenerators/src/BetafuncEvtVtxGenerator.cc

@@ -60,14 +60,21 @@ void BetafuncEvtVtxGenerator::beginLuminosityBlock(edm::LuminosityBlock const&,
 void BetafuncEvtVtxGenerator::update(const edm::EventSetup& iEventSetup) {
   if (readDB_ && parameterWatcher_.check(iEventSetup)) {
     edm::ESHandle<SimBeamSpotObjects> beamhandle = iEventSetup.getHandle(beamToken_);
-    fX0 = beamhandle->x() * cm;
-    fY0 = beamhandle->y() * cm;
-    fZ0 = beamhandle->z() * cm;
-    fSigmaZ = beamhandle->sigmaZ() * cm;
-    fTimeOffset = beamhandle->timeOffset() * ns * c_light;  // HepMC distance units are in mm
-    fbetastar = beamhandle->betaStar() * cm;
-    femittance = beamhandle->emittance() * cm;
-    setBoost(beamhandle->alpha() * radian, beamhandle->phi() * radian);
+    if (!beamhandle->isGaussian()) {
+      fX0 = beamhandle->x() * cm;
+      fY0 = beamhandle->y() * cm;
+      fZ0 = beamhandle->z() * cm;
+      fSigmaZ = beamhandle->sigmaZ() * cm;
+      fTimeOffset = beamhandle->timeOffset() * ns * c_light;  // HepMC distance units are in mm
+      fbetastar = beamhandle->betaStar() * cm;
+      femittance = beamhandle->emittance() * cm;
+      setBoost(beamhandle->alpha() * radian, beamhandle->phi() * radian);
+    } else {
+      throw cms::Exception("Configuration")
+          << "Error in BetafuncEvtVtxGenerator::update: The provided SimBeamSpotObjects is Gaussian.\n"
+          << "Please check the configuration and ensure that the beam spot parameters are appropriate for a Betafunc "
+             "distribution.";
+    }
   }
 }
 

IOMC/EventVertexGenerators/src/GaussEvtVtxGenerator.cc

@@ -47,13 +47,20 @@ void GaussEvtVtxGenerator::beginLuminosityBlock(edm::LuminosityBlock const&, edm
 void GaussEvtVtxGenerator::update(const edm::EventSetup& iEventSetup) {
   if (readDB_ && parameterWatcher_.check(iEventSetup)) {
     edm::ESHandle<SimBeamSpotObjects> beamhandle = iEventSetup.getHandle(beamToken_);
-    fMeanX = beamhandle->meanX() * cm;
-    fMeanY = beamhandle->meanY() * cm;
-    fMeanZ = beamhandle->meanZ() * cm;
-    fSigmaX = beamhandle->sigmaX() * cm;
-    fSigmaY = beamhandle->sigmaY() * cm;
-    fSigmaZ = beamhandle->sigmaZ() * cm;
-    fTimeOffset = beamhandle->timeOffset() * ns * c_light;  // HepMC distance units are in mm
+    if (beamhandle->isGaussian()) {
+      fMeanX = beamhandle->meanX() * cm;
+      fMeanY = beamhandle->meanY() * cm;
+      fMeanZ = beamhandle->meanZ() * cm;
+      fSigmaX = beamhandle->sigmaX() * cm;
+      fSigmaY = beamhandle->sigmaY() * cm;
+      fSigmaZ = beamhandle->sigmaZ() * cm;
+      fTimeOffset = beamhandle->timeOffset() * ns * c_light;  // HepMC distance units are in mm
+    } else {
+      throw cms::Exception("Configuration")
+          << "Error in GaussEvtVtxGenerator::update: The provided SimBeamSpotObjects is not Gaussian.\n"
+          << "Please check the configuration and ensure that the beam spot parameters are appropriate for a Gaussian "
+             "distribution.";
+    }
   }
 }