Merge pull request #48127 from smuzaffar/ubsan-gcc14-MuonResidualsFromTrack

[UBSAN][GCC14]move large constructor code in to private member function

Author: cmsbuild

Alignment/MuonAlignmentAlgorithms/interface/MuonResidualsFromTrack.h

@@ -95,6 +95,18 @@ class MuonResidualsFromTrack {
   TMatrixD choleskyCorrMatrix(DetId chamberId);
 
 private:
+  //Due to large constructor code, UBSAN with GCC14 hangs and never returns
+  //Moving large constructor code to a private function fixes this issue
+  void init(edm::ESHandle<TransientTrackingRecHitBuilder> builder,
+            edm::ESHandle<MagneticField> magneticField,
+            edm::ESHandle<GlobalTrackingGeometry> globalGeometry,
+            edm::ESHandle<DetIdAssociator> muonDetIdAssociator_,
+            edm::ESHandle<Propagator> prop,
+            const Trajectory *traj,
+            const reco::Track *recoTrack,
+            AlignableNavigator *navigator,
+            double maxResidual);
+
   TrajectoryStateCombiner m_tsoscomb;
 
   int m_tracker_numHits;

Alignment/MuonAlignmentAlgorithms/src/MuonResidualsFromTrack.cc

@@ -31,6 +31,26 @@ MuonResidualsFromTrack::MuonResidualsFromTrack(edm::ESHandle<TransientTrackingRe
                                                AlignableNavigator* navigator,
                                                double maxResidual)
     : m_recoTrack(recoTrack) {
+  init(trackerRecHitBuilder,
+       magneticField,
+       globalGeometry,
+       muonDetIdAssociator_,
+       prop,
+       traj,
+       recoTrack,
+       navigator,
+       maxResidual);
+}
+
+void MuonResidualsFromTrack::init(edm::ESHandle<TransientTrackingRecHitBuilder> trackerRecHitBuilder,
+                                  edm::ESHandle<MagneticField> magneticField,
+                                  edm::ESHandle<GlobalTrackingGeometry> globalGeometry,
+                                  edm::ESHandle<DetIdAssociator> muonDetIdAssociator_,
+                                  edm::ESHandle<Propagator> prop,
+                                  const Trajectory* traj,
+                                  const reco::Track* recoTrack,
+                                  AlignableNavigator* navigator,
+                                  double maxResidual) {
   bool m_debug = false;
 
   if (m_debug) {