use named constants for the special hit indices

Author: slava77devel

RecoTracker/MkFitCore/interface/Track.h

@@ -437,7 +437,7 @@ namespace mkfit {
     void addHitIdx(int hitIdx, int hitLyr, float chi2) {
       hitsOnTrk_.push_back({hitIdx, hitLyr});
       ++lastHitIdx_;
-      if (hitIdx >= 0 || hitIdx == -9) {
+      if (hitIdx >= 0 || hitIdx == Hit::kHitCCCFilterIdx) {
         ++nFoundHits_;
         chi2_ += chi2;
       }
@@ -503,7 +503,7 @@ namespace mkfit {
     void countAndSetNFoundHits() {
       nFoundHits_ = 0;
       for (int i = 0; i <= lastHitIdx_; i++) {
-        if (hitsOnTrk_[i].index >= 0 || hitsOnTrk_[i].index == -9)
+        if (hitsOnTrk_[i].index >= 0 || hitsOnTrk_[i].index == Hit::kHitCCCFilterIdx)
           nFoundHits_++;
       }
     }
@@ -553,7 +553,7 @@ namespace mkfit {
         const auto& hot = tmp_hitsOnTrk[ihit];
         const auto lyr = hot.layer;
         const auto idx = hot.index;
-        if (lyr >= 0 && (idx >= 0 || idx == -9) && lyr != prev_lyr) {
+        if (lyr >= 0 && (idx >= 0 || idx == Hit::kHitCCCFilterIdx) && lyr != prev_lyr) {
           ++lyr_cnt;
           prev_lyr = lyr;
         }
@@ -568,7 +568,7 @@ namespace mkfit {
     std::vector<int> foundLayers() const {
       std::vector<int> layers;
       for (int ihit = 0; ihit <= lastHitIdx_; ++ihit) {
-        if (hitsOnTrk_[ihit].index >= 0 || hitsOnTrk_[ihit].index == -9) {
+        if (hitsOnTrk_[ihit].index >= 0 || hitsOnTrk_[ihit].index == Hit::kHitCCCFilterIdx) {
           layers.push_back(hitsOnTrk_[ihit].layer);
         }
       }

RecoTracker/MkFitCore/standalone/index-desc.txt

@@ -17,17 +17,17 @@ Hit indices attached to HitOnTrack array for each track are described below.
 
 Idx >= 0  : Track contains a reconstructed hit. Idx indicates position within container where hit resides. Before building in mkFit, idx (with layer number) points to the position within Event::layerHits_ [vector of vector of hits, first index: layer, second index: hit idx]. Just prior to building, hit idxs are translated into their position within layerHits_ to EventOfHits::m_layers_of_hits [vector of LayerOfHits, first index is layer, LayerOfHits class for containing array of Hits]. Building uses layers_of_hits, then for validation, the hits are translated back to layerHits_.
 
-Idx == -1 : Track has not found a hit on this layer (true miss).
+Idx == -1 = kHitMissIdx      : Track has not found a hit on this layer (true miss).
 
-Idx == -2 : Track has reached maximum number of holes/misses (-1).
+Idx == -2 = kHitStopIdx      : Track has reached maximum number of holes/misses (-1).
 
-Idx == -3 : Track not in sensitive region of detector, does not count towards efficiency.
+Idx == -3 = kHitEdgeIdx      : Track not in sensitive region of detector, does not count towards efficiency.
 
-Idx == -5 : Dummy hit to mark hits with cluster size > maxClusterSize
+Idx == -5 = kHitMaxClusterIdx: Dummy hit to mark hits with cluster size > maxClusterSize
 
-Idx == -7 : Dummy hit to mark the location of an inactive module
+Idx == -7 = kHitInGapIdx     : Dummy hit to mark the location of an inactive module
 
-Idx == -9 : Reference track contained a hit that has since been filtered out via CCC before written to memory file. -9 hits are NOT stored in layerHits_.
+Idx == -9 = kHitCCCFilterIdx : Reference track contained a hit that has since been filtered out via CCC before written to memory file. -9 hits are NOT stored in layerHits_.
 
 
 --------------------