Merge pull request #45732 from iarspider/iarspider-patch-20240817-5

[GCC13] Avoid Wdangling-reference warning in CalibTracker submodules

Author: cmsbuild

CalibTracker/SiStripCommon/plugins/TkDetMapESProducer.cc

@@ -294,7 +294,8 @@ namespace {
 }  // namespace
 
 std::unique_ptr<TkDetMap> TkDetMapESProducer::produce(const TrackerTopologyRcd& tTopoRcd) {
-  const auto& geomDet = tTopoRcd.getRecord<IdealGeometryRecord>().get(geomDetToken_);
+  const auto& geomDetRcd = tTopoRcd.getRecord<IdealGeometryRecord>();
+  const auto& geomDet = geomDetRcd.get(geomDetToken_);
   const auto TkDetIdList = TrackerGeometryUtils::getSiStripDetIds(geomDet);
 
   const auto& tTopo = tTopoRcd.get(tTopoToken_);

CalibTracker/SiStripESProducers/plugins/fake/SiStripBackPlaneCorrectionFakeESSource.cc

@@ -65,7 +65,8 @@ SiStripBackPlaneCorrectionFakeESSource::ReturnType SiStripBackPlaneCorrectionFak
     const SiStripBackPlaneCorrectionRcd& iRecord) {
   using namespace edm::es;
 
-  const auto& geomDet = iRecord.getRecord<TrackerTopologyRcd>().get(m_geomDetToken);
+  const auto& geomDetRcd = iRecord.getRecord<TrackerTopologyRcd>();
+  const auto& geomDet = geomDetRcd.get(m_geomDetToken);
   const auto& tTopo = iRecord.get(m_tTopoToken);
 
   auto backPlaneCorrection = std::make_unique<SiStripBackPlaneCorrection>();

CalibTracker/SiStripESProducers/plugins/fake/SiStripHashedDetIdFakeESSource.cc

@@ -31,7 +31,8 @@ std::unique_ptr<SiStripHashedDetId> SiStripHashedDetIdFakeESSource::produce(cons
   edm::LogVerbatim("HashedDetId") << "[SiStripHashedDetIdFakeESSource::" << __func__ << "]"
                                   << " Building \"fake\" hashed DetId map from IdealGeometry";
 
-  const auto& geomDet = record.getRecord<TrackerDigiGeometryRecord>().get(geomDetToken_);
+  const auto& geomDetRcd = record.getRecord<TrackerDigiGeometryRecord>();
+  const auto& geomDet = geomDetRcd.get(geomDetToken_);
 
   const std::vector<uint32_t> dets = TrackerGeometryUtils::getSiStripDetIds(geomDet);
   edm::LogVerbatim("HashedDetId") << "[SiStripHashedDetIdFakeESSource::" << __func__ << "]"

CalibTracker/SiStripESProducers/plugins/fake/SiStripLorentzAngleFakeESSource.cc

@@ -183,7 +183,8 @@ SiStripLorentzAngleFakeESSource::ReturnType SiStripLorentzAngleFakeESSource::pro
     const SiStripLorentzAngleRcd& iRecord) {
   using namespace edm::es;
 
-  const auto& geomDet = iRecord.getRecord<TrackerTopologyRcd>().get(m_geomDetToken);
+  const auto& geomDetRcd = iRecord.getRecord<TrackerTopologyRcd>();
+  const auto& geomDet = geomDetRcd.get(m_geomDetToken);
   const auto& tTopo = iRecord.get(m_tTopoToken);
 
   auto lorentzAngle = std::make_unique<SiStripLorentzAngle>();

CalibTracker/SiStripQuality/plugins/SiStripQualityHotStripIdentifier.cc

@@ -167,7 +167,8 @@ void SiStripQualityHotStripIdentifier::resetHistos() {
 void SiStripQualityHotStripIdentifier::bookHistos() {
   edm::LogInfo("SiStripQualityHotStripIdentifier") << " [SiStripQualityHotStripIdentifier::bookHistos] " << std::endl;
   char hname[1024];
-  for (const auto& it : SiStripDetInfoFileReader::read(fp_.fullPath()).getAllData()) {
+  const SiStripDetInfo& info = SiStripDetInfoFileReader::read(fp_.fullPath());
+  for (const auto& it : info.getAllData()) {
     sprintf(hname, "h_%d", it.first);
     auto ref = ClusterPositionHistoMap.find(it.first);
     if (ref == ClusterPositionHistoMap.end()) {