Skip to content

Commit 1f91374

Browse files
committed
Make RunLumiEventAnalyzer to accept only vector<unsigned long long> for expectedRunLumisEvents
1 parent 4263a32 commit 1f91374

File tree

1 file changed

+7
-23
lines changed

1 file changed

+7
-23
lines changed

FWCore/Framework/test/stubs/RunLumiEventAnalyzer.cc

Lines changed: 7 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#include "FWCore/ParameterSet/interface/ParameterSet.h"
1010
#include "FWCore/Utilities/interface/EDGetToken.h"
1111
#include "FWCore/Utilities/interface/Exception.h"
12-
#include "FWCore/Utilities/interface/propagate_const.h"
1312

1413
#include <cassert>
1514
#include <vector>
@@ -29,9 +28,9 @@ namespace edmtest {
2928
void endJob();
3029

3130
private:
32-
std::vector<unsigned long long> expectedRunLumisEvents0_;
33-
std::vector<unsigned long long> expectedRunLumisEvents1_;
34-
edm::propagate_const<std::vector<unsigned long long>*> const expectedRunLumisEvents_;
31+
std::vector<unsigned long long> const expectedRunLumisEvents0_;
32+
std::vector<unsigned long long> const expectedRunLumisEvents1_;
33+
std::vector<unsigned long long> const* const expectedRunLumisEvents_;
3534
bool const verbose_;
3635
bool const dumpTriggerResults_;
3736
int const expectedEndingIndex0_;
@@ -42,27 +41,14 @@ namespace edmtest {
4241
};
4342

4443
RunLumiEventAnalyzer::RunLumiEventAnalyzer(edm::ParameterSet const& pset)
45-
: expectedRunLumisEvents0_(),
46-
expectedRunLumisEvents1_(),
44+
: expectedRunLumisEvents0_(pset.getUntrackedParameter<std::vector<unsigned long long>>("expectedRunLumiEvents")),
45+
expectedRunLumisEvents1_(pset.getUntrackedParameter<std::vector<unsigned long long>>("expectedRunLumiEvents1")),
4746
expectedRunLumisEvents_(&expectedRunLumisEvents0_),
4847
verbose_(pset.getUntrackedParameter<bool>("verbose")),
4948
dumpTriggerResults_(pset.getUntrackedParameter<bool>("dumpTriggerResults")),
5049
expectedEndingIndex0_(pset.getUntrackedParameter<int>("expectedEndingIndex")),
5150
expectedEndingIndex1_(pset.getUntrackedParameter<int>("expectedEndingIndex1")),
5251
expectedEndingIndex_(expectedEndingIndex0_) {
53-
if (pset.existsAs<std::vector<unsigned int>>("expectedRunLumiEvents", false)) {
54-
std::vector<unsigned int> temp = pset.getUntrackedParameter<std::vector<unsigned int>>("expectedRunLumiEvents");
55-
expectedRunLumisEvents0_.assign(temp.begin(), temp.end());
56-
} else {
57-
expectedRunLumisEvents0_ = pset.getUntrackedParameter<std::vector<unsigned long long>>("expectedRunLumiEvents");
58-
}
59-
60-
if (pset.existsAs<std::vector<unsigned int>>("expectedRunLumiEvents1", false)) {
61-
std::vector<unsigned int> temp = pset.getUntrackedParameter<std::vector<unsigned int>>("expectedRunLumiEvents1");
62-
expectedRunLumisEvents1_.assign(temp.begin(), temp.end());
63-
} else {
64-
expectedRunLumisEvents1_ = pset.getUntrackedParameter<std::vector<unsigned long long>>("expectedRunLumiEvents1");
65-
}
6652
if (dumpTriggerResults_) {
6753
triggerResultsToken_ = consumes(edm::InputTag("TriggerResults"));
6854
}
@@ -74,10 +60,8 @@ namespace edmtest {
7460
desc.addUntracked<bool>("dumpTriggerResults", false);
7561
desc.addUntracked<int>("expectedEndingIndex", -1);
7662
desc.addUntracked<int>("expectedEndingIndex1", -1);
77-
desc.addNode(edm::ParameterDescription<std::vector<unsigned long long>>("expectedRunLumiEvents", {}, false) xor
78-
edm::ParameterDescription<std::vector<unsigned int>>("expectedRunLumiEvents", {}, false));
79-
desc.addNode(edm::ParameterDescription<std::vector<unsigned long long>>("expectedRunLumiEvents1", {}, false) xor
80-
edm::ParameterDescription<std::vector<unsigned int>>("expectedRunLumiEvents1", {}, false));
63+
desc.addUntracked<std::vector<unsigned long long>>("expectedRunLumiEvents", {});
64+
desc.addUntracked<std::vector<unsigned long long>>("expectedRunLumiEvents1", {});
8165

8266
descriptions.addDefault(desc);
8367
}

0 commit comments

Comments
 (0)