Updated comments based on PR feedback

Author: Dr15Jones

DataFormats/Provenance/test/productResolverIndexHelper_t.cpp

@@ -1,6 +1,3 @@
-/*
- *  productResolverIndexHelper_t.cppunit.cc
- */
 #define CATCH_CONFIG_MAIN
 #include <catch.hpp>
 
@@ -73,7 +70,7 @@ TEST_CASE("ProductResolverIndexHelper", "[ProductResolverIndexHelper]") {
     REQUIRE(indexWithProcess < 2);
     REQUIRE(indexEmptyProcess != indexWithProcess);
 
-    //wit only one entry, all should resolve to the one with process name
+    //with only one entry, all should resolve to the one with process name
     REQUIRE(helper.index(PRODUCT_TYPE, typeID_ProductID, "labelA", "instanceA") == indexWithProcess);
     REQUIRE(helper.index(PRODUCT_TYPE, typeID_ProductID, "labelA", "instanceA", "") == indexWithProcess);
     REQUIRE(helper.index(PRODUCT_TYPE, typeID_ProductID, "labelA", "instanceA", 0) == indexWithProcess);

FWCore/Framework/src/ProductResolvers.cc

@@ -1069,7 +1069,6 @@ namespace edm {
     return false;
   }
 
-  //CDJ this is the function to change
   void NoProcessProductResolver::tryPrefetchResolverAsync(unsigned int iProcessingIndex,
                                                           Principal const& principal,
                                                           bool skipCurrentProcess,
@@ -1194,6 +1193,8 @@ namespace edm {
       bool skipCurrentProcess,
       SharedResourcesAcquirer* sra,
       ModuleCallingContext const* mcc) const {
+    //In future changes this class will be removed. Although the class is still being instantiated, it should never be called.
+    // For now the assert is here to catch any missed cases.
     assert(false);
     //NOTE: Have to lookup the other ProductResolver each time rather than cache
     // it's pointer since it appears the pointer can change at some later stage
@@ -1207,6 +1208,8 @@ namespace edm {
                                                             ServiceToken const& token,
                                                             SharedResourcesAcquirer* sra,
                                                             ModuleCallingContext const* mcc) const noexcept {
+    //In future changes this class will be removed. Although the class is still being instantiated, it should never be called.
+    // For now the assert is here to catch any missed cases.
     assert(false);
     principal.getProductResolverByIndex(realResolverIndex_)
         ->prefetchAsync(waitTask, principal, skipCurrentProcess, token, sra, mcc);