fix c++20 compilation errors

Author: Dan Riley

L1Trigger/TrackFindingTracklet/src/TrackletLUT.cc

@@ -901,6 +901,7 @@ void TrackletLUT::initProjectionDiskRadius(int nrbits) {
 void TrackletLUT::initBendMatch(unsigned int layerdisk) {
   unsigned int nrinv = NRINVBITS;
   double rinvhalf = 0.5 * ((1 << nrinv) - 1);
+  assert(layerdisk < 16); // should be a named constant for this
 
   bool barrel = layerdisk < N_LAYER;
 

L1Trigger/TrackFindingTracklet/test/AnalyzerDR.cc

@@ -200,8 +200,8 @@ namespace trklet {
         vector<vector<TTStubRef>> lost;
         formTracks(lostTracks, lostStubs, lost, offset + channel);
         nTracks += tracks.size();
-        nStubs += accumulate(tracks.begin(), tracks.end(), 0, [](int sum, const vector<TTStubRef>& track) {
-          return sum + static_cast<int>(track.size());
+        nStubs += accumulate(tracks.begin(), tracks.end(), 0UL, [](auto sum, const vector<TTStubRef>& track) {
+          return sum + track.size();
         });
         nLost += lost.size();
         allTracks += tracks.size();

L1Trigger/TrackFindingTracklet/test/AnalyzerDRin.cc

@@ -201,8 +201,8 @@ namespace trklet {
         vector<vector<TTStubRef>> lost;
         formTracks(lostTracks, lostStubs, lost, offset + channel);
         nTracks += tracks.size();
-        nStubs += accumulate(tracks.begin(), tracks.end(), 0, [](int sum, const vector<TTStubRef>& track) {
-          return sum + (int)track.size();
+        nStubs += accumulate(tracks.begin(), tracks.end(), 0UL, [](auto sum, const vector<TTStubRef>& track) {
+          return sum + track.size();
         });
         nLost += lost.size();
         allTracks += tracks.size();

L1Trigger/TrackFindingTracklet/test/AnalyzerKFin.cc

@@ -192,8 +192,8 @@ namespace trklet {
         vector<vector<TTStubRef>> lost;
         formTracks(lostTracks, lostStubs, lost, offset + channel);
         nTracks += tracks.size();
-        nStubs += accumulate(tracks.begin(), tracks.end(), 0, [](int sum, const vector<TTStubRef>& track) {
-          return sum + (int)track.size();
+        nStubs += accumulate(tracks.begin(), tracks.end(), 0UL, [](auto sum, const vector<TTStubRef>& track) {
+          return sum + track.size();
         });
         nLost += lost.size();
         allTracks += tracks.size();

L1Trigger/TrackFindingTracklet/test/AnalyzerKFout.cc

@@ -166,8 +166,8 @@ namespace trklet {
           if (frame.first.isNonnull())
             tracks.insert(frame.first);
         nTracksRegion += tracks.size();
-        nStubsRegion += accumulate(tracks.begin(), tracks.end(), 0, [](int sum, const TTTrackRef& ttTrackRef) {
-          return sum + (int)ttTrackRef->getStubRefs().size();
+        nStubsRegion += accumulate(tracks.begin(), tracks.end(), 0UL, [](auto sum, const TTTrackRef& ttTrackRef) {
+          return sum + ttTrackRef->getStubRefs().size();
         });
         set<TTTrackRef> tracksLost;
         for (const FrameTrack& frame : lost)