Skip to content

Commit 29ab9c8

Browse files
authored
Merge pull request #45660 from perrotta/removeDeadCodeFineDelayTask
Remove a dead assignment in DQM/SiStripCommissioningSources/src/FineDelayTask.cc
2 parents ba85f34 + c178c43 commit 29ab9c8

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

DQM/SiStripCommissioningSources/src/FineDelayTask.cc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,20 +87,20 @@ void FineDelayTask::fill(const SiStripEventSummary& summary, const edm::DetSet<S
8787
latencyShift -= 64; // allow negative values: we cover [-32,32].. should not be needed.
8888
if ((latencyCode >> 6) == 2)
8989
latencyShift -= 3; // layer in deconv, rest in peak
90-
if ((latencyCode >> 6) == 1)
90+
else if ((latencyCode >> 6) == 1)
9191
latencyShift += 3; // layer in peak, rest in deconv
92-
float correctedDelay =
92+
float correctedDelayBase =
9393
delay - (latencyShift * 25.); // shifts the delay so that 0 corresponds to the current settings.
9494

9595
LogDebug("Commissioning") << "[FineDelayTask::fill]; the delay is " << delay;
9696
// loop on the strips to find the (maybe) non-zero digi
9797
for (unsigned int strip = 0; strip < digis.data.size(); strip++) {
9898
if (digis.data[strip].adc() != 0) {
99-
// apply the TOF correction
100-
float tof = (digis.data[strip].adc() >> 8) / 10.;
101-
correctedDelay = delay - (latencyShift * 25.) - tof;
10299
if ((digis.data[strip].adc() >> 8) == 255)
103100
continue; // skip hit if TOF is in overflow
101+
// apply the TOF correction
102+
float tof = (digis.data[strip].adc() >> 8) / 10.;
103+
float correctedDelay = correctedDelayBase - tof;
104104
// compute the bin
105105
float nbins = NBINS;
106106
float lowbin = LOWBIN;

0 commit comments

Comments
 (0)