apply result of code checks

Author: Dr15Jones

DataFormats/Provenance/src/ProductRegistry.cc

@@ -332,7 +332,7 @@ namespace edm {
     std::vector<std::string> producedTypes;
 
     transient_.branchIDToIndex_.clear();
-    assert(productList_.empty() or processOrder().size() > 0);
+    assert(productList_.empty() or !processOrder().empty());
 
     std::array<std::shared_ptr<ProductResolverIndexHelper>, NumBranchTypes> new_productLookups{
         {std::make_shared<ProductResolverIndexHelper>(),

FWCore/Framework/src/DroppedDataProductResolver.h

@@ -13,7 +13,7 @@ namespace edm {
   class DroppedDataProductResolver : public ProductResolverBase {
   public:
     DroppedDataProductResolver(std::shared_ptr<ProductDescription const> bd)
-        : ProductResolverBase(), m_provenance(std::move(bd), {}) {}
+        : ProductResolverBase(), m_provenance(bd, {}) {}
 
     void connectTo(ProductResolverBase const&, Principal const*) final {}