Skip to content

Commit 2de4944

Browse files
authored
Merge pull request #48800 from bsunanda/Phase2-hgx364A
Phase2-hgx364A Changes made to resolve an issue in making tests for overlap checks
2 parents 1db657f + f167311 commit 2de4944

File tree

4 files changed

+28
-25
lines changed

4 files changed

+28
-25
lines changed

SimG4Core/Application/python/g4SimHits_cfi.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@
118118
Depth = cms.int32(3), # -1 means check whatever depth
119119
PVname = cms.string(''),
120120
LVname = cms.string(''),
121+
NodeName = cms.string(''),
121122
NodeNames = cms.vstring('World')
122123
),
123124
G4Commands = cms.vstring(),

SimG4Core/PrintGeomInfo/test/python/g4OverlapCheckBigXML_cfg.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,17 +38,18 @@
3838
process.g4SimHits.CheckGeometry = True
3939

4040
# Geant4 geometry check
41-
process.g4SimHits.G4CheckOverlap.OutputBaseName = cms.string("cmsBigXMLddd2021")
42-
process.g4SimHits.G4CheckOverlap.OverlapFlag = cms.bool(True)
43-
process.g4SimHits.G4CheckOverlap.Tolerance = cms.double(options.tol)
44-
process.g4SimHits.G4CheckOverlap.Resolution = cms.int32(10000)
45-
process.g4SimHits.G4CheckOverlap.Depth = cms.int32(-1)
41+
process.g4SimHits.G4CheckOverlap.NodeName = ""
42+
process.g4SimHits.G4CheckOverlap.OutputBaseName = "cmsBigXMLddd2021"
43+
process.g4SimHits.G4CheckOverlap.OverlapFlag = True
44+
process.g4SimHits.G4CheckOverlap.Tolerance = options.tol
45+
process.g4SimHits.G4CheckOverlap.Resolution = 10000
46+
process.g4SimHits.G4CheckOverlap.Depth = -1
4647
# tells if NodeName is G4Region or G4PhysicalVolume
47-
process.g4SimHits.G4CheckOverlap.RegionFlag = cms.bool(False)
48+
process.g4SimHits.G4CheckOverlap.RegionFlag = False
4849
# list of names
49-
process.g4SimHits.G4CheckOverlap.NodeNames = cms.vstring('OCMS')
50+
process.g4SimHits.G4CheckOverlap.NodeNames = ['OCMS']
5051
# enable dump gdml file
51-
process.g4SimHits.G4CheckOverlap.gdmlFlag = cms.bool(False)
52+
process.g4SimHits.G4CheckOverlap.gdmlFlag = False
5253
# if defined a G4PhysicsVolume info is printed
5354
process.g4SimHits.G4CheckOverlap.PVname = ''
5455
# if defined a list of daughter volumes is printed

SimG4Core/PrintGeomInfo/test/python/g4OverlapCheckDD4hep_cfg.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -56,18 +56,18 @@
5656
process.g4SimHits.CheckGeometry = True
5757

5858
# Geant4 geometry check
59-
process.g4SimHits.G4CheckOverlap.OutputBaseName = cms.string(baseName)
60-
process.g4SimHits.G4CheckOverlap.OverlapFlag = cms.bool(True)
61-
process.g4SimHits.G4CheckOverlap.Tolerance = cms.double(options.tol)
62-
process.g4SimHits.G4CheckOverlap.Resolution = cms.int32(10000)
63-
process.g4SimHits.G4CheckOverlap.Depth = cms.int32(-1)
59+
process.g4SimHits.G4CheckOverlap.NodeName = ""
60+
process.g4SimHits.G4CheckOverlap.OutputBaseName = baseName
61+
process.g4SimHits.G4CheckOverlap.OverlapFlag = True
62+
process.g4SimHits.G4CheckOverlap.Tolerance = options.tol
63+
process.g4SimHits.G4CheckOverlap.Resolution = 10000
64+
process.g4SimHits.G4CheckOverlap.Depth = -1
6465
# tells if NodeName is G4Region or G4PhysicalVolume
65-
process.g4SimHits.G4CheckOverlap.RegionFlag = cms.bool(False)
66+
process.g4SimHits.G4CheckOverlap.RegionFlag = False
6667
# list of names
67-
process.g4SimHits.G4CheckOverlap.NodeNames = cms.vstring('cms:OCMS_1')
68-
# process.g4SimHits.G4CheckOverlap.NodeNames = cms.vstring('DefaultRegionForTheWorld')
68+
process.g4SimHits.G4CheckOverlap.NodeNames = ['cms:OCMS_1']
6969
# enable dump gdml file
70-
process.g4SimHits.G4CheckOverlap.gdmlFlag = cms.bool(False)
70+
process.g4SimHits.G4CheckOverlap.gdmlFlag = False
7171
# if defined a G4PhysicsVolume info is printed
7272
process.g4SimHits.G4CheckOverlap.PVname = ''
7373
# if defined a list of daughter volumes is printed

SimG4Core/PrintGeomInfo/test/python/g4OverlapCheckRun4DD4hep_cfg.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -62,17 +62,18 @@
6262
process.g4SimHits.CheckGeometry = True
6363

6464
# Geant4 geometry check
65-
process.g4SimHits.G4CheckOverlap.OutputBaseName = cms.string(baseName)
66-
process.g4SimHits.G4CheckOverlap.OverlapFlag = cms.bool(True)
67-
process.g4SimHits.G4CheckOverlap.Tolerance = cms.double(options.tol)
68-
process.g4SimHits.G4CheckOverlap.Resolution = cms.int32(10000)
69-
process.g4SimHits.G4CheckOverlap.Depth = cms.int32(-1)
65+
process.g4SimHits.G4CheckOverlap.NodeName = ""
66+
process.g4SimHits.G4CheckOverlap.OutputBaseName = baseName
67+
process.g4SimHits.G4CheckOverlap.OverlapFlag = True
68+
process.g4SimHits.G4CheckOverlap.Tolerance = options.tol
69+
process.g4SimHits.G4CheckOverlap.Resolution = 10000
70+
process.g4SimHits.G4CheckOverlap.Depth = -1
7071
# tells if NodeName is G4Region or G4PhysicalVolume
71-
process.g4SimHits.G4CheckOverlap.RegionFlag = cms.bool(False)
72+
process.g4SimHits.G4CheckOverlap.RegionFlag = False
7273
# list of names
73-
process.g4SimHits.G4CheckOverlap.NodeNames = cms.vstring('cms:OCMS_1')
74+
process.g4SimHits.G4CheckOverlap.NodeNames = ['cms:OCMS_1']
7475
# enable dump gdml file
75-
process.g4SimHits.G4CheckOverlap.gdmlFlag = cms.bool(False)
76+
process.g4SimHits.G4CheckOverlap.gdmlFlag = False
7677
# if defined a G4PhysicsVolume info is printed
7778
process.g4SimHits.G4CheckOverlap.PVname = ''
7879
# if defined a list of daughter volumes is printed

0 commit comments

Comments
 (0)