Skip to content

Commit 32f3682

Browse files
committed
Generated cfi files now may use new module syntax
- denote if must use full type info when dumping to cfi - test module now makes explicit named cfi files compatible with default
1 parent 8d727b6 commit 32f3682

34 files changed

+11325
-887
lines changed

FWCore/Integration/plugins/ProducerWithPSetDesc.cc

Lines changed: 561 additions & 559 deletions
Large diffs are not rendered by default.
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
from .testProducerWithPsetDesc_cfi import testProducerWithPsetDesc
2+
print(testProducerWithPsetDesc.dumpPython())

FWCore/Integration/test/run_ParameterSet.sh

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,13 @@ LOCAL_TEST_DIR=${SCRAM_TEST_PATH}
3434
cmsRun ${LOCAL_TEST_DIR}/runAutoGeneratedCfi_cfg.py || die "cmsRun runAutoGeneratedCfi_cfg.py" $?
3535

3636
# Compare the cfi file to a reference file to ensure it is correct
37-
diff ./testProducerWithPsetDesc_cfi.py ${LOCAL_TEST_DIR}/unit_test_outputs/testProducerWithPsetDesc_cfi.py || die "comparing testProducerWithPsetDesc_cfi.py" $?
37+
mkdir testcfi
38+
cp ${LOCAL_TEST_DIR}/cfi_dumpPython.py testcfi
39+
cp testProducerWithPsetDesc_cfi.py testcfi
40+
cp ProducerWithPSetDesc.py testcfi
41+
PYTHON3PATH=${PWD}:${PYTHON3PATH} python3 -m testcfi.cfi_dumpPython > dumpPython.log
42+
python3 ${LOCAL_TEST_DIR}/unit_test_outputs/testProducerWithPsetDesc_cfi.py > dumpPython_ref.log
43+
diff ./dumpPython.log dumpPython_ref.log || die "comparing testProducerWithPsetDesc_cfi.py" $?
3844

3945
# This time try a cfi without any of the required parameters to test that we properly insert
4046
# required missing parameters into the ParameterSet

FWCore/Integration/test/unit_test_outputs/testProducerWithPsetDesc_briefdoc.txt

Lines changed: 2731 additions & 10 deletions
Large diffs are not rendered by default.

FWCore/Integration/test/unit_test_outputs/testProducerWithPsetDesc_cfi.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -373,3 +373,5 @@
373373
),
374374
mightGet = cms.optional.untracked.vstring
375375
)
376+
377+
print(testProducerWithPsetDesc.dumpPython())

0 commit comments

Comments
 (0)