Skip to content

Commit 3ac75e4

Browse files
committed
Move RootHandlers base class to FWCore/AbstractServices
1 parent d61d791 commit 3ac75e4

File tree

7 files changed

+16
-8
lines changed

7 files changed

+16
-8
lines changed

FWCore/Utilities/interface/RootHandlers.h renamed to FWCore/AbstractServices/interface/RootHandlers.h

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
#ifndef FWCore_Utilities_RootHandlers_h
2-
#define FWCore_Utilities_RootHandlers_h
1+
#ifndef FWCore_AbstractServices_interface_RootHandlers_h
2+
#define FWCore_AbstractServices_interface_RootHandlers_h
33

44
#include "FWCore/Utilities/interface/propagate_const.h"
55
namespace edm {
@@ -20,7 +20,12 @@ namespace edm {
2020
friend class edm::EventProcessor;
2121

2222
public:
23-
virtual ~RootHandlers() {}
23+
RootHandlers() = default;
24+
RootHandlers(RootHandlers const&) = delete;
25+
RootHandlers& operator=(RootHandlers const&) = delete;
26+
RootHandlers(RootHandlers&&) = delete;
27+
RootHandlers& operator=(RootHandlers&&) = delete;
28+
virtual ~RootHandlers() = default;
2429

2530
template <typename F>
2631
void ignoreWarningsWhileDoing(F iFunc, SeverityLevel level = SeverityLevel::kWarning) {
@@ -36,4 +41,4 @@ namespace edm {
3641
};
3742
} // end of namespace edm
3843

39-
#endif // InitRootHandlers_H
44+
#endif

FWCore/Framework/src/EventProcessor.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@
5555
#include "FWCore/ParameterSet/interface/Registry.h"
5656
#include "FWCore/ParameterSet/interface/validateTopLevelParameterSets.h"
5757

58+
#include "FWCore/AbstractServices/interface/RootHandlers.h"
59+
5860
#include "FWCore/ServiceRegistry/interface/ServiceRegistry.h"
5961
#include "FWCore/ServiceRegistry/interface/Service.h"
6062
#include "FWCore/ServiceRegistry/interface/StreamContext.h"
@@ -74,7 +76,6 @@
7476
#include "FWCore/Utilities/interface/UnixSignalHandlers.h"
7577
#include "FWCore/Utilities/interface/ExceptionCollector.h"
7678
#include "FWCore/Utilities/interface/StreamID.h"
77-
#include "FWCore/Utilities/interface/RootHandlers.h"
7879
#include "FWCore/Utilities/interface/propagate_const.h"
7980
#include "FWCore/Utilities/interface/thread_safety_macros.h"
8081

FWCore/Services/plugins/InitRootHandlers.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#include "FWCore/Utilities/interface/RootHandlers.h"
1+
#include "FWCore/AbstractServices/interface/RootHandlers.h"
22

33
#include "FWCore/ServiceRegistry/interface/ActivityRegistry.h"
44
#include "FWCore/ServiceRegistry/interface/SystemBounds.h"

IOPool/Common/BuildFile.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
<use name="FWCore/AbstractServices"/>
12
<use name="FWCore/ServiceRegistry"/>
23
<use name="FWCore/Utilities"/>
34
<export>

IOPool/Common/src/RootServiceChecker.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#include "IOPool/Common/interface/RootServiceChecker.h"
2+
#include "FWCore/AbstractServices/interface/RootHandlers.h"
23
#include "FWCore/ServiceRegistry/interface/Service.h"
34
#include "FWCore/Utilities/interface/EDMException.h"
4-
#include "FWCore/Utilities/interface/RootHandlers.h"
55

66
namespace edm {
77
RootServiceChecker::RootServiceChecker() {

IOPool/Output/BuildFile.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
<use name="tbb"/>
33
<use name="DataFormats/Common"/>
44
<use name="DataFormats/Provenance"/>
5+
<use name="FWCore/AbstractServices"/>
56
<use name="FWCore/Framework"/>
67
<use name="FWCore/MessageLogger"/>
78
<use name="FWCore/ParameterSet"/>

IOPool/Output/src/RootOutputTree.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@
33

44
#include "DataFormats/Common/interface/RefCoreStreamer.h"
55
#include "DataFormats/Provenance/interface/ProductDescription.h"
6+
#include "FWCore/AbstractServices/interface/RootHandlers.h"
67
#include "FWCore/MessageLogger/interface/JobReport.h"
78
#include "FWCore/MessageLogger/interface/MessageLogger.h"
89
#include "FWCore/ServiceRegistry/interface/Service.h"
910
#include "FWCore/Utilities/interface/Algorithms.h"
1011
#include "FWCore/Utilities/interface/EDMException.h"
11-
#include "FWCore/Utilities/interface/RootHandlers.h"
1212
#include "FWCore/Catalog/interface/SiteLocalConfig.h"
1313
#include "FWCore/ServiceRegistry/interface/Service.h"
1414

0 commit comments

Comments
 (0)