[LLVM Analysis] Fix potential memory leak in ApvAnalysisFactory::constructAuxiliaryApvClasses

iarspider · iarspider · commit 431b1d452145 · 2024-10-02T16:00:13.000+02:00
diff --git a/CalibTracker/SiStripAPVAnalysis/src/ApvAnalysisFactory.cc b/CalibTracker/SiStripAPVAnalysis/src/ApvAnalysisFactory.cc
@@ -118,10 +118,12 @@ void ApvAnalysisFactory::constructAuxiliaryApvClasses(ApvAnalysis* theAPV, uint3
       theCM = new MedianCommonModeCalculator();
     } else {
       cout << "Sorry Only Median is available for now, Mean and FastLinear are coming soon" << endl;
+      delete theCommonMode;
       return;
     }
   } else {
     cout << "ApvAnalysisFactory: algorithm " << theAlgorithmType_ << " not supported" << endl;
+    delete theCommonMode;
     return;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -118,10 +118,12 @@ void ApvAnalysisFactory::constructAuxiliaryApvClasses(ApvAnalysis* theAPV, uint3`
`118`	`118`	`theCM = new MedianCommonModeCalculator();`
`119`	`119`	`} else {`
`120`	`120`	`cout << "Sorry Only Median is available for now, Mean and FastLinear are coming soon" << endl;`
	`121`	`+ delete theCommonMode;`
`121`	`122`	`return;`
`122`	`123`	`}`
`123`	`124`	`} else {`
`124`	`125`	`cout << "ApvAnalysisFactory: algorithm " << theAlgorithmType_ << " not supported" << endl;`
	`126`	`+ delete theCommonMode;`
`125`	`127`	`return;`
`126`	`128`	`}`
`127`	`129`