Merge pull request #48478 from pallabidas/Phase-2_GCT_PFCluster_update

cmsbuild · web-flow · commit 474b71ca60e5 · 2025-07-08T09:56:01.000+02:00
[Phase-2 L1T] fixing out of bound indices in Phase2L1CaloPFClusterEmulator
diff --git a/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloPFClusterEmulator.h b/L1Trigger/L1CaloTrigger/interface/Phase2L1CaloPFClusterEmulator.h
@@ -165,7 +165,7 @@ namespace gctpf {
 
   inline GCTint_t getPeakPositionHF(const RegionHF_t& region) {
     GCTEtaHFStripPeak_t etaPeak;
-    for (int i = 0; i < nHfPhi / 6; i++) {
+    for (int i = 0; i < nHfEta; i++) {
       etaPeak.p[i] = getPeakOfHFStrip(region.s[i]);
     }
     GCTint_t max = getPeakBinHF(etaPeak);
diff --git a/L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloPFClusterEmulator.cc b/L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloPFClusterEmulator.cc
@@ -150,7 +150,7 @@ void Phase2L1CaloPFClusterEmulator::produce(edm::Event& iEvent, const edm::Event
     if (k % 2 == 0)
       etaoffset = 0;
     else
-      etaoffset = 17;
+      etaoffset = nTowerEta / 2 - 2;
     if (k > 1 && k % 2 == 0)
       phioffset = phioffset + 4;
 

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,7 @@ namespace gctpf {`
`165`	`165`
`166`	`166`	`inline GCTint_t getPeakPositionHF(const RegionHF_t& region) {`
`167`	`167`	`GCTEtaHFStripPeak_t etaPeak;`
`168`		`- for (int i = 0; i < nHfPhi / 6; i++) {`
	`168`	`+ for (int i = 0; i < nHfEta; i++) {`
`169`	`169`	`etaPeak.p[i] = getPeakOfHFStrip(region.s[i]);`
`170`	`170`	`}`
`171`	`171`	`GCTint_t max = getPeakBinHF(etaPeak);`