Skip to content

Commit 5126e97

Browse files
committed
addressed comments from Efe
1 parent 00d49b4 commit 5126e97

File tree

1 file changed

+16
-14
lines changed

1 file changed

+16
-14
lines changed

DQM/L1TMonitor/src/L1TStage2EMTF.cc

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,19 @@ void L1TStage2EMTF::bookHistograms(DQMStore::IBooker& ibooker, const edm::Run&,
1818
// Monitor Dir
1919
ibooker.setCurrentFolder(monitorDir);
2020

21-
emtfErrors = ibooker.book1D("emtfErrors", "EMTF Errors", 5, 0, 5);
21+
emtfErrors = ibooker.book1D("emtfErrors", "EMTF Errors", 6, 0, 6);
2222
emtfErrors->setAxisTitle("Error Type (Corruptions Not Implemented)", 1);
2323
emtfErrors->setAxisTitle("Number of Errors", 2);
2424
if (isRun3 == true) {
25-
const std::array<std::string, 10> binNamesErrors{
25+
const std::array<std::string, 5> binNamesErrors{
2626
{"Corruptions", "FMM != Ready", "BSY", "OSY", "WOF"}};
2727
for (unsigned int bin = 0; bin < binNamesErrors.size(); ++bin) {
2828
emtfErrors->setBinLabel(bin + 1, binNamesErrors[bin], 1);
2929
}
3030
}
3131
if (isRun3 == false) {
32-
const std::array<std::string, 10> binNamesErrors{
33-
{"Corruptions", "Synch. Err.", "Synch. Mod.", "BX Mismatch", "Time Misalign"}};
32+
const std::array<std::string, 6> binNamesErrors{
33+
{"Corruptions", "Synch. Err.", "Synch. Mod.", "BX Mismatch", "Time Misalign", "FMM != Ready"}};
3434
for (unsigned int bin = 0; bin < binNamesErrors.size(); ++bin) {
3535
emtfErrors->setBinLabel(bin + 1, binNamesErrors[bin], 1);
3636
}
@@ -813,7 +813,6 @@ void L1TStage2EMTF::analyze(const edm::Event& e, const edm::EventSetup& c) {
813813
// DAQ Output
814814
edm::Handle<l1t::EMTFDaqOutCollection> DaqOutCollection;
815815
e.getByToken(daqToken, DaqOutCollection);
816-
817816

818817
for (auto DaqOut = DaqOutCollection->begin(); DaqOut != DaqOutCollection->end(); ++DaqOut) {
819818
const l1t::emtf::MECollection* MECollection = DaqOut->PtrMECollection();
@@ -828,18 +827,21 @@ void L1TStage2EMTF::analyze(const edm::Event& e, const edm::EventSetup& c) {
828827
emtfErrors->Fill(3);
829828
if (ME->AF())
830829
emtfErrors->Fill(4);
830+
if (!EventHeader->Rdy())
831+
emtfErrors->Fill(5);
831832
}};
832-
833+
833834
if (isRun3==true){
834-
if (!EventHeader->Rdy())
835-
emtfErrors->Fill(1);
836-
if (EventHeader->BSY())
837-
emtfErrors->Fill(2);
838-
if (EventHeader->OSY())
839-
emtfErrors->Fill(3);
840-
if (EventHeader->WOF())
841-
emtfErrors->Fill(4);
835+
if (!EventHeader->Rdy())
836+
emtfErrors->Fill(1);
837+
if (EventHeader->BSY())
838+
emtfErrors->Fill(2);
839+
if (EventHeader->OSY())
840+
emtfErrors->Fill(3);
841+
if (EventHeader->WOF())
842+
emtfErrors->Fill(4);
842843
};
844+
843845
// Fill MPC input link errors
844846
int offset = (EventHeader->Sector() - 1) * 9;
845847
int endcap = EventHeader->Endcap();

0 commit comments

Comments
 (0)