Implement consistency check for Validators

- associatormap, label and muonHistoParameters must have the same size
- associatormap and label must share the same input collection (associatormap and label vectors must have the same ordering)

Author: Parsifal-2045

Validation/RecoMuon/python/muonValidationHLT_cff.py

@@ -41,13 +41,13 @@
     label = (
         'hltL2Muons',
         'hltL2Muons:UpdatedAtVtx',
-        'hltIterL3OIMuonTrackSelectionHighPurity:',
-        'hltIterL3MuonMerged:',
-        'hltIterL3MuonAndMuonFromL1Merged:',
-        'hltIter0IterL3FromL1MuonTrackSelectionHighPurity:',
-        'hltIterL3GlbMuon:',
-        'hltIterL3MuonsNoIDTracks:',
-        'hltIterL3MuonsTracks:'
+        'hltIterL3OIMuonTrackSelectionHighPurity',
+        'hltIterL3MuonMerged',
+        'hltIterL3MuonAndMuonFromL1Merged',
+        'hltIter0IterL3FromL1MuonTrackSelectionHighPurity',
+        'hltIterL3GlbMuon',
+        'hltIterL3MuonsNoIDTracks',
+        'hltIterL3MuonsTracks'
     ),
     muonHistoParameters = (
         staMuonHistoParameters,
@@ -119,13 +119,38 @@ def _modify_for_OI_first(validator):
 (phase2L2AndL3Muons & ~phase2L3MuonsOIFirst).toModify(_hltMuonMultiTrackValidator, _modify_for_IO_first)
 (phase2L2AndL3Muons & phase2L3MuonsOIFirst).toModify(_hltMuonMultiTrackValidator, _modify_for_OI_first)
 
+# Check that the associators and labels are consistent
+# All MTV clones are DQMEDAnalyzers
+from DQMServices.Core.DQMEDAnalyzer import DQMEDAnalyzer
+# Access all the global variables
+global_items = list(globals().items())
+for _name, _obj in global_items:
+    # Find all MTV clones
+    if isinstance(_obj, DQMEDAnalyzer) and hasattr(_obj, 'label') and hasattr(_obj, 'associatormap') and hasattr(_obj, 'muonHistoParameters'):
+        # Check that the size of the associators, lables and muonHistoParameters are the same
+        if (len(_obj.label) != len(_obj.associatormap) or len(_obj.label) != len(_obj.muonHistoParameters)
+            or len(_obj.associatormap) != len(_obj.muonHistoParameters)):
+            raise RuntimeError(f"MuonTrackValidatorHLT -- {_name}: associatormap, label and muonHistoParameters must have the same length!")
+        # Check that the trackCollection used in each associator corresponds to the validator's label
+        for i in range(0, len(_obj.label)):
+            # Dynamically import the associators module to have access to procModifiers changes
+            associators_module = __import__('Validation.RecoMuon.associators_cff', globals(), locals(), ['associators'], 0)
+            _assoc = getattr(associators_module, _obj.associatormap[i].value()) if isinstance(_obj.associatormap[i], cms.InputTag) else getattr(associators_module, _obj.associatormap[i])
+            _label = _obj.label[i].value() if isinstance(_obj.label[i], cms.InputTag) else _obj.label[i]
+            _tracksTag = _assoc.tracksTag.value() if hasattr(_assoc, 'tracksTag') else _assoc.label_tr.value()
+            if _tracksTag != _label:
+                raise RuntimeError(f"MuonTrackValidatorHLT -- {_name}: associatormap and label do not match for index {i}.\n"
+                                   f"Associator's tracksTag: {_tracksTag}, collection label in the validator: {_label}.\n"
+                                   "Make sure to have the correct ordering!")
+
+from Configuration.Eras.Modifier_phase2_muon_cff import phase2_muon
+phase2_muon.toReplaceWith(hltMuonMultiTrackValidator, _hltMuonMultiTrackValidator)
+
 #
 # The full Muon HLT validation sequence
 #
-muonValidationHLT_seq = cms.Sequence(muonAssociationHLT_seq + hltMuonMultiTrackValidator)
 
-from Configuration.Eras.Modifier_phase2_muon_cff import phase2_muon
-phase2_muon.toReplaceWith(hltMuonMultiTrackValidator, _hltMuonMultiTrackValidator)
+muonValidationHLT_seq = cms.Sequence(muonAssociationHLT_seq + hltMuonMultiTrackValidator)
 
 recoMuonValidationHLT_seq = cms.Sequence(
     cms.SequencePlaceholder("TPmu") +

Validation/RecoMuon/python/muonValidation_cff.py

@@ -227,6 +227,30 @@
     )
 )
 
+# Check that the associators and labels are consistent
+# All MTV clones are DQMEDAnalyzers
+from DQMServices.Core.DQMEDAnalyzer import DQMEDAnalyzer
+# Access all the global variables
+global_items = list(globals().items())
+for _name, _obj in global_items:
+    # Find all MTV clones
+    if isinstance(_obj, DQMEDAnalyzer) and hasattr(_obj, 'label') and hasattr(_obj, 'associatormap') and hasattr(_obj, 'muonHistoParameters'):
+        # Check that the size of the associators, lables and muonHistoParameters are the same
+        if (len(_obj.label) != len(_obj.associatormap) or len(_obj.label) != len(_obj.muonHistoParameters)
+            or len(_obj.associatormap) != len(_obj.muonHistoParameters)):
+            raise RuntimeError(f"MuonTrackValidator -- {_name}: associatormap, label and muonHistoParameters must have the same length!")
+        # Check that the trackCollection used in each associator corresponds to the validator's label
+        for i in range(0, len(_obj.label)):
+            # Dynamically import the associators module to have access to procModifiers changes
+            associators_module = __import__('Validation.RecoMuon.associators_cff', globals(), locals(), ['associators'], 0)
+            _assoc = getattr(associators_module, _obj.associatormap[i].value()) if isinstance(_obj.associatormap[i], cms.InputTag) else getattr(associators_module, _obj.associatormap[i])
+            _label = _obj.label[i].value() if isinstance(_obj.label[i], cms.InputTag) else _obj.label[i]
+            _tracksTag = _assoc.tracksTag.value() if hasattr(_assoc, 'tracksTag') else _assoc.label_tr.value()
+            if _tracksTag != _label:
+                raise RuntimeError(f"MuonTrackValidator -- {_name}: associatormap and label do not match for index {i}.\n"
+                                   f"Associator's tracksTag: {_tracksTag}, collection label in the validator: {_label}.\n"
+                                   "Make sure to have the correct ordering!")
+
 ##################################################################################
 # Muon validation sequences using MuonTrackValidator
 #