Skip to content

Commit 5d50a9e

Browse files
committed
Fixed English in the documentation
1 parent c41eb18 commit 5d50a9e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

FWCore/Concurrency/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ Exactly how to _dispose_ of the class can be customized via the virtual function
1111
## `edm::WaitingTask`
1212
This class inherits from `edm::TaskBase` and represents a set of code to be run once other activities have completed. This includes the ability to hold a `std::exception_ptr` which can hold an exception which was generated in a dependent task.
1313

14-
A raw pointer to a `edm::WaitingTask` is not supposed to be handled directly. Instead, one should use the helpers `edm::WaitingTaskHolder`, `edm::WaitingTaskWithArenaHolder` or `edm::WaitingTaskList` to properly manage the internal reference count such that when the count drops to 0 the `execute()` method will be run followed by `recycle()`. In addition, these helper classes will handled passing along any `edm::exception_ptr` generated from a dependent task.
14+
A raw pointer to a `edm::WaitingTask` is not supposed to be handled directly. Instead, one should use the helpers `edm::WaitingTaskHolder`, `edm::WaitingTaskWithArenaHolder` or `edm::WaitingTaskList` to properly manage the internal reference count such that when the count drops to 0 the `execute()` method will be run followed by `recycle()`. In addition, these helper classes will handle passing along any `edm::exception_ptr` generated from a dependent task.
1515

1616
The easiest way to create an `edm::WaitingTask` is to call `edm::make_waiting_task` and pass in a lambda of the form `void(std::exception_ptr const*)`.
1717
```C++
@@ -34,7 +34,7 @@ In the case where one is doing a synchronous wait on a series of asynchronous ta
3434

3535
Note that the function `wait` will rethrow any exception stored in `finalTask`. There is an alternative function named `waitNoThrow` which will return the `std::exception_ptr`.
3636

37-
WARNING: It important that the finalTask not execute before completion of the construction of all `WaitingTaskHolders` that will be constructed directly from finalTask. The following would be a bug:
37+
WARNING: It is important that the finalTask not be executed before completion of the construction of all `WaitingTaskHolders` that will be constructed directly from finalTask. The following would be a bug:
3838

3939
```C++
4040
oneapi::tbb::task_group group;

0 commit comments

Comments
 (0)