Skip to content

Commit 611881f

Browse files
authored
Merge pull request #45764 from mmusich/mm_dev_fixD88_missing
fix a bunch of failing unit tests after D88 and D92 went missing
2 parents 18e28ff + 9c57448 commit 611881f

22 files changed

+174
-59
lines changed

Alignment/OfflineValidation/python/TkAlAllInOneTool/defaultInputFiles_cff.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@
2323
filesDefaultMC_DoubleMuonPUPhase_string = '/store/mc/Phase2Fall22DRMiniAOD/DYJetsToMuMu_M-50_TuneCP5_14TeV-madgraphMLM-pythia8/ALCARECO/TkAlZMuMu-PU200ALCA_TkAlPU200_125X_mcRun4_realistic_v5-v1/60000/9382696c-70fd-4b37-8a0f-24bd02aeda5f.root'
2424

2525
filesDefaultMC_MinBiasPUPhase2RECO = cms.untracked.vstring(
26-
'/store/relval/CMSSW_12_5_3/RelValMinBias_14TeV/GEN-SIM-RECO/125X_mcRun4_realistic_v5_2026D88PU-v1/2590000/22e22ae6-a353-4f2e-815e-cc5efee37af9.root',
26+
'/store/relval/CMSSW_14_1_0_pre6/RelValMinBias_14TeV/GEN-SIM-RECO/PU_141X_mcRun4_realistic_v1_STD_2026D110_PU-v3/2560000/c22f1cbd-50e3-458e-aba9-b0a327e4c971.root'
2727
)
2828

2929
filesDefaultMC_TTbarPhase2RECO = cms.untracked.vstring(
30-
'/store/relval/CMSSW_12_6_0_pre5/RelValTTbar_14TeV/GEN-SIM-RECO/125X_mcRun4_realistic_v5_2026D88noPU-v1/2590000/57cbe250-487d-4a47-998b-48f9028a0058.root',
30+
'/store/relval/CMSSW_14_1_0_pre5/RelValTTbar_14TeV/GEN-SIM-RECO/140X_mcRun4_realistic_v4_STD_2026D110_noPU-v1/2580000/b8c9ef5e-9c45-4c47-aae3-4db1304cd66e.root',
3131
)
3232

3333
filesDefaultData_JetHTRun2018D = cms.untracked.vstring(

Alignment/OfflineValidation/test/testPrimaryVertexRelatedValidations_cfg.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,17 @@ class RefitType(Enum):
3333
_theRefitter = RefitType.COMMON # RefitType.STANDARD (other option not involving filtering)
3434
_theTrackCollection = 'generalTracks' # FIXME: 'ALCARECOTkAlMinBias' once a sample is available
3535

36+
###################################################################
37+
# Set default phase-2 settings
38+
###################################################################
39+
import Configuration.Geometry.defaultPhase2ConditionsEra_cff as _settings
40+
_PH2_GLOBAL_TAG, _PH2_ERA = _settings.get_era_and_conditions(_settings.DEFAULT_VERSION)
41+
3642
###################################################################
3743
# Set the era
3844
###################################################################
3945
if(options.isPhase2):
40-
from Configuration.Eras.Era_Phase2C17I13M9_cff import Phase2C17I13M9
41-
process = cms.Process("Demo",Phase2C17I13M9)
46+
process = cms.Process("Demo", _PH2_ERA)
4247
else:
4348
from Configuration.Eras.Era_Run3_cff import Run3
4449
process = cms.Process("Demo", Run3)
@@ -104,7 +109,7 @@ class RefitType(Enum):
104109
# Standard loads
105110
###################################################################
106111
if(options.isPhase2):
107-
process.load('Configuration.Geometry.GeometryExtended2026D88Reco_cff')
112+
process.load('Configuration.Geometry.GeometryExtended2026DefaultReco_cff')
108113
else:
109114
process.load("Configuration.Geometry.GeometryRecoDB_cff")
110115

@@ -118,7 +123,7 @@ class RefitType(Enum):
118123
####################################################################
119124
process.load("Configuration.StandardSequences.FrontierConditions_GlobalTag_cff")
120125
from Configuration.AlCa.GlobalTag import GlobalTag
121-
process.GlobalTag = GlobalTag(process.GlobalTag, ('auto:phase2_realistic_T21' if options.isPhase2 else 'auto:phase1_2022_realistic'), '')
126+
process.GlobalTag = GlobalTag(process.GlobalTag, (_PH2_GLOBAL_TAG if options.isPhase2 else 'auto:phase1_2022_realistic'), '')
122127

123128
if _allFromGT:
124129
print("############ testPVValidation_cfg.py: msg%-i: All is taken from GT")

Alignment/TrackerAlignment/test/Misalignments/createRandomlyMisalignedGeometry_Phase2_cfg.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
import FWCore.ParameterSet.VarParsing as VarParsing
44
import copy, sys, os
55

6-
process = cms.Process("Misaligner")
6+
import Configuration.Geometry.defaultPhase2ConditionsEra_cff as _settings
7+
GLOBAL_TAG, ERA = _settings.get_era_and_conditions("2026D107") # this should really be _settings.DEFAULT_VERSION :(
8+
process = cms.Process("Misaligner", ERA)
79

810
###################################################################
911
# Setup 'standard' options
@@ -46,15 +48,16 @@
4648
###################################################################
4749
# Ideal geometry producer and standard includes
4850
###################################################################
49-
process.load('Configuration.Geometry.GeometryExtended2026D88Reco_cff')
51+
process.load('Configuration.Geometry.GeometryExtended2026D107Reco_cff')
5052
process.trackerGeometry.applyAlignment = True
5153

5254
###################################################################
5355
# Just state the Global Tag (and pick some run)
5456
###################################################################
5557
process.load('Configuration.StandardSequences.FrontierConditions_GlobalTag_cff')
5658
from Configuration.AlCa.GlobalTag import GlobalTag
57-
process.GlobalTag = GlobalTag(process.GlobalTag, 'auto:phase2_realistic_T21', '') # using realistic Phase 2 geom
59+
#process.GlobalTag = GlobalTag(process.GlobalTag, 'auto:phase2_realistic_T25', '') # using realistic Phase 2 geom
60+
process.GlobalTag = GlobalTag(process.GlobalTag, GLOBAL_TAG, '') # using realistic Phase 2 geom
5861
print("Using global tag:", process.GlobalTag.globaltag.value())
5962

6063
###################################################################

CondTools/SiPhase2Tracker/test/SiPhase2BadStripChannelBuilder_cfg.py

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
import FWCore.ParameterSet.Config as cms
22

3-
process = cms.Process("ICALIB")
3+
###################################################################
4+
# Set default phase-2 settings
5+
###################################################################
6+
import Configuration.Geometry.defaultPhase2ConditionsEra_cff as _settings
7+
_PH2_GLOBAL_TAG, _PH2_ERA = _settings.get_era_and_conditions(_settings.DEFAULT_VERSION)
8+
9+
process = cms.Process("ICALIB", _PH2_ERA)
410
import FWCore.ParameterSet.VarParsing as VarParsing
511

612
options = VarParsing.VarParsing('analysis')
@@ -17,13 +23,13 @@
1723
engineName = cms.untracked.string('TRandom3')
1824
)
1925

20-
## specify detector D88, as the geometry is needed (will take tracker T24)
21-
process.load("Configuration.Geometry.GeometryExtended2026D88_cff")
22-
process.load('Configuration.Geometry.GeometryExtended2026D88Reco_cff')
26+
## specify the default phase2 detector
27+
process.load("Configuration.Geometry.GeometryExtended2026Default_cff")
28+
process.load('Configuration.Geometry.GeometryExtended2026DefaultReco_cff')
2329

2430
process.load("Configuration.StandardSequences.FrontierConditions_GlobalTag_cff")
2531
from Configuration.AlCa.GlobalTag import GlobalTag
26-
process.GlobalTag = GlobalTag(process.GlobalTag, 'auto:phase2_realistic_T21', '')
32+
process.GlobalTag = GlobalTag(process.GlobalTag, _PH2_GLOBAL_TAG, '')
2733

2834
###################################################################
2935
# Messages
@@ -61,10 +67,10 @@
6167
authenticationPath = cms.untracked.string('')
6268
),
6369
timetype = cms.untracked.string('runnumber'),
64-
connect = cms.string('sqlite_file:SiStripBadStripPhase2_T21_v0.db'),
70+
connect = cms.string('sqlite_file:SiStripBadStripPhase2_T33_v0.db'),
6571
toPut = cms.VPSet(cms.PSet(
6672
record = cms.string('SiStripBadStripRcd'),
67-
tag = cms.string('SiStripBadStripPhase2_T21')
73+
tag = cms.string('SiStripBadStripPhase2_T33')
6874
))
6975
)
7076

CondTools/SiPhase2Tracker/test/SiPhase2BadStripChannelReader_cfg.py

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,13 @@
33
import FWCore.ParameterSet.Config as cms
44
import FWCore.ParameterSet.VarParsing as VarParsing
55

6-
process = cms.Process("TEST")
6+
###################################################################
7+
# Set default phase-2 settings
8+
###################################################################
9+
import Configuration.Geometry.defaultPhase2ConditionsEra_cff as _settings
10+
_PH2_GLOBAL_TAG, _PH2_ERA = _settings.get_era_and_conditions(_settings.DEFAULT_VERSION)
11+
12+
process = cms.Process("TEST", _PH2_ERA)
713
options = VarParsing.VarParsing('analysis')
814
options.register('fromESSource',
915
False, # default value
@@ -48,16 +54,16 @@
4854
# Input data
4955
###################################################################
5056
if(options.fromESSource):
51-
process.load("Configuration.Geometry.GeometryExtended2026D88_cff")
52-
process.load('Configuration.Geometry.GeometryExtended2026D88Reco_cff')
57+
process.load("Configuration.Geometry.GeometryExtended2026Default_cff")
58+
process.load('Configuration.Geometry.GeometryExtended2026DefaultReco_cff')
5359
process.load("Configuration.StandardSequences.FrontierConditions_GlobalTag_cff")
5460
from Configuration.AlCa.GlobalTag import GlobalTag
55-
process.GlobalTag = GlobalTag(process.GlobalTag, 'auto:phase2_realistic_T21', '')
61+
process.GlobalTag = GlobalTag(process.GlobalTag, _PH2_GLOBAL_TAG, '')
5662
#process.load("SLHCUpgradeSimulations.Geometry.fakePhase2OuterTrackerConditions_cff") # already included
5763
#process.SiPhase2OTFakeBadStripsESSource.printDebug = cms.untracked.bool(True) # this makes it verbose
5864
process.SiPhase2OTFakeBadStripsESSource.badComponentsFraction = cms.double(0.05) # bad components fraction is 5%
5965
else:
60-
tag = 'SiStripBadStripPhase2_T21'
66+
tag = 'SiStripBadStripPhase2_T33'
6167
suffix = 'v0'
6268
inFile = tag+'_'+suffix+'.db'
6369
inDB = 'sqlite_file:'+inFile

CondTools/SiPhase2Tracker/test/SiPhase2OuterTrackerLorentzAngleReader_cfg.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
###################################################################
3737
# Input data
3838
###################################################################
39-
tag = 'SiPhase2OuterTrackerLorentzAngle_T21'
39+
tag = 'SiPhase2OuterTrackerLorentzAngle_T33'
4040
suffix = 'v0'
4141
inFile = tag+'_'+suffix+'.db'
4242
inDB = 'sqlite_file:'+inFile
@@ -58,7 +58,7 @@
5858
###################################################################
5959
process.get = cms.EDAnalyzer("EventSetupRecordDataGetter",
6060
toGet = cms.VPSet(cms.PSet(
61-
record = cms.string(' SiPhase2OuterTrackerLorentzAngleRcd'),
61+
record = cms.string('SiPhase2OuterTrackerLorentzAngleRcd'),
6262
data = cms.vstring('SiPhase2OuterTrackerLorentzAngle')
6363
)),
6464
verbose = cms.untracked.bool(True)

CondTools/SiPhase2Tracker/test/SiPhase2OuterTrackerLorentzAngleWriter_cfg.py

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,14 @@
33
from __future__ import print_function
44
import os, shlex, shutil, getpass
55

6+
###################################################################
7+
# Set default phase-2 settings
8+
###################################################################
9+
import Configuration.Geometry.defaultPhase2ConditionsEra_cff as _settings
10+
_PH2_GLOBAL_TAG, _PH2_ERA = _settings.get_era_and_conditions(_settings.DEFAULT_VERSION)
11+
612
import FWCore.ParameterSet.Config as cms
7-
process = cms.Process("TEST")
13+
process = cms.Process("TEST", _PH2_ERA)
814

915
###################################################################
1016
# Messages
@@ -25,7 +31,7 @@
2531
SiPhase2OuterTrackerLorentzAngle = cms.untracked.PSet( limit = cms.untracked.int32(-1)),
2632
)
2733

28-
tag = 'SiPhase2OuterTrackerLorentzAngle_T21'
34+
tag = 'SiPhase2OuterTrackerLorentzAngle_T33'
2935
suffix = 'v0'
3036
outfile = tag+'_'+suffix+'.db'
3137
outdb = 'sqlite_file:'+outfile
@@ -38,12 +44,12 @@
3844
process.load("CondCore.CondDB.CondDB_cfi")
3945
process.CondDB.connect = cms.string(outdb)
4046

41-
process.load('Configuration.Geometry.GeometryExtended2026D88Reco_cff')
42-
process.load('Configuration.Geometry.GeometryExtended2026D88_cff')
47+
process.load('Configuration.Geometry.GeometryExtended2026DefaultReco_cff')
48+
process.load('Configuration.Geometry.GeometryExtended2026Default_cff')
4349

4450
process.load('Configuration.StandardSequences.FrontierConditions_GlobalTag_cff')
4551
from Configuration.AlCa.GlobalTag import GlobalTag
46-
process.GlobalTag = GlobalTag(process.GlobalTag, 'auto:phase2_realistic_T21')
52+
process.GlobalTag = GlobalTag(process.GlobalTag, _PH2_GLOBAL_TAG)
4753
process.maxEvents = cms.untracked.PSet( input = cms.untracked.int32(1) )
4854

4955
process.source = cms.Source("EmptyIOVSource",
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
import FWCore.ParameterSet.Config as cms
22

3-
from Configuration.Geometry.GeometryDD4hepExtended2026D98Reco_cff import *
3+
from Configuration.Geometry.GeometryDD4hepExtended2026D110Reco_cff import *
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
import FWCore.ParameterSet.Config as cms
22

3-
from Configuration.Geometry.GeometryDD4hepExtended2026D98_cff import *
3+
from Configuration.Geometry.GeometryDD4hepExtended2026D110_cff import *
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
import FWCore.ParameterSet.Config as cms
22

3-
from Configuration.Geometry.GeometryExtended2026D98Reco_cff import *
3+
from Configuration.Geometry.GeometryExtended2026D110Reco_cff import *

0 commit comments

Comments
 (0)