Skip to content

Commit 6408de4

Browse files
committed
fix code-checks in ProductProvenanceLookup
Removed an unnecessary move operation.
1 parent e04f43e commit 6408de4

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

DataFormats/Provenance/interface/ProductProvenanceLookup.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,7 @@ namespace edm {
4242
public:
4343
ProducedProvenanceInfo(BranchID iBid) : provenance_{iBid}, isParentageSet_{false} {}
4444
ProducedProvenanceInfo(ProducedProvenanceInfo&& iOther)
45-
: provenance_{std::move(iOther.provenance_)},
46-
isParentageSet_{iOther.isParentageSet_.load(std::memory_order_acquire)} {}
45+
: provenance_{iOther.provenance_}, isParentageSet_{iOther.isParentageSet_.load(std::memory_order_acquire)} {}
4746
ProducedProvenanceInfo(ProducedProvenanceInfo const& iOther) : provenance_{iOther.provenance_.branchID()} {
4847
bool isSet = iOther.isParentageSet_.load(std::memory_order_acquire);
4948
if (isSet) {
@@ -53,7 +52,7 @@ namespace edm {
5352
}
5453

5554
ProducedProvenanceInfo& operator=(ProducedProvenanceInfo&& iOther) {
56-
provenance_ = std::move(iOther.provenance_);
55+
provenance_ = iOther.provenance_;
5756
isParentageSet_.store(iOther.isParentageSet_.load(std::memory_order_acquire), std::memory_order_release);
5857
return *this;
5958
}

0 commit comments

Comments
 (0)