modified SCS and minor changes in the SuperclusteringDNNInputs

Author: gsokmen

RecoHGCal/TICL/interface/SuperclusteringDNNInputs.h

@@ -2,7 +2,7 @@
 // Author: Theo Cuisset - [email protected]
 // Date: 11/2023
 
-// Modified by Gamze Sokmen 
+// Modified by Gamze Sokmen - [email protected]
 // Changes: Implementation of the delta time feature under a new DNN input version (v3) for the superclustering DNN and correcting the seed pT calculation.
 // Date: 07/2025
 
@@ -14,6 +14,11 @@
 #include <memory>
 
 namespace ticl {
+
+  // any raw_dt outside +/- kDeltaTimeDefault is considered bad
+  static constexpr float kDeltaTimeDefault = 50.f;
+  static constexpr float kBadDeltaTime = -5.f;
+
   class Trackster;
 
   // Abstract base class for DNN input preparation.
@@ -91,7 +96,7 @@ namespace ticl {
     }
   };
 
-  /* Third version of DNN by Gamze Sokmen, making use of time information as new variables.
+  /* Third version of DNN by Gamze Sokmen and Shamik Ghosh, making use of time information as new variables.
   Uses features : ['DeltaEta', 'DeltaPhi', 'multi_en', 'multi_eta', 'multi_pt', 'seedEta','seedPhi','seedEn', 'seedPt',   theta', 'theta_xz_seedFrame', 'theta_yz_seedFrame', 'theta_xy_cmsFrame', 'theta_yz_cmsFrame', 'theta_xz_cmsFrame', 'explVar', 'explVarRatio', 'mod_deltaTime']
   */
 
@@ -126,4 +131,4 @@ namespace ticl {
   std::unique_ptr<AbstractSuperclusteringDNNInput> makeSuperclusteringDNNInputFromString(std::string dnnVersion);
 }  // namespace ticl
 
-#endif
+#endif

RecoHGCal/TICL/src/SuperclusteringDNNInputs.cc

@@ -2,7 +2,7 @@
 // Author: Theo Cuisset - [email protected]
 // Date: 11/2023
 
-// Modified by Gamze Sokmen 
+// Modified by Gamze Sokmen - [email protected] 
 // Changes: Implementation of the delta time feature under a new DNN input version (v3) for the superclustering DNN and correcting the seed pT calculation.
 // Date: 07/2025
 
@@ -123,8 +123,8 @@ namespace ticl {
 
     float explVar_denominator = std::accumulate(
         std::begin(ts_toCluster.eigenvalues()), std::end(ts_toCluster.eigenvalues()), 0.f, std::plus<float>());
-    float explVarRatio = 0.;
-    if (explVar_denominator != 0.) {
+    float explVarRatio = 0.f;
+    if (explVar_denominator != 0.f) {
       explVarRatio = ts_toCluster.eigenvalues()[0] / explVar_denominator;
     } else {
       edm::LogWarning("HGCalTICLSuperclustering")
@@ -134,8 +134,7 @@ namespace ticl {
 
     // modified deltaTime: set the default values <-50 or >50 to -5
     float raw_dt       = ts_toCluster.time() - ts_base.time();
-    float mod_deltaTime = (raw_dt < -50.f || raw_dt > 50.f) ? -5.f : raw_dt;
-
+    float mod_deltaTime = ( raw_dt < -kDeltaTimeDefault || raw_dt > kDeltaTimeDefault ) ? kBadDeltaTime : raw_dt;
 
     return {{
       std::abs(ts_toCluster.barycenter().Eta()) - std::abs(ts_base.barycenter().Eta()),  // DeltaEtaBaryc