Merge pull request #49263 from mandrenguyen/revert_PR49179

Revert "Merge pull request #49179 from pallabidas/EMTF_NN_hls"

Author: cmsbuild

L1Trigger/L1TMuonEndCap/BuildFile.xml

@@ -8,5 +8,3 @@
 <use name="DataFormats/L1TMuon"/>
 <use name="L1Trigger/L1TMuon"/>
 <use name="PhysicsTools/TensorFlow"/>
-<use name="hls"/>
-<use name="hls4mlEmulatorExtras"/>

L1Trigger/L1TMuonEndCap/interface/PtAssignment.h

@@ -24,7 +24,7 @@ class PtAssignment {
                  bool promoteMode7,
                  int modeQualVer,
                  std::vector<int> promoteMode7Sectors,
-                 std::string nnModel);
+                 std::string pbFileName);
 
   void process(EMTFTrackCollection& best_tracks);
 

L1Trigger/L1TMuonEndCap/interface/PtAssignmentEngineDxy.h

@@ -10,30 +10,33 @@
 
 #include "L1Trigger/L1TMuonEndCap/interface/Common.h"
 #include "L1Trigger/L1TMuonEndCap/interface/PtAssignmentEngineAux2017.h"
+#include "PhysicsTools/TensorFlow/interface/TensorFlow.h"
 #include "FWCore/ParameterSet/interface/FileInPath.h"
-#include "ap_fixed.h"
-#include "hls4ml/emulator.h"
 
 class PtAssignmentEngineDxy {
 public:
   explicit PtAssignmentEngineDxy();
   virtual ~PtAssignmentEngineDxy();
 
-  void configure(int verbose, const std::string nnModel);
+  void configure(int verbose, const std::string pbFileNameDxy);
 
   const PtAssignmentEngineAux2017& aux() const;
 
   virtual void calculate_pt_dxy(const EMTFTrack& track, emtf::Feature& feature, emtf::Prediction& prediction) const;
 
   virtual void preprocessing_dxy(const EMTFTrack& track, emtf::Feature& feature) const;
 
-  virtual void call_hls_dxy(const emtf::Feature& feature, emtf::Prediction& prediction) const;
+  virtual void call_tensorflow_dxy(const emtf::Feature& feature, emtf::Prediction& prediction) const;
 
 protected:
   int verbose_;
-  std::string nnModel_;
-  std::unique_ptr<hls4mlEmulator::ModelLoader> loader;
-  std::shared_ptr<hls4mlEmulator::Model> model;
+
+  tensorflow::GraphDef* graphDefDxy_;
+  tensorflow::Session* sessionDxy_;
+  std::string pbFileNameDxy_;
+  std::string pbFilePathDxy_;
+  std::string inputNameDxy_;
+  std::vector<std::string> outputNamesDxy_;
 };
 
 #endif

L1Trigger/L1TMuonEndCap/interface/VersionControl.h

@@ -58,7 +58,7 @@ class VersionControl {
   bool bug9BitDPhi_, bugMode7CLCT_, bugNegPt_, bugGMTPhi_, promoteMode7_;
   int modeQualVer_;
   std::vector<int> promoteMode7Sectors_;  // Sectors to promote mode 7 tracks in Run 2 and Run 3, -1 for all sectors
-  std::string nnModel_;
+  std::string pbFileName_;
 };
 
 #endif

L1Trigger/L1TMuonEndCap/plugins/BuildFile.xml

@@ -1,6 +1,4 @@
 <library file="*.cc" name="L1TriggerL1TMuonEndCapPlugins">
   <use name="L1Trigger/L1TMuonEndCap"/>
-  <use name="hls"/>
-  <use name="hls4mlEmulatorExtras"/>
   <flags EDM_PLUGIN="1"/>
 </library>

L1Trigger/L1TMuonEndCap/python/simEmtfDigis_cfi.py

@@ -126,7 +126,7 @@
         PromoteMode7    = cms.bool(False), # Assign station 2-3-4 tracks with |eta| > 1.6 SingleMu quality
         ModeQualVer     = cms.int32(2),    # Version 2 contains modified mode-quality mapping for 2018
         PromoteMode7Sectors = cms.vint32(-1), # Sectors to promote mode 7 tracks in Run 2 and Run 3, -1 for all sectors
-        NNModel = cms.string('EMTFnn_v1'), # HLS model name to be used by NN based pT assignment NNv16 is online since 26.06.2023
+        ProtobufFileName = cms.string('model_graph.displ.16.pb'), # Protobuf file name to be used by NN based pT assignment NNv16 is online since 26.06.2023
     ),
 
 )

L1Trigger/L1TMuonEndCap/src/PtAssignment.cc

@@ -18,7 +18,7 @@ void PtAssignment::configure(PtAssignmentEngine* pt_assign_engine,
                              bool promoteMode7,
                              int modeQualVer,
                              std::vector<int> promoteMode7Sectors,
-                             std::string nnModel) {
+                             std::string pbFileName) {
   emtf_assert(pt_assign_engine != nullptr);
   emtf_assert(pt_assign_engine_dxy != nullptr);
 
@@ -33,7 +33,7 @@ void PtAssignment::configure(PtAssignmentEngine* pt_assign_engine,
 
   pt_assign_engine_->configure(verbose_, readPtLUTFile, fixMode15HighPt, bug9BitDPhi, bugMode7CLCT, bugNegPt);
 
-  pt_assign_engine_dxy_->configure(verbose_, nnModel);
+  pt_assign_engine_dxy_->configure(verbose_, pbFileName);
 
   bugGMTPhi_ = bugGMTPhi;
   promoteMode7_ = promoteMode7;

L1Trigger/L1TMuonEndCap/src/PtAssignmentEngineDxy.cc

@@ -6,16 +6,34 @@
 
 #include "helper.h"  // assert_no_abort
 
-PtAssignmentEngineDxy::PtAssignmentEngineDxy() {}
+PtAssignmentEngineDxy::PtAssignmentEngineDxy() : graphDefDxy_(nullptr), sessionDxy_(nullptr) {}
 
-PtAssignmentEngineDxy::~PtAssignmentEngineDxy() {}
+PtAssignmentEngineDxy::~PtAssignmentEngineDxy() {
+  if (sessionDxy_ != nullptr) {
+    tensorflow::closeSession(sessionDxy_);
+  }
+  delete graphDefDxy_;
+}
 
-void PtAssignmentEngineDxy::configure(int verbose, const std::string nnModel) {
-  nnModel_ = nnModel;
+void PtAssignmentEngineDxy::configure(int verbose, const std::string pbFileNameDxy) {
   verbose_ = verbose;
-  std::string nnModelDxy_ = nnModel_;
-  loader = std::make_unique<hls4mlEmulator::ModelLoader>(nnModelDxy_);
-  model = loader->load_model();
+
+  pbFileNameDxy_ = pbFileNameDxy;
+  std::string pbFilePathDxy_ = "L1Trigger/L1TMuon/data/emtf_luts/" + pbFileNameDxy_;
+
+  inputNameDxy_ = "input1";
+  outputNamesDxy_ = {"Identity"};
+
+  if (graphDefDxy_ == nullptr) {
+    graphDefDxy_ = tensorflow::loadGraphDef(edm::FileInPath(pbFilePathDxy_).fullPath());
+  }
+  emtf_assert(graphDefDxy_ != nullptr);
+
+  if (sessionDxy_ == nullptr) {
+    sessionDxy_ = tensorflow::createSession(graphDefDxy_);
+  }
+
+  emtf_assert(sessionDxy_ != nullptr);
 }
 
 const PtAssignmentEngineAux2017& PtAssignmentEngineDxy::aux() const {
@@ -28,7 +46,7 @@ void PtAssignmentEngineDxy::calculate_pt_dxy(const EMTFTrack& track,
                                              emtf::Prediction& prediction) const {
   // This is called for each track instead of for entire track collection as was done in Phase-2 implementation
   preprocessing_dxy(track, feature);
-  call_hls_dxy(feature, prediction);
+  call_tensorflow_dxy(feature, prediction);
   return;
 }
 
@@ -135,24 +153,19 @@ void PtAssignmentEngineDxy::preprocessing_dxy(const EMTFTrack& track, emtf::Feat
   return;
 }
 
-void PtAssignmentEngineDxy::call_hls_dxy(const emtf::Feature& feature, emtf::Prediction& prediction) const {
+void PtAssignmentEngineDxy::call_tensorflow_dxy(const emtf::Feature& feature, emtf::Prediction& prediction) const {
+  tensorflow::Tensor input(tensorflow::DT_FLOAT, {1, emtf::NUM_FEATURES});
+  std::vector<tensorflow::Tensor> outputs;
   emtf_assert(feature.size() == emtf::NUM_FEATURES);
 
-  ap_uint<13> nn_input[29];
-  for (size_t i = 0; i < feature.size(); i++) {
-    nn_input[i] = feature[i];
-  }
-  ap_uint<8> nn_output[2];
-  model->prepare_input(nn_input);
-  model->predict();
-  model->read_result(nn_output);
-  ap_uint<8> pT = nn_output[0];
-  ap_uint<7> dxy = (nn_output[1] > 127) ? ap_uint<7>(127) : ap_uint<7>(nn_output[1]);
-
+  float* d = input.flat<float>().data();
+  std::copy(feature.begin(), feature.end(), d);
+  tensorflow::run(sessionDxy_, {{inputNameDxy_, input}}, outputNamesDxy_, &outputs);
+  emtf_assert(outputs.size() == 1);
   emtf_assert(prediction.size() == emtf::NUM_PREDICTIONS);
 
-  prediction.at(0) = pT.to_float();
-  prediction.at(1) = dxy.to_float();
+  prediction.at(0) = outputs[0].matrix<float>()(0, 0);
+  prediction.at(1) = outputs[0].matrix<float>()(0, 1);
 
   return;
 }

L1Trigger/L1TMuonEndCap/src/SectorProcessor.cc

@@ -169,7 +169,7 @@ void SectorProcessor::process_single_bx(int bx,
                       cfg.promoteMode7_,
                       cfg.modeQualVer_,
                       cfg.promoteMode7Sectors_,
-                      cfg.nnModel_);
+                      cfg.pbFileName_);
 
   std::map<int, TriggerPrimitiveCollection> selected_dt_map;
   std::map<int, TriggerPrimitiveCollection> selected_csc_map;

L1Trigger/L1TMuonEndCap/src/VersionControl.cc

@@ -64,7 +64,7 @@ VersionControl::VersionControl(const edm::ParameterSet& iConfig) : config_(iConf
   promoteMode7_ = spPAParams16.getParameter<bool>("PromoteMode7");
   modeQualVer_ = spPAParams16.getParameter<int>("ModeQualVer");
   promoteMode7Sectors_ = spPAParams16.getParameter<std::vector<int> >("PromoteMode7Sectors");
-  nnModel_ = spPAParams16.getParameter<std::string>("NNModel");
+  pbFileName_ = spPAParams16.getParameter<std::string>("ProtobufFileName");
 }
 
 VersionControl::~VersionControl() {}