More warnings

Author: iarspider

Alignment/CocoaModel/src/DeviationsFromFileSensor2D.cc

@@ -8,6 +8,7 @@
 #include "Alignment/CocoaModel/interface/DeviationsFromFileSensor2D.h"
 #include "Alignment/CocoaUtilities/interface/ALIFileIn.h"
 #include "Alignment/CocoaUtilities/interface/ALIUtils.h"
+#include <cassert>
 #include <cstdlib>
 #include <cmath>  // include floating-point std::abs functions
 #include <memory>
@@ -188,6 +189,7 @@ std::pair<ALIdouble, ALIdouble> DeviationsFromFileSensor2D::getDevis(ALIdouble i
     }
     ii++;
   }
+  assert(ii == theNPoints);
   if (insideMatrix == 0) {
     std::cerr << "!!EXITING intersection in Y outside matrix of deviations from file " << intersY << std::endl;
     exit(1);

Alignment/CocoaModel/src/Measurement.cc

@@ -627,8 +627,8 @@ void Measurement::copyMeas(Measurement* meas, const std::string& subsstr1, const
   theValueSimulated = new ALIdouble[theDim];
   theValueSimulated_orig = new ALIdouble[theDim];
   theValueIsSimulated = new ALIbool[theDim];
-  theValue = const_cast<ALIdouble*>(meas->value());
-  theSigma = const_cast<ALIdouble*>(meas->sigma());
+  [[clang::suppress]] theValue = const_cast<ALIdouble*>(meas->value());
+  [[clang::suppress]] theSigma = const_cast<ALIdouble*>(meas->sigma());
 
   unsigned int ii;
   for (ii = 0; ii < theDim; ii++) {

Alignment/OfflineValidation/bin/haddws.C

@@ -170,7 +170,7 @@ void haddws() {
 
 void MergeRootfile(TDirectory *target, const vector<pair<TFile *, double> > &vFileList) {
   //cout << "Target path: " << target->GetPath() << endl;
-  TString path((char *)strstr(target->GetPath(), ":"));
+  TString path(strstr(target->GetPath(), ":"));
   path.Remove(0, 2);
 
   vec_pair_it it = vFileList.begin();

Alignment/OfflineValidation/macros/loopAndPlot.C

@@ -88,7 +88,7 @@ void recurseOverKeys(TDirectory *target1, const std::vector<TString> &labels, bo
     fullPath.Remove(0, prefixToRemove.Length());
   }
 
-  TString path((char *)strstr(fullPath.Data(), ":"));
+  TString path(strstr(fullPath.Data(), ":"));
   path.Remove(0, 2);
 
   sourceFiles[0]->cd(path);