Merge pull request #48754 from iarspider/iarspider-patches-20250818-1

cmsbuild · web-flow · commit 8bc8628c14cb · 2025-08-18T15:06:17.000+02:00
[EventFilter/Utilities] Fix clang static analyzer warning
diff --git a/EventFilter/Utilities/src/GlobalEventNumber.cc b/EventFilter/Utilities/src/GlobalEventNumber.cc
@@ -4,12 +4,12 @@ namespace evf {
   namespace evtn {
 
     bool daq_board_sense(const unsigned char *p) {
-      return (*(unsigned int *)(p + FEDHeader::length + DAQ_BOARDID_OFFSET * SLINK_WORD_SIZE / 2) >>
+      return (*(const unsigned int *)(p + FEDHeader::length + DAQ_BOARDID_OFFSET * SLINK_WORD_SIZE / 2) >>
               DAQ_BOARDID_SHIFT) == DAQ_BOARDID_VALUE;
     }
 
     bool gtpe_board_sense(const unsigned char *p) {
-      return (*(unsigned int *)(p + GTPE_BOARDID_OFFSET * SLINK_WORD_SIZE / 2) >> GTPE_BOARDID_SHIFT) != 0;
+      return (*(const unsigned int *)(p + GTPE_BOARDID_OFFSET * SLINK_WORD_SIZE / 2) >> GTPE_BOARDID_SHIFT) != 0;
     }
 
     bool evm_board_sense(const unsigned char *p, size_t size) {

Original file line number	Diff line number	Diff line change
`@@ -4,12 +4,12 @@ namespace evf {`
`4`	`4`	`namespace evtn {`
`5`	`5`
`6`	`6`	`bool daq_board_sense(const unsigned char *p) {`
`7`		`- return ((unsigned int )(p + FEDHeader::length + DAQ_BOARDID_OFFSET * SLINK_WORD_SIZE / 2) >>`
	`7`	`+ return ((const unsigned int )(p + FEDHeader::length + DAQ_BOARDID_OFFSET * SLINK_WORD_SIZE / 2) >>`
`8`	`8`	`DAQ_BOARDID_SHIFT) == DAQ_BOARDID_VALUE;`
`9`	`9`	`}`
`10`	`10`
`11`	`11`	`bool gtpe_board_sense(const unsigned char *p) {`
`12`		`- return ((unsigned int )(p + GTPE_BOARDID_OFFSET * SLINK_WORD_SIZE / 2) >> GTPE_BOARDID_SHIFT) != 0;`
	`12`	`+ return ((const unsigned int )(p + GTPE_BOARDID_OFFSET * SLINK_WORD_SIZE / 2) >> GTPE_BOARDID_SHIFT) != 0;`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`bool evm_board_sense(const unsigned char *p, size_t size) {`