Merge pull request #48221 from mmusich/mm_HGCalHLTValidation

Further fixes for HGCal validation at HLT

Author: cmsbuild

RecoHGCal/TICL/plugins/SimTrackstersProducer.cc

@@ -78,6 +78,7 @@ class SimTrackstersProducer : public edm::stream::EDProducer<> {
                     const bool add = false);
 
 private:
+  void returnEmptyCollections(edm::Event& e, const int lcSize);
   std::string detector_;
   const bool doNose_ = false;
   const bool computeLocalTime_;
@@ -231,6 +232,34 @@ void SimTrackstersProducer::addTrackster(
   }
 }
 
+void SimTrackstersProducer::returnEmptyCollections(edm::Event& evt, const int lcSize) {
+  // put into the event empty collections
+  auto e_result = std::make_unique<TracksterCollection>();
+  evt.put(std::move(e_result));
+
+  auto e_result_ticlCandidates = std::make_unique<std::vector<TICLCandidate>>();
+  evt.put(std::move(e_result_ticlCandidates));
+
+  auto e_output_mask = std::make_unique<std::vector<float>>();
+  e_output_mask->resize(lcSize, 1.f);
+  evt.put(std::move(e_output_mask));
+
+  auto e_result_fromCP = std::make_unique<TracksterCollection>();
+  evt.put(std::move(e_result_fromCP), "fromCPs");
+
+  auto e_resultPU = std::make_unique<TracksterCollection>();
+  evt.put(std::move(e_resultPU), "PU");
+
+  auto e_output_mask_fromCP = std::make_unique<std::vector<float>>();
+  e_output_mask_fromCP->resize(lcSize, 1.f);
+  evt.put(std::move(e_output_mask_fromCP), "fromCPs");
+
+  auto e_cpToSc_SimTrackstersMap = std::make_unique<std::map<uint, std::vector<uint>>>();
+  evt.put(std::move(e_cpToSc_SimTrackstersMap));
+
+  return;
+}
+
 void SimTrackstersProducer::produce(edm::Event& evt, const edm::EventSetup& es) {
   auto result = std::make_unique<TracksterCollection>();
   auto output_mask = std::make_unique<std::vector<float>>();
@@ -247,13 +276,7 @@ void SimTrackstersProducer::produce(edm::Event& evt, const edm::EventSetup& es)
   // Validate input collections
   if (!layerClustersHandle.isValid() || !layerClustersTimesHandle.isValid() || !inputClusterMaskHandle.isValid()) {
     edm::LogWarning("SimTrackstersProducer") << "Missing input collections. Producing empty outputs.";
-
-    evt.put(std::move(result_ticlCandidates));
-    evt.put(std::move(output_mask));
-    evt.put(std::move(result_fromCP), "fromCPs");
-    evt.put(std::move(resultPU), "PU");
-    evt.put(std::move(output_mask_fromCP), "fromCPs");
-    evt.put(std::move(cpToSc_SimTrackstersMap));
+    this->returnEmptyCollections(evt, 0);
     return;
   }
 
@@ -268,6 +291,11 @@ void SimTrackstersProducer::produce(edm::Event& evt, const edm::EventSetup& es)
   const auto& simclusters = evt.get(simclusters_token_);
   edm::Handle<std::vector<CaloParticle>> caloParticles_h;
   evt.getByToken(caloparticles_token_, caloParticles_h);
+  if (!caloParticles_h.isValid()) {
+    edm::LogWarning("SimTrackstersProducer") << "Missing CaloParticles.";
+    this->returnEmptyCollections(evt, layerClusters.size());
+    return;
+  }
   const auto& caloparticles = *caloParticles_h;
 
   edm::Handle<MtdSimTracksterCollection> MTDSimTracksters_h;
@@ -280,7 +308,16 @@ void SimTrackstersProducer::produce(edm::Event& evt, const edm::EventSetup& es)
   evt.getByToken(trackingParticleToken_, trackingParticles_h);
   edm::Handle<std::vector<reco::Track>> recoTracks_h;
   evt.getByToken(recoTracksToken_, recoTracks_h);
-  const auto& TPtoRecoTrackMap = evt.get(associatormapStRsToken_);
+
+  //TP to reco track map
+  const auto TPtoRecoTrackMapHandle = evt.getHandle(associatormapStRsToken_);
+  if (!TPtoRecoTrackMapHandle.isValid()) {
+    edm::LogWarning("SimTrackstersProducer") << "Missing TP->RecoTrack association.";
+    this->returnEmptyCollections(evt, layerClusters.size());
+    return;
+  }
+  const auto& TPtoRecoTrackMap = *TPtoRecoTrackMapHandle;
+
   const auto& simTrackToTPMap = evt.get(associationSimTrackToTPToken_);
   const auto& recoTracks = *recoTracks_h;
 

Validation/HGCalValidation/plugins/HGCalValidator.cc

@@ -420,6 +420,8 @@ void HGCalValidator::dqmAnalyze(const edm::Event& event,
   for (const auto& token : hits_tokens_) {
     Handle<HGCRecHitCollection> hitsHandle;
     event.getByToken(token, hitsHandle);
+    if (!hitsHandle.isValid())
+      continue;
     rechitManager.addVector(*hitsHandle);
   }
 
@@ -451,6 +453,10 @@ void HGCalValidator::dqmAnalyze(const edm::Event& event,
   //Layer clusters
   edm::Handle<reco::CaloClusterCollection> clusterHandle;
   event.getByToken(layerclusters_, clusterHandle);
+
+  if (!clusterHandle.isValid())
+    return;
+
   const reco::CaloClusterCollection& clusters = *clusterHandle;
 
   std::vector<edm::Handle<TracksterToTracksterMap>> tracksterToTracksterMapsHandles;