Skip to content

Commit 94bd889

Browse files
committed
avoid useless duplication of modules in ALCARECOPromptCalibProdSiStripHitEfficiency and ALCARECOPromptCalibProdSiStripGains
1 parent 1872208 commit 94bd889

File tree

2 files changed

+10
-25
lines changed

2 files changed

+10
-25
lines changed

Calibration/TkAlCaRecoProducers/python/ALCARECOPromptCalibProdSiStripGains_cff.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,9 @@
6363

6464
# refit and BS can be dropped if done together with RECO.
6565
# track filter can be moved in acalreco if no otehr users
66+
from RecoTracker.MeasurementDet.MeasurementTrackerEventProducer_cfi import *
6667
ALCARECOTrackFilterRefit = cms.Sequence(ALCARECOCalibrationTracks +
68+
MeasurementTrackerEvent +
6769
offlineBeamSpot +
6870
ALCARECOCalibrationTracksRefit )
6971

Calibration/TkAlCaRecoProducers/python/ALCARECOPromptCalibProdSiStripHitEfficiency_cff.py

Lines changed: 8 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import FWCore.ParameterSet.Config as cms
2+
from Calibration.TkAlCaRecoProducers.ALCARECOPromptCalibProdSiStripGains_cff import ALCARECOCalibrationTracks,ALCARECOCalibrationTracksRefit
23

34
# ------------------------------------------------------------------------------
45
# configure a filter to run only on the events selected by TkAlMinBias AlcaReco
@@ -9,19 +10,6 @@
910
TriggerResultsTag = ("TriggerResults","","RECO")
1011
)
1112

12-
# ------------------------------------------------------------------------------
13-
# This is the sequence for track refitting of the track saved by SiStripCalMinBias
14-
# to have access to transient objects produced during RECO step and not saved
15-
from Alignment.CommonAlignmentProducer.AlignmentTrackSelector_cfi import *
16-
ALCARECOMonitoringTracks = AlignmentTrackSelector.clone(
17-
# src = 'generalTracks',
18-
src = 'ALCARECOSiStripCalMinBias',
19-
filter = True,
20-
applyBasicCuts = True,
21-
ptMin = 0.8,
22-
nHitMin = 6,
23-
chi2nMax = 10.)
24-
2513
# FIXME: the beam-spot should be kept in the AlCaReco (if not already there) and dropped from here
2614
from RecoVertex.BeamSpotProducer.BeamSpot_cff import *
2715
from RecoTracker.IterativeTracking.InitialStep_cff import *
@@ -30,18 +18,13 @@
3018
from DQM.SiStripCommon.TkHistoMap_cff import *
3119
from RecoTracker.MeasurementDet.MeasurementTrackerEventProducer_cfi import *
3220

33-
ALCARECOMonitoringTracksRefit = TrackRefitter.clone(
34-
src = "ALCARECOMonitoringTracks",
35-
NavigationSchool = cms.string("")
36-
)
37-
3821
# ------------------------------------------------------------------------------
3922
# refit and BS can be dropped if done together with RECO.
4023
# track filter can be moved in acalreco if no otehr users
41-
ALCARECOTrackFilterRefit = cms.Sequence(ALCARECOMonitoringTracks +
42-
MeasurementTrackerEvent +
43-
offlineBeamSpot +
44-
ALCARECOMonitoringTracksRefit)
24+
ALCARECOTrackFilterRefitForSiStripHitEff = cms.Sequence(ALCARECOCalibrationTracks +
25+
MeasurementTrackerEvent +
26+
offlineBeamSpot +
27+
ALCARECOCalibrationTracksRefit)
4528

4629
# ------------------------------------------------------------------------------
4730
# This is the module actually doing the calibration
@@ -52,8 +35,8 @@
5235
addLumi = True,
5336
commonMode = "siStripDigis:CommonMode",
5437
addCommonMode= False,
55-
combinatorialTracks = "ALCARECOMonitoringTracksRefit",
56-
trajectories = "ALCARECOMonitoringTracksRefit",
38+
combinatorialTracks = "ALCARECOCalibrationTracksRefit",
39+
trajectories = "ALCARECOCalibrationTracksRefit",
5740
siStripClusters = "siStripClusters",
5841
siStripDigis = "siStripDigis",
5942
trackerEvent = "MeasurementTrackerEvent",
@@ -90,6 +73,6 @@
9073
# The actual sequence
9174
seqALCARECOPromptCalibProdSiStripHitEfficiency = cms.Sequence(
9275
ALCARECOCalMinBiasFilterForSiStripHitEff *
93-
ALCARECOTrackFilterRefit *
76+
ALCARECOTrackFilterRefitForSiStripHitEff *
9477
ALCARECOSiStripHitEff *
9578
MEtoEDMConvertSiStripHitEff)

0 commit comments

Comments
 (0)