Code check

Author: Sunanda

Geometry/HGCalCommonData/interface/HGCalDDDConstants.h

@@ -222,7 +222,8 @@ class HGCalDDDConstants {
   std::pair<double, double> waferParameters(bool reco) const;
   std::pair<double, double> waferPosition(int wafer, bool reco) const;
   std::pair<double, double> waferPosition(int lay, int waferU, int waferV, bool reco, bool debug) const;
-  std::pair<double, double> waferPositionWithCshift(int lay, int waferU, int waferV, bool norot, bool reco, bool debug) const;
+  std::pair<double, double> waferPositionWithCshift(
+      int lay, int waferU, int waferV, bool norot, bool reco, bool debug) const;
   inline unsigned int waferFileSize() const { return hgpar_->waferInfoMap_.size(); }
   int waferFileIndex(unsigned int kk) const;
   std::tuple<int, int, int, int> waferFileInfo(unsigned int kk) const;

Geometry/HGCalCommonData/interface/HGCalWaferMask.h

@@ -68,7 +68,7 @@ class HGCalWaferMask {
                                                          const double& xpos,
                                                          const double& ypos,
                                                          const bool& v17,
-							 const bool& air = false);
+                                                         const bool& air = false);
 
   static std::array<double, 4> maskCut(
       const int& part, const int& place, const double& waferSize, const double& offset, const bool& v17OrLess);

Geometry/HGCalCommonData/plugins/DDHGCalWaferPartialRotated.cc

@@ -128,8 +128,8 @@ void DDHGCalWaferPartialRotated::execute(DDCompactView& cpv) {
     for (unsigned int m = 0; m < placementIndex_.size(); ++m) {
       // First the mother
       std::string mother = parentName + placementIndexTags_[m] + waferTag_ + tags_[k];
-      std::vector<std::pair<double, double> > wxy =
-          HGCalWaferMask::waferXY(partialTypes_[k], placementIndex_[m], waferSize_, 0.0, 0.0, 0.0, (waferMode_ > 0), true);
+      std::vector<std::pair<double, double> > wxy = HGCalWaferMask::waferXY(
+          partialTypes_[k], placementIndex_[m], waferSize_, 0.0, 0.0, 0.0, (waferMode_ > 0), true);
       std::vector<double> xM, yM;
       for (unsigned int i = 0; i < (wxy.size() - 1); ++i) {
         xM.emplace_back(wxy[i].first);

Geometry/HGCalCommonData/plugins/dd4hep/DDHGCalWaferPartialRotated.cc

@@ -88,7 +88,7 @@ static long algorithm(dd4hep::Detector& /* description */, cms::DDParsingContext
       // First the mother
       std::string mother = parentName + placementIndexTags[m] + waferTag + tags[k];
       std::vector<std::pair<double, double>> wxy =
-	HGCalWaferMask::waferXY(partialTypes[k], placementIndex[m], waferSize, 0.0, 0.0, 0.0, (waferMode > 0), true);
+          HGCalWaferMask::waferXY(partialTypes[k], placementIndex[m], waferSize, 0.0, 0.0, 0.0, (waferMode > 0), true);
       std::vector<double> xM, yM;
       for (unsigned int i = 0; i < (wxy.size() - 1); ++i) {
         xM.emplace_back(wxy[i].first);

Geometry/HGCalCommonData/src/HGCalDDDConstants.cc

@@ -933,7 +933,7 @@ std::pair<float, float> HGCalDDDConstants::locateCell(int zside,
   int indx = HGCalWaferIndex::waferIndex(lay, waferU, waferV);
   auto itr = hgpar_->typesInLayers_.find(indx);
   int type = ((itr == hgpar_->typesInLayers_.end()) ? 2 : hgpar_->waferTypeL_[itr->second]);
-  int fineCoarse = (type == HGCSiliconDetId::HGCalHD120) || (type == HGCSiliconDetId::HGCalHD200)? 0 : 1;
+  int fineCoarse = (type == HGCSiliconDetId::HGCalHD120) || (type == HGCSiliconDetId::HGCalHD200) ? 0 : 1;
   int layertype = layerType(lay);
   bool rotx = (norot) ? false : (layertype == HGCalTypes::WaferCenterR);
   if (debug) {
@@ -1842,7 +1842,8 @@ void HGCalDDDConstants::waferFromPosition(const double x,
                                         << " place " << place << " part " << part;
       }
     }
-    bool fineCoarse = ((celltype == HGCSiliconDetId::HGCalHD120) || (celltype == HGCSiliconDetId::HGCalHD200))? 0: 1;
+    bool fineCoarse =
+        ((celltype == HGCSiliconDetId::HGCalHD120) || (celltype == HGCSiliconDetId::HGCalHD200)) ? false : true;
     cellHex(xx, yy, fineCoarse, place, part, cellU, cellV, extend, debug);
     wt = ((((celltype == HGCSiliconDetId::HGCalHD120) || (celltype == HGCSiliconDetId::HGCalHD200)) &&
            (hgpar_->useSimWt_ > 0))
@@ -1931,7 +1932,8 @@ std::pair<double, double> HGCalDDDConstants::waferPosition(
   return xy0;
 }
 
-std::pair<double, double> HGCalDDDConstants::waferPositionWithCshift(int lay, int waferU, int waferV, bool norot, bool reco, bool debug) const{
+std::pair<double, double> HGCalDDDConstants::waferPositionWithCshift(
+    int lay, int waferU, int waferV, bool norot, bool reco, bool debug) const {
   auto xy_noshift = waferPositionNoRot(lay, waferU, waferV, reco, debug);
   double x = xy_noshift.first;
   double y = xy_noshift.second;
@@ -1955,7 +1957,6 @@ std::pair<double, double> HGCalDDDConstants::waferPositionWithCshift(int lay, in
   return (rotx ? getXY(lay, x, y, false) : std::make_pair(x, y));
 }
 
-
 int HGCalDDDConstants::waferFileIndex(unsigned int kk) const {
   if (kk < hgpar_->waferInfoMap_.size()) {
     auto itr = hgpar_->waferInfoMap_.begin();

Geometry/HGCalCommonData/src/HGCalWaferMask.cc

@@ -1452,7 +1452,7 @@ std::vector<std::pair<double, double> > HGCalWaferMask::waferXY(const int& part,
                                                                 const double& xpos,
                                                                 const double& ypos,
                                                                 const bool& v17OrLess,
-								const bool& air) {
+                                                                const bool& air) {
   std::vector<std::pair<double, double> > xy;
   // Good for V17 version and uses partial wafer type & placement index
 #ifdef EDM_ML_DEBUG