Skip to content

Commit 9d6d370

Browse files
authored
Merge pull request #47994 from fwyzard/replace_MPI_c++_bindings
Remove the use of deprecated MPI C++ bindings
2 parents b77beb9 + 384102a commit 9d6d370

File tree

3 files changed

+16
-11
lines changed

3 files changed

+16
-11
lines changed

GeneratorInterface/SherpaInterface/src/SherpaHadronizer.cc

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,14 +205,17 @@ SherpaHadronizer::SherpaHadronizer(const edm::ParameterSet &params)
205205
isInitialized = false;
206206
//initialization of Sherpa moved to initializeForInternalPartons
207207
#ifdef USING__MPI
208-
MPI::Init();
208+
// FIXME this should be replaced with a call to the MPIService
209+
int argc = 0;
210+
char **argv = nullptr;
211+
MPI_Init(&argc, &argv);
209212
#endif
210213
}
211214

212215
SherpaHadronizer::~SherpaHadronizer() {
213216
Generator->~Sherpa();
214217
#ifdef USING__MPI
215-
MPI::Finalize();
218+
MPI_Finalize();
216219
#endif
217220
}
218221

HeterogeneousCore/CUDACore/test/mpiCudaGeneric.cu

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ int main(int argc, char *argv[]) {
237237

238238
if (help) {
239239
printHelp();
240-
MPI::Finalize();
240+
MPI_Finalize();
241241
exit(0);
242242
}
243243
setupMPIAndVectors(mpiData, user);
@@ -276,7 +276,7 @@ int main(int argc, char *argv[]) {
276276
if (!mpiData.rank)
277277
printTable(allTiming, printStander);
278278

279-
MPI::Finalize();
279+
MPI_Finalize();
280280
return 0;
281281
}
282282
const std::vector<int> chooseFunction(int toInteger) {
@@ -341,8 +341,8 @@ void randomGenerator(float *vect) {
341341
}
342342
}
343343
void setupMPIAndVectors(MPIData &mpiData, UserChoises &user) {
344-
mpiData.num_procs = MPI::COMM_WORLD.Get_size(); //get total size of processes.
345-
mpiData.rank = MPI::COMM_WORLD.Get_rank(); //get each process number.
344+
MPI_Comm_size(MPI_COMM_WORLD, &mpiData.num_procs);
345+
MPI_Comm_rank(MPI_COMM_WORLD, &mpiData.rank);
346346

347347
user.sizeVectorBytes = sizeVector * sizeof(float); //get size in byte for vectors.
348348

@@ -1298,7 +1298,9 @@ bool saveToFile(const std::string &name, const Timing &timing) {
12981298
return 1;
12991299
}
13001300
void printHelp(void) {
1301-
int rank = MPI::COMM_WORLD.Get_rank();
1301+
int rank;
1302+
MPI_Comm_rank(MPI_COMM_WORLD, &rank);
1303+
13021304
if (!rank) {
13031305
std::cout << "\n\n\t**************************************\n";
13041306
std::cout << "\t* This is a Help for Command Opitions*";

HeterogeneousCore/MPICore/test/testMPI.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -151,9 +151,9 @@ int main(int argc, char* argv[]) {
151151

152152
MPIData mpiInputs; //greate object from structur to pass into MPI functios.
153153

154-
MPI_Init(&argc, &argv); //initialize communicator environment.
155-
mpiInputs.num_procs = MPI::COMM_WORLD.Get_size(); //get total size of processes.
156-
mpiInputs.rank = MPI::COMM_WORLD.Get_rank(); //get each process number.
154+
MPI_Init(&argc, &argv); //initialize communicator environment.
155+
MPI_Comm_rank(MPI_COMM_WORLD, &mpiInputs.rank); //get each process number.
156+
MPI_Comm_size(MPI_COMM_WORLD, &mpiInputs.num_procs); //get total size of processes.
157157

158158
mpiInputs.input1.resize(size); //initialize size.
159159
mpiInputs.input2.resize(size);
@@ -212,7 +212,7 @@ int main(int argc, char* argv[]) {
212212
compare(timing, choices, userChoices, runNumber);
213213
}
214214

215-
MPI::Finalize();
215+
MPI_Finalize();
216216

217217
return 0;
218218
}

0 commit comments

Comments
 (0)