Revert some changes that fail assertion

Author: iarspider

CalibCalorimetry/CaloTPG/plugins/CaloTPGTranscoderULUTs.cc

@@ -155,7 +155,8 @@ CaloTPGTranscoderULUTs::ReturnType CaloTPGTranscoderULUTs::produce(const CaloTPG
 
   const auto& lutMetadata = iRecord.get(lutMetadataToken);
   const auto& theTrigTowerGeometry = iRecord.get(theTrigTowerGeometryToken);
-  const auto& topo = iRecord.get(topoToken);
+  const auto& topoRecord = iRecord.getRecord<HcalLutMetadataRcd>();
+  const auto& topo = topoRecord.get(topoToken);
 
   HcalLutMetadata fullLut{lutMetadata};
   fullLut.setTopo(&topo);

CalibCalorimetry/HcalTPGEventSetup/src/HcalTPGCoderULUT.cc

@@ -160,7 +160,8 @@ HcalTPGCoderULUT::ReturnType HcalTPGCoderULUT::produce(const HcalTPGRecord& iRec
   auto host = holder_.makeOrGet([]() { return new HostType; });
 
   const auto& topo = iRecord.get(topoToken_);
-  const auto& delay = iRecord.get(delayToken_);
+  const auto& delayRcd = iRecord.getRecord<HcalDbRecord>();
+  const auto& delay = delayRcd.get(delayToken_);
   if (read_Ascii_ || read_XML_) {
     buildCoder(&topo, &delay, host.get());
   } else {

CalibTracker/SiPhase2TrackerESProducers/plugins/SiPhase2OuterTrackerFakeLorentzAngleESSource.cc

@@ -69,13 +69,13 @@ namespace fakeOTLA {
 
 std::unique_ptr<SiPhase2OuterTrackerLorentzAngle> SiPhase2OuterTrackerFakeLorentzAngleESSource::produceOTLA(
     const SiPhase2OuterTrackerLorentzAngleRcd& rcd) {
-  const auto& geomDet = rcd.get(m_geomDetToken);
+  const auto& geomDet = rcd.getRecord<TrackerTopologyRcd>().get(m_geomDetToken);
   return fakeOTLA::produceRecord<SiPhase2OuterTrackerLorentzAngle>(LAvalue_, geomDet);
 }
 
 std::unique_ptr<SiPhase2OuterTrackerLorentzAngle> SiPhase2OuterTrackerFakeLorentzAngleESSource::produceOTSimLA(
     const SiPhase2OuterTrackerLorentzAngleSimRcd& rcd) {
-  const auto& geomDet = rcd.get(m_geomDetToken);
+  const auto& geomDet = rcd.getRecord<TrackerTopologyRcd>().get(m_geomDetToken);
   return fakeOTLA::produceRecord<SiPhase2OuterTrackerLorentzAngle>(LAvalue_, geomDet);
 }
 

CalibTracker/SiStripESProducers/plugins/fake/SiStripBackPlaneCorrectionFakeESSource.cc

@@ -65,7 +65,8 @@ SiStripBackPlaneCorrectionFakeESSource::ReturnType SiStripBackPlaneCorrectionFak
     const SiStripBackPlaneCorrectionRcd& iRecord) {
   using namespace edm::es;
 
-  const auto& geomDet = iRecord.get(m_geomDetToken);
+  const auto& geomDetRcd = iRecord.getRecord<TrackerTopologyRcd>();
+  const auto& geomDet = geomDetRcd.get(m_geomDetToken);
   const auto& tTopo = iRecord.get(m_tTopoToken);
 
   auto backPlaneCorrection = std::make_unique<SiStripBackPlaneCorrection>();

CalibTracker/SiStripESProducers/plugins/fake/SiStripHashedDetIdFakeESSource.cc

@@ -31,7 +31,8 @@ std::unique_ptr<SiStripHashedDetId> SiStripHashedDetIdFakeESSource::produce(cons
   edm::LogVerbatim("HashedDetId") << "[SiStripHashedDetIdFakeESSource::" << __func__ << "]"
                                   << " Building \"fake\" hashed DetId map from IdealGeometry";
 
-  const auto& geomDet = record.get(geomDetToken_);
+  const auto& geomDetRcd = record.getRecord<TrackerDigiGeometryRecord>();
+  const auto& geomDet = geomDetRcd.get(geomDetToken_);
 
   const std::vector<uint32_t> dets = TrackerGeometryUtils::getSiStripDetIds(geomDet);
   edm::LogVerbatim("HashedDetId") << "[SiStripHashedDetIdFakeESSource::" << __func__ << "]"

CalibTracker/SiStripESProducers/plugins/fake/SiStripLorentzAngleFakeESSource.cc

@@ -183,7 +183,8 @@ SiStripLorentzAngleFakeESSource::ReturnType SiStripLorentzAngleFakeESSource::pro
     const SiStripLorentzAngleRcd& iRecord) {
   using namespace edm::es;
 
-  const auto& geomDet = iRecord.get(m_geomDetToken);
+  const auto& geomDetRcd = iRecord.getRecord<TrackerTopologyRcd>();
+  const auto& geomDet = geomDetRcd.get(m_geomDetToken);
   const auto& tTopo = iRecord.get(m_tTopoToken);
 
   auto lorentzAngle = std::make_unique<SiStripLorentzAngle>();

RecoLocalCalo/HcalRecAlgos/plugins/HcalChannelPropertiesEP.cc

@@ -74,7 +74,7 @@ class HcalChannelPropertiesEP : public edm::ESProducer {
     const HcalDbService& cond = dbRecord.get(condToken_);
     const HcalRecoParams& params = rcd.get(myParamsToken_);
     const HcalSeverityLevelComputer& severity = rcd.get(sevToken_);
-    const HcalChannelQuality& qual = rcd.get(qualToken_);
+    const HcalChannelQuality& qual = dbRecord.get(qualToken_);
     const CaloGeometry& geom = rcd.get(geomToken_);
 
     // HcalTopology is taken from "params" created by the "produce1" method