add plot to monitor candidate with no track / tracskter

Author: AuroraPerego

Validation/HGCalValidation/interface/TICLCandidateValidator.h

@@ -115,6 +115,23 @@ struct TICLCandidateValidatorHistograms {
   std::vector<dqm::reco::MonitorElement*> h_neut_candidate_charge;
   std::vector<dqm::reco::MonitorElement*> h_neut_candidate_pdgId;
   std::vector<dqm::reco::MonitorElement*> h_neut_candidate_partType;
+
+  std::vector<dqm::reco::MonitorElement*> h_neut_energy_noTrackster;
+  std::vector<dqm::reco::MonitorElement*> h_neut_pt_noTrackster;
+  std::vector<dqm::reco::MonitorElement*> h_neut_eta_noTrackster;
+  std::vector<dqm::reco::MonitorElement*> h_neut_phi_noTrackster;
+  std::vector<dqm::reco::MonitorElement*> h_chg_energy_noTrack;
+  std::vector<dqm::reco::MonitorElement*> h_chg_pt_noTrack;
+  std::vector<dqm::reco::MonitorElement*> h_chg_eta_noTrack;
+  std::vector<dqm::reco::MonitorElement*> h_chg_phi_noTrack;
+  std::vector<dqm::reco::MonitorElement*> h_chg_energy_noGoodTrack;
+  std::vector<dqm::reco::MonitorElement*> h_chg_pt_noGoodTrack;
+  std::vector<dqm::reco::MonitorElement*> h_chg_eta_noGoodTrack;
+  std::vector<dqm::reco::MonitorElement*> h_chg_phi_noGoodTrack;
+  std::vector<dqm::reco::MonitorElement*> h_chg_energy_noTrackster;
+  std::vector<dqm::reco::MonitorElement*> h_chg_pt_noTrackster;
+  std::vector<dqm::reco::MonitorElement*> h_chg_eta_noTrackster;
+  std::vector<dqm::reco::MonitorElement*> h_chg_phi_noTrackster;
 };
 
 class TICLCandidateValidator {

Validation/HGCalValidation/python/hgcalPlots.py

@@ -1836,7 +1836,6 @@
     for var in ["pt", "energy", "eta", "phi"]:
         for cut in ["track", "pid", "energy"]:
             if cut=="track" and ct in ["neutral_hadrons", "neutral_pions", "photons"]: continue
-            #options = (_common_eff_fake | _xminmaxEn) if var=="energy" else ( (_common_eff_fake | _xminmaxPt) if var=="pt" else _common_eff_fake)
             cand_eff_plots.extend([Plot("eff_"+ct+"_"+cut+"_"+var, title=cut + " - efficiency for "+ct.replace("_", " ")+" vs "+var, ytitle="Efficiency", **_common_eff_fake)])
     _all_cand_eff_plots.append(cand_eff_plots)
 
@@ -1855,7 +1854,6 @@
     for var in ["pt", "energy", "eta", "phi"]:
         for cut in ["track", "pid", "energy", "total"]:
             if cut=="track" and ct in ["neutral_hadrons", "neutral_pions", "photons"]: continue
-            #options = (_common_eff_fake | _xminmaxEn) if var=="energy" else ( (_common_eff_fake | _xminmaxPt) if var=="pt" else _common_eff_fake)
             cand_fake_plots.extend([Plot("fake_"+ct+"_"+cut+"_"+var, title=cut + " - fake rate for "+ct.replace("_", " ")+" vs "+var, ytitle="Fake rate", **_common_eff_fake)])
     _all_cand_fake_plots.append(cand_fake_plots)
 
@@ -1868,11 +1866,21 @@
             cand_fake_plots.extend([Plot("num_fake_"+cut+"_cand_vs_"+var+"_"+ct, title=cut + " - number of fakes for "+ct.replace("_", " ")+" vs "+var, ytitle="Fake number", **_common)])
     _all_cand_fakeNum_plots.append(cand_fake_plots)
 
+#association with track/tracksters
+_all_cand_TkTsAss_plots = []
+for ct in cand_type:
+    cand_ass_plots = []
+    for var in ["pt", "energy", "eta", "phi"]:
+        for cut in ["noTrack", "noGoodTrack", "noTrackster"]:
+            if cut in ["noTrack", "noGoodTrack"] and ct in ["neutral_hadrons", "neutral_pions", "photons"]: continue
+            cand_ass_plots.extend([Plot(cut+"_cand_vs_"+var+"_"+ct, title="number of "+ct.replace("_", " ")+" with "+cut+" vs "+var, ytitle="Number of candidates", **_common)])
+    _all_cand_TkTsAss_plots.append(cand_ass_plots)
+
 _allCandidatesPlots = [[],[],[],[],[],[]]
 for i in range(3):
-    _allCandidatesPlots[i].extend([PlotGroup(cand_type[i]+"_type", _all_cand_type_plots[i], ncols=2), PlotGroup(cand_type[i]+"_kin", _all_cand_ene_plots[i], ncols=3), PlotGroup(cand_type[i]+"_eff", _all_cand_eff_plots[i], ncols=3), PlotGroup(cand_type[i]+"_effMultiplicity", _all_cand_effNum_plots[i], ncols=3), PlotGroup(cand_type[i]+"_fake", _all_cand_fake_plots[i], ncols=4), PlotGroup(cand_type[i]+"_fakeMultiplicity", _all_cand_fakeNum_plots[i], ncols=4)])
+    _allCandidatesPlots[i].extend([PlotGroup(cand_type[i]+"_type", _all_cand_type_plots[i], ncols=2), PlotGroup(cand_type[i]+"_kin", _all_cand_ene_plots[i], ncols=3), PlotGroup(cand_type[i]+"_eff", _all_cand_eff_plots[i], ncols=3), PlotGroup(cand_type[i]+"_effMultiplicity", _all_cand_effNum_plots[i], ncols=3), PlotGroup(cand_type[i]+"_fake", _all_cand_fake_plots[i], ncols=4), PlotGroup(cand_type[i]+"_fakeMultiplicity", _all_cand_fakeNum_plots[i], ncols=4), PlotGroup(cand_type[i]+"_NoTrackTracksterAssoc", _all_cand_TkTsAss_plots[i], ncols=3)])
 for i in range(3,6):
-    _allCandidatesPlots[i].extend([PlotGroup(cand_type[i]+"_type", _all_cand_type_plots[i], ncols=2), PlotGroup(cand_type[i]+"_kin", _all_cand_ene_plots[i], ncols=3), PlotGroup(cand_type[i]+"_eff", _all_cand_eff_plots[i], ncols=2), PlotGroup(cand_type[i]+"_effMultiplicity", _all_cand_effNum_plots[i], ncols=2), PlotGroup(cand_type[i]+"_fake", _all_cand_fake_plots[i], ncols=3), PlotGroup(cand_type[i]+"_fakeMultiplicity", _all_cand_fakeNum_plots[i], ncols=3)])
+    _allCandidatesPlots[i].extend([PlotGroup(cand_type[i]+"_type", _all_cand_type_plots[i], ncols=2), PlotGroup(cand_type[i]+"_kin", _all_cand_ene_plots[i], ncols=3), PlotGroup(cand_type[i]+"_eff", _all_cand_eff_plots[i], ncols=2), PlotGroup(cand_type[i]+"_effMultiplicity", _all_cand_effNum_plots[i], ncols=2), PlotGroup(cand_type[i]+"_fake", _all_cand_fake_plots[i], ncols=3), PlotGroup(cand_type[i]+"_fakeMultiplicity", _all_cand_fakeNum_plots[i], ncols=3), PlotGroup(cand_type[i]+"_NoTrackTracksterAssoc", _all_cand_TkTsAss_plots[i], ncols=1)])
 
 #--------------------------------------------------------------------------------------------
 # SIMHITS, DIGIS, RECHITS

Validation/HGCalValidation/src/TICLCandidateValidator.cc

@@ -161,6 +161,31 @@ void TICLCandidateValidator::bookCandidatesHistos(DQMStore::IBooker& ibook,
                      50,
                      -3.14159,
                      3.14159));
+
+    histograms.h_neut_energy_noTrackster.push_back(
+        ibook.book1D("noTrackster_cand_vs_energy_" + neutrals[i],
+                     neutrals[i] + " simCandidates without trackster energy;E (GeV)",
+                     50,
+                     0,
+                     500));
+    histograms.h_neut_pt_noTrackster.push_back(
+        ibook.book1D("noTrackster_cand_vs_pt_" + neutrals[i],
+                     neutrals[i] + " simCandidates without trackster pT;p_{T} (GeV)",
+                     50,
+                     0,
+                     200));
+    histograms.h_neut_eta_noTrackster.push_back(
+        ibook.book1D("noTrackster_cand_vs_eta_" + neutrals[i],
+                     neutrals[i] + " simCandidates without trackster eta;#eta (GeV)",
+                     50,
+                     -3,
+                     3));
+    histograms.h_neut_phi_noTrackster.push_back(
+        ibook.book1D("noTrackster_cand_vs_phi_" + neutrals[i],
+                     neutrals[i] + " simCandidates without trackster phi;#phi (GeV)",
+                     50,
+                     -3.14159,
+                     3.14159));
   }
   // charged: electron, muon, hadron
   const std::vector<std::string> charged{"electrons", "muons", "charged_hadrons"};
@@ -313,6 +338,68 @@ void TICLCandidateValidator::bookCandidatesHistos(DQMStore::IBooker& ibook,
                      50,
                      -3.14159,
                      3.14159));
+
+    histograms.h_chg_energy_noTrack.push_back(ibook.book1D(
+        "noTrack_cand_vs_energy_" + charged[i], charged[i] + " simCandidates without track energy;E (GeV)", 50, 0, 500));
+    histograms.h_chg_pt_noTrack.push_back(ibook.book1D(
+        "noTrack_cand_vs_pt_" + charged[i], charged[i] + " simCandidates without track pT;p_{T} (GeV)", 50, 0, 200));
+    histograms.h_chg_eta_noTrack.push_back(ibook.book1D(
+        "noTrack_cand_vs_eta_" + charged[i], charged[i] + " simCandidates without track eta;#eta (GeV)", 50, -3, 3));
+    histograms.h_chg_phi_noTrack.push_back(ibook.book1D("noTrack_cand_vs_phi_" + charged[i],
+                                                        charged[i] + " simCandidates without track phi;#phi (GeV)",
+                                                        50,
+                                                        -3.14159,
+                                                        3.14159));
+
+    histograms.h_chg_energy_noGoodTrack.push_back(
+        ibook.book1D("noGoodTrack_cand_vs_energy_" + charged[i],
+                     charged[i] + " simCandidates without good track energy;E (GeV)",
+                     50,
+                     0,
+                     500));
+    histograms.h_chg_pt_noGoodTrack.push_back(
+        ibook.book1D("noGoodTrack_cand_vs_pt_" + charged[i],
+                     charged[i] + " simCandidates without good track pT;p_{T} (GeV)",
+                     50,
+                     0,
+                     200));
+    histograms.h_chg_eta_noGoodTrack.push_back(
+        ibook.book1D("noGoodTrack_cand_vs_eta_" + charged[i],
+                     charged[i] + " simCandidates without good track eta;#eta (GeV)",
+                     50,
+                     -3,
+                     3));
+    histograms.h_chg_phi_noGoodTrack.push_back(
+        ibook.book1D("noGoodTrack_cand_vs_phi_" + charged[i],
+                     charged[i] + " simCandidates without good track phi;#phi (GeV)",
+                     50,
+                     -3.14159,
+                     3.14159));
+
+    histograms.h_chg_energy_noTrackster.push_back(
+        ibook.book1D("noTrackster_cand_vs_energy_" + charged[i],
+                     charged[i] + " simCandidates without trackster energy;E (GeV)",
+                     50,
+                     0,
+                     500));
+    histograms.h_chg_pt_noTrackster.push_back(
+        ibook.book1D("noTrackster_cand_vs_pt_" + charged[i],
+                     charged[i] + " simCandidates without trackster pT;p_{T} (GeV)",
+                     50,
+                     0,
+                     200));
+    histograms.h_chg_eta_noTrackster.push_back(
+        ibook.book1D("noTrackster_cand_vs_eta_" + charged[i],
+                     charged[i] + " simCandidates without trackster eta;#eta (GeV)",
+                     50,
+                     -3,
+                     3));
+    histograms.h_chg_phi_noTrackster.push_back(
+        ibook.book1D("noTrackster_cand_vs_phi_" + charged[i],
+                     charged[i] + " simCandidates without trackster phi;#phi (GeV)",
+                     50,
+                     -3.14159,
+                     3.14159));
   }
 }
 
@@ -392,13 +479,28 @@ void TICLCandidateValidator::fillCandidateHistos(const edm::Event& event,
      * 211 (type 4) becomes 2
      */
 
+    // no track
+    if (simCand.trackPtrs().empty()) {
+      histograms.h_chg_energy_noTrack[index]->Fill(simCand.rawEnergy());
+      histograms.h_chg_pt_noTrack[index]->Fill(simCand.pt());
+      histograms.h_chg_eta_noTrack[index]->Fill(simCand.eta());
+      histograms.h_chg_phi_noTrack[index]->Fill(simCand.phi());
+      continue;
+    }
+
     std::vector<int32_t> simCandTrackIdx;
     for (const auto& track : simCand.trackPtrs()) {
       if (cutTk(*(simCand.trackPtr().get())))
         simCandTrackIdx.push_back(track.get() - firstTrack);
     }
-    if (simCandTrackIdx.empty())
+    if (simCandTrackIdx.empty()) {
+      // no track passing cuts
+      histograms.h_chg_energy_noGoodTrack[index]->Fill(simCand.rawEnergy());
+      histograms.h_chg_pt_noGoodTrack[index]->Fill(simCand.pt());
+      histograms.h_chg_eta_noGoodTrack[index]->Fill(simCand.eta());
+      histograms.h_chg_phi_noGoodTrack[index]->Fill(simCand.phi());
       continue;
+    }
 
     // +1 to all denominators
     histograms.h_den_chg_energy_candidate[index]->Fill(simCand.rawEnergy());
@@ -418,8 +520,13 @@ void TICLCandidateValidator::fillCandidateHistos(const edm::Event& event,
       cand_idx = min_elem->index();
     }
     // no reco associated to sim
-    if (cand_idx == -1)
+    if (cand_idx == -1) {
+      histograms.h_chg_energy_noTrackster[index]->Fill(simCand.rawEnergy());
+      histograms.h_chg_pt_noTrackster[index]->Fill(simCand.pt());
+      histograms.h_chg_eta_noTrackster[index]->Fill(simCand.eta());
+      histograms.h_chg_phi_noTrackster[index]->Fill(simCand.phi());
       continue;
+    }
 
     auto& recoCand = TICLCandidates[cand_idx];
     if (isTICLv5_) {
@@ -498,8 +605,13 @@ void TICLCandidateValidator::fillCandidateHistos(const edm::Event& event,
     }
 
     // no reco associated to sim
-    if (cand_idx == -1)
+    if (cand_idx == -1) {
+      histograms.h_neut_energy_noTrackster[index]->Fill(simCand.rawEnergy());
+      histograms.h_neut_pt_noTrackster[index]->Fill(simCand.pt());
+      histograms.h_neut_eta_noTrackster[index]->Fill(simCand.eta());
+      histograms.h_neut_phi_noTrackster[index]->Fill(simCand.phi());
       continue;
+    }
 
     auto& recoCand = TICLCandidates[cand_idx];
     if (isTICLv5_) {