Skip to content

Commit aec8400

Browse files
authored
Merge pull request #48687 from bfonta/test/new_offset_many_procmods
Add a relval test for the NGT scouting menu with multiple process modifiers
2 parents fbd8ee4 + 100d149 commit aec8400

File tree

4 files changed

+26
-8
lines changed

4 files changed

+26
-8
lines changed

Configuration/PyReleaseValidation/README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,9 @@ The offsets currently in use are:
6767
* 0.758 HLT phase-2 timing menu ticl_barrel variant
6868
* 0.759: HLT phase-2 timing menu, with NANO:@Phase2HLT
6969
* 0.77: HLT phase-2 NGT Scouting menu
70-
* 0.771: HLT phase-2 NGT Scouting menu, with NANO:@NGTScouting
70+
* 0.771: HLT phase-2 NGT Scouting menu, Alpaka, TICL-v5, TICL-Barrel
71+
* 0.772: HLT phase-2 NGT Scouting menu, with NANO:@NGTScouting
72+
* 0.773: HLT phase-2 NGT Scouting menu, with NANO:@NGTScoutingVal
7173
* 0.778 L3 Tracker Muons reconstruction Outside-In first, HLT Muon NanoAOD
7274
* 0.78: Complete L1 workflow
7375
* 0.781: Complete L1 workflow, producing FEVT and NANO output L1/P2GT objects
@@ -122,4 +124,4 @@ The offsets currently in use are:
122124
* 0.113: Activate OuterTracker inefficiency (PS-p: bias rails inefficiency; PS-s and SS: 5% bad strips)
123125
* 0.114: Activate OuterTracker inefficiency (PS-p: bias rails inefficiency; PS-s and SS: 10% bad strips)
124126
* 0.141: Activate emulation of the signal shape of the InnerTracker FE chip (CROC)
125-
* 0.186: Run-3 goodEdgeAlgo CPE
127+
* 0.186: Run-3 goodEdgeAlgo CPE

Configuration/PyReleaseValidation/python/relval_Run4.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,9 @@
8383
numWFIB.extend([prefixDet+34.758]) # HLTTiming75e33, ticl_barrel
8484
numWFIB.extend([prefixDet+34.759]) # HLTTiming75e33 + NANO
8585
numWFIB.extend([prefixDet+34.77]) # NGTScouting
86-
numWFIB.extend([prefixDet+34.771]) # NGTScouting + NANO
87-
numWFIB.extend([prefixDet+34.772]) # NGTScouting + NANO (including validation)
86+
numWFIB.extend([prefixDet+34.771]) # NGTScouting + alpaka + TICL-v5 + TICL-Barrel
87+
numWFIB.extend([prefixDet+34.772]) # NGTScouting + NANO
88+
numWFIB.extend([prefixDet+34.773]) # NGTScouting + NANO (including validation)
8889

8990
for numWF in numWFIB:
9091
workflows[numWF] = _upgrade_workflows[numWF]

Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2067,7 +2067,7 @@ def condition(self, fragment, stepList, key, hasHarvest):
20672067

20682068
upgradeWFs['NGTScoutingWithNano'] = deepcopy(upgradeWFs['HLTPhase2WithNano'])
20692069
upgradeWFs['NGTScoutingWithNano'].suffix = '_NGTScoutingWithNano'
2070-
upgradeWFs['NGTScoutingWithNano'].offset = 0.771
2070+
upgradeWFs['NGTScoutingWithNano'].offset = 0.772
20712071
upgradeWFs['NGTScoutingWithNano'].step2 = {
20722072
'-s':'DIGI:pdigi_valid,L1TrackTrigger,L1,L1P2GT,DIGI2RAW,HLT:NGTScouting,NANO:@NGTScouting',
20732073
'--datatier':'GEN-SIM-DIGI-RAW,NANOAODSIM',
@@ -2077,7 +2077,7 @@ def condition(self, fragment, stepList, key, hasHarvest):
20772077

20782078
upgradeWFs['NGTScoutingWithNanoValid'] = deepcopy(upgradeWFs['HLTPhase2WithNano'])
20792079
upgradeWFs['NGTScoutingWithNanoValid'].suffix = '_NGTScoutingWithNanoVal'
2080-
upgradeWFs['NGTScoutingWithNanoValid'].offset = 0.772
2080+
upgradeWFs['NGTScoutingWithNanoValid'].offset = 0.773
20812081
upgradeWFs['NGTScoutingWithNanoValid'].step2 = {
20822082
'-s':'DIGI:pdigi_valid,L1TrackTrigger,L1,L1P2GT,DIGI2RAW,HLT:NGTScouting,VALIDATION:@hltValidation,NANO:@NGTScoutingVal',
20832083
'--datatier':'GEN-SIM-DIGI-RAW,NANOAODSIM',
@@ -2154,6 +2154,20 @@ def condition(self, fragment, stepList, key, hasHarvest):
21542154
'-s':'HARVESTING:@hltValidation'
21552155
}
21562156

2157+
upgradeWFs['NGTScoutingAll'] = deepcopy(upgradeWFs['NGTScouting'])
2158+
upgradeWFs['NGTScoutingAll'].suffix = '_NGTScoutingAll'
2159+
upgradeWFs['NGTScoutingAll'].offset = 0.771
2160+
upgradeWFs['NGTScoutingAll'].step2 = {
2161+
'-s':'DIGI:pdigi_valid,L1TrackTrigger,L1,L1P2GT,DIGI2RAW,HLT:NGTScouting,VALIDATION:@hltValidation',
2162+
'--procModifiers': 'ngtScouting,alpaka,ticl_v5,ticl_barrel',
2163+
'--datatier':'GEN-SIM-DIGI-RAW,DQMIO',
2164+
'--eventcontent':'FEVTDEBUGHLT,DQMIO'
2165+
}
2166+
upgradeWFs['NGTScoutingAll'].step3 = {
2167+
'--procModifiers': 'ngtScouting,alpaka,ticl_v5,ticl_barrel',
2168+
'-s':'HARVESTING:@hltValidation'
2169+
}
2170+
21572171
class UpgradeWorkflow_L1Complete(UpgradeWorkflow):
21582172
def setup_(self, step, stepName, stepDict, k, properties):
21592173
if 'Digi' in step and 'NoHLT' not in step:

Configuration/PyReleaseValidation/scripts/runTheMatrix.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,8 +166,9 @@ def runSelected(opt):
166166
29634.758, # HLT phase-2 timing menu ticl_barrel variant
167167
29634.759, # HLT phase-2 timing menu Alpaka, single tracking iteration, LST seeding + CKF building variant
168168
29634.77, # HLT phase-2 NGT Scouting menu
169-
29634.771, # HLT phase-2 NGT Scouting menu, with NANO:@NGTScouting
170-
29634.772] # HLT phase-2 NGT Scouting menu, with NANO:@NGTScoutingVal
169+
29634.771, # HLT phase-2 NGT Scouting menu, Alpaka, TICL-v5, TICL-Barrel
170+
29634.772, # HLT phase-2 NGT Scouting menu, with NANO:@NGTScouting
171+
29634.773] # HLT phase-2 NGT Scouting menu, with NANO:@NGTScoutingVal
171172
}
172173

173174
predefinedSet['limited'] = (

0 commit comments

Comments
 (0)