Merge pull request #47683 from iarspider/iarspider-patches-20250325-2

[L1] Fix dead assignments reported by LLVM-analyzer

Author: cmsbuild

EventFilter/L1GlobalTriggerRawToDigi/src/L1GTDigiToRaw.cc

@@ -656,10 +656,9 @@ unsigned L1GTDigiToRaw::packGMT(L1MuGMTReadoutRecord const& gmtrr, unsigned char
 
   std::vector<L1MuRegionalCand> vrc;
   std::vector<L1MuRegionalCand>::const_iterator irc;
-  unsigned* pp = p;
 
   vrc = gmtrr.getDTBXCands();
-  pp = p;
+  unsigned* pp = p;
   for (irc = vrc.begin(); irc != vrc.end(); irc++) {
     *pp++ = (*irc).getDataWord();
   }

EventFilter/L1TXRawToDigi/plugins/L1TTwinMuxRawToDigi.cc

@@ -297,7 +297,7 @@ void L1TTwinMuxRawToDigi::processFed(int twinMuxFed,
 
   ///--> Trailer - line 2 [must start with 0xA]
 
-  lineFED = readline(lineFED, nline, dataWord);
+  readline(lineFED, nline, dataWord);
   dt_crc::calcCRC(dataWord & 0xFFFFFFFF0000FFFF, newCRC);
 
   ///--> AMC trailer - line 2

L1Trigger/CSCTrackFinder/src/CSCTFPtLUT.cc

@@ -409,8 +409,6 @@ ptdat CSCTFPtLUT::calcPt(const ptadd& address) const {
 
         // First remake the 12-bit dPhi word from the core
         remerged = (address.delta_phi_12 | (address.delta_phi_23 << 8));
-        // Now get 8-bit dPhi12
-        absPhi12 = ((1 << 8) - 1) & remerged;
         // Now get 3-bit dEta
         dEta = ((1 << 3) - 1) & (remerged >> 8);
         // New get CLCT bit. CLCT = true if CLCTPattern = 8, 9, or 10, else 0.

L1Trigger/DTBti/src/DTBtiCard.cc

@@ -386,8 +386,6 @@ DTBtiChip* DTBtiCard::activeGetBTI(int sl, int n) {
       std::cout << " not in range [1," << geom()->nCell(sl) << "]";
       std::cout << " dummy BTI returned!" << std::endl;
     }
-    sl = 1;
-    n = 999;
     return bti;
   }
 
@@ -409,8 +407,6 @@ DTBtiChip* DTBtiCard::activeGetBTI(int sl, int n) {
       std::cout << " invalid superlayer number: " << sl;
       std::cout << " dummy BTI returned!" << std::endl;
     }
-    sl = 1;
-    n = 999;
     return bti;
   }
 

L1Trigger/DTBti/src/DTBtiChipEquations.cc

@@ -160,8 +160,6 @@ void DTBtiChip::computeEqs() {
     //patt 0 always uses Xbc, because Xad could be negative...
     //when wire B is missing,  TshiftB=0
     //when hit B is gone out of shift register, Tshift=K0+1
-    float _difs_p0 = _difs[5];
-
     float TshiftB = 0;
     float TshiftC = 0;
     if (_thisStepUsedHit[3 - 1] == nullptr) {
@@ -180,7 +178,7 @@ void DTBtiChip::computeEqs() {
     } else
       TshiftC = _thisStepUsedHit[2 - 1]->jtrig();
 
-    _difs_p0 = (float)(TshiftB - TshiftC);
+    float _difs_p0 = (float)(TshiftB - TshiftC);
 
     // Zotto's
     _XeqAB_patt0 = (_sums[1] - K0) / 4.;  //eq. AB

L1Trigger/GlobalTrigger/src/L1GlobalTriggerPSB.cc

@@ -1157,12 +1157,6 @@ void L1GlobalTriggerPSB::fillPsbBlock(edm::Event &iEvent,
                     }
                   }
                 }
-              } else {
-                iHf = nHfRingEtSums % hfPerWord;
-                // LogTrace("L1GlobalTrigger")
-                //        << "\n No HfRingEtSums collection - skip "
-                //        << iHf*hfBits << " bits "
-                //        << std::endl;
               }
 
               psbWordValue.setAData(aDataVal, iAB + iPair);

L1Trigger/GlobalTrigger/src/L1GtCorrelationCondition.cc

@@ -723,7 +723,6 @@ const bool L1GtCorrelationCondition::evaluateCondition() const {
                                       << std::endl;
         }
 
-        reqEtaPhiResult = false;
         continue;
 
       } else {

L1Trigger/HardwareValidation/src/L1Comparator.cc

@@ -436,11 +436,6 @@ void L1Comparator::produce(edm::StreamID, edm::Event& iEvent, const edm::EventSe
   edm::Handle<L1MuGMTCandCollection> gmt_emul;
   edm::Handle<L1MuGMTReadoutCollection> gmt_rdt_data_;
   edm::Handle<L1MuGMTReadoutCollection> gmt_rdt_emul_;
-  L1MuRegionalCandCollection const* gmt_rdt_data = nullptr;
-  L1MuRegionalCandCollection const* gmt_rdt_emul = nullptr;
-  //tbd: may compare extended candidates
-  L1MuGMTCandCollection const* gmt_can_data(new L1MuGMTCandCollection);
-  L1MuGMTCandCollection const* gmt_can_emul(new L1MuGMTCandCollection);
   if (runDoSys[GMT]) {
     iEvent.getByToken(tokenMuGMTCand_[0], gmt_data);
     iEvent.getByToken(tokenMuGMTCand_[1], gmt_emul);
@@ -512,10 +507,10 @@ void L1Comparator::produce(edm::StreamID, edm::Event& iEvent, const edm::EventSe
       gmt_rdt_emul_vec.insert(gmt_rdt_emul_vec.end(), rmc.begin(), rmc.end());
     }
   }
-  gmt_rdt_data = &gmt_rdt_data_vec;
-  gmt_rdt_emul = &gmt_rdt_emul_vec;
-  gmt_can_data = &gmt_can_data_vec;
-  gmt_can_emul = &gmt_can_emul_vec;
+  L1MuRegionalCandCollection const* gmt_rdt_data = &gmt_rdt_data_vec;
+  L1MuRegionalCandCollection const* gmt_rdt_emul = &gmt_rdt_emul_vec;
+  L1MuGMTCandCollection const* gmt_can_data = &gmt_can_data_vec;
+  L1MuGMTCandCollection const* gmt_can_emul = &gmt_can_emul_vec;
 
   ///--- done getting collections. ---
 

L1Trigger/L1CaloTrigger/plugins/L1NNCaloTauEmulator.cc

@@ -531,7 +531,7 @@ void L1NNCaloTauEmulator::produce(edm::Event& iEvent, const edm::EventSetup& eSe
 
     float idScore = -1.;
     if (!VsPuId.method().empty()) {
-      idScore = VsPuId.passID(*cl3dIt, cluster);
+      VsPuId.passID(*cl3dIt, cluster);
       idScore = cluster.egVsPUMVAOut();
     }