Skip to content

Commit bfa8e85

Browse files
committed
Add few comments to code
1 parent 2439044 commit bfa8e85

File tree

2 files changed

+17
-2
lines changed

2 files changed

+17
-2
lines changed

Utilities/XrdAdaptor/src/XrdRequestManager.h

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,11 @@ namespace XrdAdaptor {
4141
uint16_t m_code;
4242
};
4343

44+
/**
45+
* The RequestManager manages the requests concerning one PFN.
46+
*
47+
* It implements retries, and can use multiple Sources
48+
*/
4449
class RequestManager {
4550
public:
4651
using IOSize = edm::storage::IOSize;
@@ -212,8 +217,13 @@ namespace XrdAdaptor {
212217
std::vector<std::shared_ptr<Source>> m_activeSources;
213218
std::vector<std::shared_ptr<Source>> m_inactiveSources;
214219

220+
/// Contains the "DataServer" property for disabled Sources and
221+
/// for connections for which the Open() call failed
215222
oneapi::tbb::concurrent_unordered_set<std::string> m_disabledSourceStrings;
223+
/// Contains Source::determineExcludeString() for disabled Sources and
224+
/// for connections for which the Open() call failed
216225
oneapi::tbb::concurrent_unordered_set<std::string> m_disabledExcludeStrings;
226+
/// Sources that have been disabled
217227
oneapi::tbb::concurrent_unordered_set<std::shared_ptr<Source>, SourceHash> m_disabledSources;
218228

219229
// StatisticsSenderService wants to know what our current server is;
@@ -254,8 +264,10 @@ namespace XrdAdaptor {
254264
~OpenHandler() override;
255265

256266
/**
257-
* Handle the file-open response
258-
*/
267+
* Handle the file-open response
268+
*
269+
* Called by XRootD
270+
*/
259271
void HandleResponseWithHosts(XrdCl::XRootDStatus *status,
260272
XrdCl::AnyObject *response,
261273
XrdCl::HostList *hostList) override;

Utilities/XrdAdaptor/src/XrdSource.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ namespace XrdAdaptor {
2020
class XrdSiteStatistics;
2121
class XrdStatisticsService;
2222

23+
/**
24+
* A Source represents a connection to one storage server
25+
*/
2326
class Source : public std::enable_shared_from_this<Source> {
2427
public:
2528
Source(const Source &) = delete;

0 commit comments

Comments
 (0)