Skip to content

Commit c426124

Browse files
committed
Adding Alpaka DQM to HLT
1 parent c45975b commit c426124

File tree

3 files changed

+20
-23
lines changed

3 files changed

+20
-23
lines changed

Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1061,8 +1061,7 @@ def setup_(self, step, stepName, stepDict, k, properties):
10611061
upgradeWFs['PatatrackECALOnlyAlpaka'] = PatatrackWorkflow(
10621062
digi = {
10631063
# customize the ECAL Local Reco part of the HLT menu for Alpaka
1064-
'--procModifiers': 'alpaka',
1065-
'--customise' : 'HLTrigger/Configuration/customizeHLTforAlpaka.customizeHLTforAlpakaEcalLocalReco'
1064+
'--procModifiers': 'alpaka', # alpaka modifier activates customiseHLTForAlpaka
10661065
},
10671066
reco = {
10681067
'-s': 'RAW2DIGI:RawToDigi_ecalOnly,RECO:reconstruction_ecalOnly,VALIDATION:@ecalOnlyValidation,DQM:@ecalOnly',
@@ -1540,8 +1539,7 @@ def setup_(self, step, stepName, stepDict, k, properties):
15401539

15411540
upgradeWFs['PatatrackPixelOnlyAlpaka'] = PatatrackWorkflow(
15421541
digi = {
1543-
'--procModifiers': 'alpaka',
1544-
'--customise' : 'HLTrigger/Configuration/customizeHLTforAlpaka.customizeHLTforAlpakaPixelReco'
1542+
'--procModifiers': 'alpaka', # alpaka modifier activates customiseHLTForAlpaka
15451543
},
15461544
reco = {
15471545
'-s': 'RAW2DIGI:RawToDigi_pixelOnly,RECO:reconstruction_pixelTrackingOnly,VALIDATION:@pixelTrackingOnlyValidation,DQM:@pixelTrackingOnlyDQM',
@@ -1556,8 +1554,7 @@ def setup_(self, step, stepName, stepDict, k, properties):
15561554

15571555
upgradeWFs['PatatrackPixelOnlyAlpakaValidation'] = PatatrackWorkflow(
15581556
digi = {
1559-
'--procModifiers': 'alpaka',
1560-
'--customise' : 'HLTrigger/Configuration/customizeHLTforAlpaka.customizeHLTforAlpakaPixelReco'
1557+
'--procModifiers': 'alpaka', # alpaka modifier activates customiseHLTForAlpaka
15611558
},
15621559
reco = {
15631560
'-s': 'RAW2DIGI:RawToDigi_pixelOnly,RECO:reconstruction_pixelTrackingOnly,VALIDATION:@pixelTrackingOnlyValidation,DQM:@pixelTrackingOnlyDQM',
@@ -1572,8 +1569,7 @@ def setup_(self, step, stepName, stepDict, k, properties):
15721569

15731570
upgradeWFs['PatatrackPixelOnlyAlpakaProfiling'] = PatatrackWorkflow(
15741571
digi = {
1575-
'--procModifiers': 'alpaka',
1576-
'--customise' : 'HLTrigger/Configuration/customizeHLTforAlpaka.customizeHLTforAlpakaPixelReco'
1572+
'--procModifiers': 'alpaka', # alpaka modifier activates customiseHLTForAlpaka
15771573
},
15781574
reco = {
15791575
'-s': 'RAW2DIGI:RawToDigi_pixelOnly,RECO:reconstruction_pixelTrackingOnly',

HLTrigger/Configuration/python/customizeHLTforAlpaka.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33

44
## Pixel HLT in Alpaka
5-
65
def customizeHLTforDQMGPUvsCPUPixel(process):
76
'''Ad-hoc changes to test HLT config containing only DQM_PixelReconstruction_v and DQMGPUvsCPU stream
87
only up to the Pixel Local Reconstruction
@@ -56,14 +55,14 @@ def customizeHLTforDQMGPUvsCPUPixel(process):
5655

5756
# PixelRecHits: monitor of GPU product (Alpaka backend: '')
5857
process.hltPixelRecHitsSoAMonitorGPU = cms.EDProducer('SiPixelPhase1MonitorRecHitsSoAAlpaka',
59-
pixelHitsSrc = cms.InputTag( 'hltSiPixelRecHits' ),
58+
pixelHitsSrc = cms.InputTag( 'hltSiPixelRecHitsSoA' ),
6059
TopFolderName = cms.string( 'SiPixelHeterogeneous/PixelRecHitsGPU' )
6160
)
6261

6362
# PixelRecHits: 'GPUvsCPU' comparisons
6463
process.hltPixelRecHitsSoACompareGPUvsCPU = cms.EDProducer('SiPixelPhase1CompareRecHitsSoAAlpaka',
65-
pixelHitsSrcCPU = cms.InputTag( 'hltSiPixelRecHitsCPUSerial' ),
66-
pixelHitsSrcGPU = cms.InputTag( 'hltSiPixelRecHits' ),
64+
pixelHitsSrcHost = cms.InputTag( 'hltSiPixelRecHitsCPUSerial' ),
65+
pixelHitsSrcDevice = cms.InputTag( 'hltSiPixelRecHitsSoA' ),
6766
topFolderName = cms.string( 'SiPixelHeterogeneous/PixelRecHitsCompareGPUvsCPU' ),
6867
minD2cut = cms.double( 1.0E-4 )
6968
)
@@ -79,7 +78,7 @@ def customizeHLTforDQMGPUvsCPUPixel(process):
7978
process.hltPixelTracksSoAMonitorGPU = cms.EDProducer("SiPixelPhase1MonitorTrackSoAAlpaka",
8079
mightGet = cms.optional.untracked.vstring,
8180
minQuality = cms.string('loose'),
82-
pixelTrackSrc = cms.InputTag('hltPixelTracks'),
81+
pixelTrackSrc = cms.InputTag('hltPixelTracksSoA'),
8382
topFolderName = cms.string('SiPixelHeterogeneous/PixelTrackGPU'),
8483
useQualityCut = cms.bool(True)
8584
)
@@ -88,8 +87,8 @@ def customizeHLTforDQMGPUvsCPUPixel(process):
8887
deltaR2cut = cms.double(0.04),
8988
mightGet = cms.optional.untracked.vstring,
9089
minQuality = cms.string('loose'),
91-
pixelTrackSrcCPU = cms.InputTag("hltPixelTracksCPUSerial"),
92-
pixelTrackSrcGPU = cms.InputTag("hltPixelTracksSoA"),
90+
pixelTrackSrcHost = cms.InputTag("hltPixelTracksCPUSerial"),
91+
pixelTrackSrcDevice = cms.InputTag("hltPixelTracksSoA"),
9392
topFolderName = cms.string('SiPixelHeterogeneous/PixelTrackCompareGPUvsCPU'),
9493
useQualityCut = cms.bool(True)
9594
)
@@ -112,8 +111,8 @@ def customizeHLTforDQMGPUvsCPUPixel(process):
112111
beamSpotSrc = cms.InputTag("hltOnlineBeamSpot"),
113112
dzCut = cms.double(1),
114113
mightGet = cms.optional.untracked.vstring,
115-
pixelVertexSrcCPU = cms.InputTag("hltPixelVerticesCPUSerial"),
116-
pixelVertexSrcGPU = cms.InputTag("hltPixelVerticesSoA"),
114+
pixelVertexSrcHost = cms.InputTag("hltPixelVerticesCPUSerial"),
115+
pixelVertexSrcDevice = cms.InputTag("hltPixelVerticesSoA"),
117116
topFolderName = cms.string('SiPixelHeterogeneous/PixelVertexCompareGPUvsCPU')
118117
)
119118

@@ -463,6 +462,7 @@ def customizeHLTforAlpakaPixelRecoVertexing(process):
463462
process.HLTRecoPixelTracksTask,
464463
process.hltPixelVerticesSoA,
465464
process.hltPixelVertices,
465+
process.hltTrimmedPixelVertices
466466
)
467467

468468
process.HLTRecopixelvertexingCPUSerialTask = cms.ConditionalTask(
@@ -540,7 +540,7 @@ def customizeHLTforAlpakaPixelReco(process):
540540
process = customizeHLTforAlpakaPixelRecoLocal(process)
541541
process = customizeHLTforAlpakaPixelRecoTracking(process)
542542
process = customizeHLTforAlpakaPixelRecoVertexing(process)
543-
543+
process = customizeHLTforDQMGPUvsCPUPixel(process)
544544
process = customizeHLTforAlpakaPixelRecoTheRest(process)
545545

546546
return process

HLTrigger/Configuration/python/customizeHLTforCMSSW.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -270,16 +270,17 @@ def customizeHLTfor43774(process):
270270

271271
return process
272272

273-
# from Configuration.ProcessModifiers.alpaka_cff import alpaka
274-
# from HLTTrigger.Configuration.customizeHLTForAlpaka import customizeHLTforAlpaka
275-
276-
# modifyHLTForAlpaka_ = alpaka.makeProcessModifier(customizeHLTforAlpaka)
277-
278273
# CMSSW version specific customizations
279274
def customizeHLTforCMSSW(process, menuType="GRun"):
280275

281276
process = customiseForOffline(process)
282277

278+
# Alpaka HLT
279+
from Configuration.ProcessModifiers.alpaka_cff import alpaka
280+
from Configuration.Eras.Modifier_run3_common_cff import run3_common
281+
from HLTrigger.Configuration.customizeHLTforAlpaka import customizeHLTforAlpaka
282+
(alpaka & run3_common).makeProcessModifier(customizeHLTforAlpaka).apply(process)
283+
283284
# add call to action function in proper order: newest last!
284285
# process = customiseFor12718(process)
285286

0 commit comments

Comments
 (0)