loose cms type specs and add hitMap comment

brusale · brusale · commit c4e7e819ed7e · 2025-07-10T15:14:47.000+02:00
diff --git a/RecoLocalCalo/HGCalRecProducers/plugins/RecHitMapProducer.cc b/RecoLocalCalo/HGCalRecProducers/plugins/RecHitMapProducer.cc
@@ -73,6 +73,8 @@ void RecHitMapProducer::produce(edm::StreamID, edm::Event& evt, const edm::Event
     return;
   }
 
+  // TODO may be worth to avoid dependency on the order
+  // of the collections, maybe using a map
   MultiVectorManager<HGCRecHit> rechitManager;
   rechitManager.addVector(*ee_hits);
   rechitManager.addVector(*fh_hits);
diff --git a/RecoLocalCalo/HGCalRecProducers/python/recHitMapProducer_cff.py b/RecoLocalCalo/HGCalRecProducers/python/recHitMapProducer_cff.py
@@ -11,4 +11,4 @@
         "particleFlowRecHitHBHE"]
 
 from Configuration.ProcessModifiers.ticl_barrel_cff import ticl_barrel
-ticl_barrel.toModify(recHitMapProducer, hits = hits, hgcalOnly = cms.bool(False)) 
+ticl_barrel.toModify(recHitMapProducer, hits = hits, hgcalOnly = False) 
diff --git a/Validation/Configuration/python/hltHGCalSimValid_cff.py b/Validation/Configuration/python/hltHGCalSimValid_cff.py
@@ -16,7 +16,7 @@
 hits = ["hltHGCalRecHit:HGCEERecHits", "hltHGCalRecHit:HGCHEFRecHits", "hltHGCalRecHit:HGCHEBRecHits"]
 hltRecHitMapProducer = _recHitMapProducer.clone(
     hits = hits,
-    hgcalOnly = cms.bool(True),
+    hgcalOnly = True,
 )
 
 hltLcAssocByEnergyScoreProducer = _lcAssocByEnergyScoreProducer.clone(

Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,8 @@ void RecHitMapProducer::produce(edm::StreamID, edm::Event& evt, const edm::Event`
`73`	`73`	`return;`
`74`	`74`	`}`
`75`	`75`
	`76`	`+ // TODO may be worth to avoid dependency on the order`
	`77`	`+ // of the collections, maybe using a map`
`76`	`78`	`MultiVectorManager<HGCRecHit> rechitManager;`
`77`	`79`	`rechitManager.addVector(*ee_hits);`
`78`	`80`	`rechitManager.addVector(*fh_hits);`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@`
`16`	`16`	`hits = ["hltHGCalRecHit:HGCEERecHits", "hltHGCalRecHit:HGCHEFRecHits", "hltHGCalRecHit:HGCHEBRecHits"]`
`17`	`17`	`hltRecHitMapProducer = _recHitMapProducer.clone(`
`18`	`18`	`hits = hits,`
`19`		`- hgcalOnly = cms.bool(True),`
	`19`	`+ hgcalOnly = True,`
`20`	`20`	`)`
`21`	`21`
`22`	`22`	`hltLcAssocByEnergyScoreProducer = _lcAssocByEnergyScoreProducer.clone(`